From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Tariq Toukan <tariqt@mellanox.com>
Cc: "Saeed Mahameed" <saeedm@mellanox.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org,
"Eugenia Emantayev" <eugenia@mellanox.com>,
brouer@redhat.com, "Toke Høiland-Jørgensen" <toke@toke.dk>
Subject: Re: [net-next 10/13] net/mlx5e: Add support for XDP_REDIRECT in device-out side
Date: Mon, 30 Jul 2018 18:20:25 +0200 [thread overview]
Message-ID: <20180730182025.602089a9@redhat.com> (raw)
In-Reply-To: <66f0a6c6-eb81-b348-2e1a-1fb8c98f73d7@mellanox.com>
On Mon, 30 Jul 2018 16:09:47 +0300
Tariq Toukan <tariqt@mellanox.com> wrote:
> On 30/07/2018 4:06 PM, Jesper Dangaard Brouer wrote:
> >
> > On Mon, 30 Jul 2018 14:10:21 +0200 Jesper Dangaard Brouer <brouer@redhat.com> wrote:
> >
> >> On Thu, 26 Jul 2018 15:56:44 -0700 Saeed Mahameed <saeedm@mellanox.com> wrote:
> >>
> >>> +int mlx5e_xdp_xmit(struct net_device *dev, int n, struct xdp_frame **frames,
> >>> + u32 flags)
> >>> +{
> > [...]
> >>> + xdpi.dma_addr = dma_map_single(sq->pdev, xdpf->data, xdpf->len,
> >>> + DMA_TO_DEVICE);
> >>> + if (unlikely(dma_mapping_error(sq->pdev, xdpi.dma_addr))) {
> >>> + drops++;
> >>
> >> I think you are missing a xdp_return_frame_rx_napi(xdpf) here.
> >
> > I see it already got applied... I'll send a fixup later...
> >
>
> Yes it is applied, I can do it myself. Just let me know what you prefer.
I can take care of this. I already have a patch ready. And I'm eager
to test these patches and compare the performance to the results Toke
and I got for the article based on your earlier patches[1].
[1] https://git.kernel.org/pub/scm/linux/kernel/git/hawk/net-next-xdp.git/log/?h=xdp_paper01
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2018-07-30 17:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 22:56 [pull request][net-next 00/13] Mellanox, mlx5e updates 2018-07-26 (XDP redirect) Saeed Mahameed
2018-07-26 22:56 ` [net-next 01/13] net/mlx5e: Replace call to MPWQE free with dealloc in interface down flow Saeed Mahameed
2018-07-26 22:56 ` [net-next 02/13] net/mlx5e: Do not recycle RX pages " Saeed Mahameed
2018-07-26 22:56 ` [net-next 03/13] net/mlx5e: Gather all XDP pre-requisite checks in a single function Saeed Mahameed
2018-07-26 22:56 ` [net-next 04/13] net/mlx5e: Restrict the combination of large MTU and XDP Saeed Mahameed
2018-07-26 22:56 ` [net-next 05/13] net/mlx5e: Move XDP related code into new XDP files Saeed Mahameed
2018-07-26 22:56 ` [net-next 06/13] net/mlx5e: Add counter for XDP redirect in RX Saeed Mahameed
2018-07-26 22:56 ` [net-next 07/13] net/mlx5e: Make XDP xmit functions more generic Saeed Mahameed
2018-07-26 22:56 ` [net-next 08/13] net/mlx5e: Refactor XDP counters Saeed Mahameed
2018-07-26 22:56 ` [net-next 09/13] net/mlx5e: Re-order fields of struct mlx5e_xdpsq Saeed Mahameed
2018-07-26 22:56 ` [net-next 10/13] net/mlx5e: Add support for XDP_REDIRECT in device-out side Saeed Mahameed
2018-07-30 12:10 ` Jesper Dangaard Brouer
2018-07-30 13:05 ` Tariq Toukan
2018-07-30 13:06 ` Jesper Dangaard Brouer
2018-07-30 13:09 ` Tariq Toukan
2018-07-30 16:20 ` Jesper Dangaard Brouer [this message]
2018-07-30 17:49 ` [net-next PATCH] mlx5: handle DMA mapping error case for XDP redirect Jesper Dangaard Brouer
2018-07-31 6:35 ` Tariq Toukan
2018-07-31 16:47 ` David Miller
2018-07-26 22:56 ` [net-next 11/13] net/mlx5e: RX, Prefetch the xdp_frame data area Saeed Mahameed
2018-07-26 22:56 ` [net-next 12/13] net/mlx5e: TX, Move DB fields in TXQ-SQ struct Saeed Mahameed
2018-07-26 22:56 ` [net-next 13/13] net/mlx5e: TX, Use function to access sq_dma object in fifo Saeed Mahameed
2018-07-27 4:33 ` [pull request][net-next 00/13] Mellanox, mlx5e updates 2018-07-26 (XDP redirect) David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180730182025.602089a9@redhat.com \
--to=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=eugenia@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=tariqt@mellanox.com \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.