From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [PATCH v2] drm/vkms: Use new return type vm_fault_t Date: Mon, 30 Jul 2018 15:34:54 -0300 Message-ID: <20180730183454.GA5400@juma> References: <20180726144549.GA9434@jordon-HP-15-Notebook-PC> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qt0-f195.google.com (mail-qt0-f195.google.com [209.85.216.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id D81A789B98 for ; Mon, 30 Jul 2018 18:35:02 +0000 (UTC) Received: by mail-qt0-f195.google.com with SMTP id y19-v6so13183283qto.5 for ; Mon, 30 Jul 2018 11:35:02 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180726144549.GA9434@jordon-HP-15-Notebook-PC> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Souptick Joarder Cc: hamohammed.sa@gmail.com, rodrigosiqueiramelo@gmail.com, airlied@linux.ie, daniel.vetter@ffwll.ch, linux-kernel@vger.kernel.org, willy@infradead.org, gustavo.padovan@collabora.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgU291cHRpY2ssCgpPbiBUaHUsIEp1bCAyNiwgMjAxOCBhdCAwODoxNTo0OVBNICswNTMwLCBT b3VwdGljayBKb2FyZGVyIHdyb3RlOgo+IFVzZSBuZXcgcmV0dXJuIHR5cGUgdm1fZmF1bHRfdCBm b3IgZmF1bHQgaGFuZGxlci4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBTb3VwdGljayBKb2FyZGVyIDxq cmRyLmxpbnV4QGdtYWlsLmNvbT4KPiAtLS0KPiB2MjogVXBkYXRlZCBwYXRjaCB0aXRsZQo+IAo+ ICBkcml2ZXJzL2dwdS9kcm0vdmttcy92a21zX2Rydi5oIHwgMiArLQo+ICBkcml2ZXJzL2dwdS9k cm0vdmttcy92a21zX2dlbS5jIHwgNSArKy0tLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDMgaW5zZXJ0 aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L3ZrbXMvdmttc19kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS92a21zL3ZrbXNfZHJ2LmgKPiBpbmRl eCAwN2JlMjlmLi5kNWQwNGE4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS92a21zL3Zr bXNfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vdmttcy92a21zX2Rydi5oCj4gQEAgLTY1 LDcgKzY1LDcgQEAgc3RydWN0IGRybV9nZW1fb2JqZWN0ICp2a21zX2dlbV9jcmVhdGUoc3RydWN0 IGRybV9kZXZpY2UgKmRldiwKPiAgCQkJCSAgICAgICB1MzIgKmhhbmRsZSwKPiAgCQkJCSAgICAg ICB1NjQgc2l6ZSk7Cj4gIAo+IC1pbnQgdmttc19nZW1fZmF1bHQoc3RydWN0IHZtX2ZhdWx0ICp2 bWYpOwo+ICt2bV9mYXVsdF90IHZrbXNfZ2VtX2ZhdWx0KHN0cnVjdCB2bV9mYXVsdCAqdm1mKTsK PiAgCj4gIGludCB2a21zX2R1bWJfY3JlYXRlKHN0cnVjdCBkcm1fZmlsZSAqZmlsZSwgc3RydWN0 IGRybV9kZXZpY2UgKmRldiwKPiAgCQkgICAgIHN0cnVjdCBkcm1fbW9kZV9jcmVhdGVfZHVtYiAq YXJncyk7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS92a21zL3ZrbXNfZ2VtLmMgYi9k cml2ZXJzL2dwdS9kcm0vdmttcy92a21zX2dlbS5jCj4gaW5kZXggYzdlMzgzNi4uNjJlMDVkYyAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vdmttcy92a21zX2dlbS5jCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL3ZrbXMvdmttc19nZW0uYwo+IEBAIC00MywxNCArNDMsMTQgQEAgdm9pZCB2 a21zX2dlbV9mcmVlX29iamVjdChzdHJ1Y3QgZHJtX2dlbV9vYmplY3QgKm9iaikKPiAgCWtmcmVl KGdlbSk7Cj4gIH0KPiAgCj4gLWludCB2a21zX2dlbV9mYXVsdChzdHJ1Y3Qgdm1fZmF1bHQgKnZt ZikKPiArdm1fZmF1bHRfdCB2a21zX2dlbV9mYXVsdChzdHJ1Y3Qgdm1fZmF1bHQgKnZtZikKPiAg ewo+ICAJc3RydWN0IHZtX2FyZWFfc3RydWN0ICp2bWEgPSB2bWYtPnZtYTsKPiAgCXN0cnVjdCB2 a21zX2dlbV9vYmplY3QgKm9iaiA9IHZtYS0+dm1fcHJpdmF0ZV9kYXRhOwo+ICAJdW5zaWduZWQg bG9uZyB2YWRkciA9IHZtZi0+YWRkcmVzczsKPiAgCXBnb2ZmX3QgcGFnZV9vZmZzZXQ7Cj4gIAls b2ZmX3QgbnVtX3BhZ2VzOwo+IC0JaW50IHJldDsKPiArCXZtX2ZhdWx0X3QgcmV0ID0gVk1fRkFV TFRfU0lHQlVTOwo+ICAKPiAgCXBhZ2Vfb2Zmc2V0ID0gKHZhZGRyIC0gdm1hLT52bV9zdGFydCkg Pj4gUEFHRV9TSElGVDsKPiAgCW51bV9wYWdlcyA9IERJVl9ST1VORF9VUChvYmotPmdlbS5zaXpl LCBQQUdFX1NJWkUpOwo+IEBAIC01OCw3ICs1OCw2IEBAIGludCB2a21zX2dlbV9mYXVsdChzdHJ1 Y3Qgdm1fZmF1bHQgKnZtZikKPiAgCWlmIChwYWdlX29mZnNldCA+IG51bV9wYWdlcykKPiAgCQly ZXR1cm4gVk1fRkFVTFRfU0lHQlVTOwo+ICAKPiAtCXJldCA9IC1FTk9FTlQ7Cj4gIAltdXRleF9s b2NrKCZvYmotPnBhZ2VzX2xvY2spOwo+ICAJaWYgKG9iai0+cGFnZXMpIHsKPiAgCQlnZXRfcGFn ZShvYmotPnBhZ2VzW3BhZ2Vfb2Zmc2V0XSk7Cj4gLS0gCj4gMS45LjEKClBhdGNoIHB1c2hlZCB0 byBkcm0tbWlzYy1uZXh0LiB2a21zIGlzIHN0aWxsIGV4cGVyaW1lbnRhbCBzbyBJJ20gbm90CnF1 ZXVlaW5nIHRoaXMgZm9yIDQuMTkuIFRoYW5rcy4KCkd1c3Rhdm8KCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6F94C43142 for ; Mon, 30 Jul 2018 18:35:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9CB3720840 for ; Mon, 30 Jul 2018 18:35:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CB3720840 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=padovan.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731557AbeG3ULT (ORCPT ); Mon, 30 Jul 2018 16:11:19 -0400 Received: from mail-qt0-f194.google.com ([209.85.216.194]:44474 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729477AbeG3ULT (ORCPT ); Mon, 30 Jul 2018 16:11:19 -0400 Received: by mail-qt0-f194.google.com with SMTP id b15-v6so13173832qtp.11 for ; Mon, 30 Jul 2018 11:35:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=kQi1TM0lpCOqOZYKHd8ujoQLm/MKQK2jUpVDMZLURq0=; b=REoh2SMdu7YUzirr9DAZTPFYUeIOhbJhAwtE3mR5tkdgXQ3iXGCG/TXBLGyyaxfwHF oNxW0TiMqOPLNEiY6P3uWakBtvlJCPw1gKQccERVp3nxg2105lNbKptAAXxGJNtyuJ/t q8wg3yH3UPNURq1WbwfTWIrQ1JXv+lzi29IwGlMTGVveIFF8i4P5Yu0HszfvqOtFe19/ ZkiYvpjT4x5sZjHMrfGjfcY/4WkouqTjbco2U8X+BjCU+TzxS0CQSKu+egcQ68MOUE5J AU65gSQBbXEsxeEg42YQfwizpZCREvztQ7wKPIlYKsuJo8nq4m3zZaDGfrIcw+ngwqC1 /8IQ== X-Gm-Message-State: AOUpUlGxUD3bP56NjZx0H67bp90e19Iy8zZZ1UmA4gkdwWf9sMfrCclO 6/vzkYB07wAbyrnvPKRqWZo= X-Google-Smtp-Source: AAOMgpfcEr1eoPWcZvcGsFBCDvtYfB4LllfReOl9L6TkrPYwyu5gYYkiauT0k9B3MA0jM79Lck9AqQ== X-Received: by 2002:a0c:b24c:: with SMTP id k12-v6mr16287919qve.152.1532975701848; Mon, 30 Jul 2018 11:35:01 -0700 (PDT) Received: from juma ([177.73.70.202]) by smtp.gmail.com with ESMTPSA id t127-v6sm3789656qkd.1.2018.07.30.11.34.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Jul 2018 11:35:01 -0700 (PDT) Date: Mon, 30 Jul 2018 15:34:54 -0300 From: Gustavo Padovan To: Souptick Joarder Cc: willy@infradead.org, airlied@linux.ie, daniel.vetter@ffwll.ch, rodrigosiqueiramelo@gmail.com, gustavo.padovan@collabora.com, hamohammed.sa@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2] drm/vkms: Use new return type vm_fault_t Message-ID: <20180730183454.GA5400@juma> References: <20180726144549.GA9434@jordon-HP-15-Notebook-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180726144549.GA9434@jordon-HP-15-Notebook-PC> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Souptick, On Thu, Jul 26, 2018 at 08:15:49PM +0530, Souptick Joarder wrote: > Use new return type vm_fault_t for fault handler. > > Signed-off-by: Souptick Joarder > --- > v2: Updated patch title > > drivers/gpu/drm/vkms/vkms_drv.h | 2 +- > drivers/gpu/drm/vkms/vkms_gem.c | 5 ++--- > 2 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/vkms/vkms_drv.h b/drivers/gpu/drm/vkms/vkms_drv.h > index 07be29f..d5d04a8 100644 > --- a/drivers/gpu/drm/vkms/vkms_drv.h > +++ b/drivers/gpu/drm/vkms/vkms_drv.h > @@ -65,7 +65,7 @@ struct drm_gem_object *vkms_gem_create(struct drm_device *dev, > u32 *handle, > u64 size); > > -int vkms_gem_fault(struct vm_fault *vmf); > +vm_fault_t vkms_gem_fault(struct vm_fault *vmf); > > int vkms_dumb_create(struct drm_file *file, struct drm_device *dev, > struct drm_mode_create_dumb *args); > diff --git a/drivers/gpu/drm/vkms/vkms_gem.c b/drivers/gpu/drm/vkms/vkms_gem.c > index c7e3836..62e05dc 100644 > --- a/drivers/gpu/drm/vkms/vkms_gem.c > +++ b/drivers/gpu/drm/vkms/vkms_gem.c > @@ -43,14 +43,14 @@ void vkms_gem_free_object(struct drm_gem_object *obj) > kfree(gem); > } > > -int vkms_gem_fault(struct vm_fault *vmf) > +vm_fault_t vkms_gem_fault(struct vm_fault *vmf) > { > struct vm_area_struct *vma = vmf->vma; > struct vkms_gem_object *obj = vma->vm_private_data; > unsigned long vaddr = vmf->address; > pgoff_t page_offset; > loff_t num_pages; > - int ret; > + vm_fault_t ret = VM_FAULT_SIGBUS; > > page_offset = (vaddr - vma->vm_start) >> PAGE_SHIFT; > num_pages = DIV_ROUND_UP(obj->gem.size, PAGE_SIZE); > @@ -58,7 +58,6 @@ int vkms_gem_fault(struct vm_fault *vmf) > if (page_offset > num_pages) > return VM_FAULT_SIGBUS; > > - ret = -ENOENT; > mutex_lock(&obj->pages_lock); > if (obj->pages) { > get_page(obj->pages[page_offset]); > -- > 1.9.1 Patch pushed to drm-misc-next. vkms is still experimental so I'm not queueing this for 4.19. Thanks. Gustavo