From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 17/17] fs-test: fix false positive error at Test Case 12
Date: Tue, 31 Jul 2018 16:55:11 +0900 [thread overview]
Message-ID: <20180731075509.GK11258@linaro.org> (raw)
In-Reply-To: <dc13ba7d-a7a5-01fd-d296-337064e32123@gmx.de>
On Sun, Jul 29, 2018 at 09:02:00AM +0200, Heinrich Schuchardt wrote:
> On 07/20/2018 04:57 AM, AKASHI Takahiro wrote:
> > The error message to be matched is wrong. Fix it.
> >
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> > ---
> > test/fs/fs-test.sh | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/test/fs/fs-test.sh b/test/fs/fs-test.sh
> > index 2e8d5ee4df..7b0c5ea56f 100755
> > --- a/test/fs/fs-test.sh
> > +++ b/test/fs/fs-test.sh
> > @@ -522,7 +522,7 @@ function check_results() {
> > "TC11: 1MB write to $3.w - content verified"
> >
> > # Check lookup of 'dot' directory
> > - grep -A4 "Test Case 12 " "$1" | grep -q 'Unable to write file'
> > + grep -A4 "Test Case 12 " "$1" | grep -q 'Unable to write'
> > pass_fail "TC12: 1MB write to . - write denied"
> >
> > # Check directory traversal
> >
>
> Tom suggested in
> https://lists.denx.de/pipermail/u-boot/2018-July/336378.html that the
> comment headers in test/fs/fs-test.sh should be updated to reflect the
> total number of passes and fails.
Thank you for this heads-up.
I'm now trying to rewrite fs-test.sh (at least part of it) on top of
py.test framework.
It will take some time as I'm still learning how to write tests for py.test.
-Takahiro AKASHI
> Best regards
>
> Heinrich
next prev parent reply other threads:[~2018-07-31 7:55 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 2:57 [U-Boot] [PATCH 00/17] fs: fat: extend FAT write operations AKASHI Takahiro
2018-07-20 2:57 ` [U-Boot] [PATCH 01/17] fs: fat: extend get_fs_info() for write use AKASHI Takahiro
2018-07-20 18:06 ` Heinrich Schuchardt
2018-07-22 7:43 ` Heinrich Schuchardt
2018-07-20 2:57 ` [U-Boot] [PATCH 02/17] fs: fat: handle "." and ".." of root dir correctly with fat_itr_resolve() AKASHI Takahiro
2018-07-20 18:09 ` Heinrich Schuchardt
2018-07-23 7:55 ` AKASHI Takahiro
2018-07-20 2:57 ` [U-Boot] [PATCH 03/17] fs: fat: make directory iterator global for write use AKASHI Takahiro
2018-07-20 18:02 ` Heinrich Schuchardt
2018-07-23 8:06 ` AKASHI Takahiro
2018-07-23 8:18 ` AKASHI Takahiro
2018-08-11 13:34 ` Heinrich Schuchardt
2018-08-20 4:45 ` AKASHI Takahiro
2018-07-20 2:57 ` [U-Boot] [PATCH 04/17] fs: fat: assure iterator's ->dent belongs to ->clust AKASHI Takahiro
2018-07-20 2:57 ` [U-Boot] [PATCH 05/17] fs: fat: check and normailze file name AKASHI Takahiro
2018-07-31 4:31 ` Heinrich Schuchardt
2018-07-20 2:57 ` [U-Boot] [PATCH 06/17] fs: fat: write returns error code instead of -1 AKASHI Takahiro
2018-07-20 17:55 ` Heinrich Schuchardt
2018-07-23 8:32 ` AKASHI Takahiro
2018-07-20 2:57 ` [U-Boot] [PATCH 07/17] fs: fat: support write with sub-directory path AKASHI Takahiro
2018-07-20 2:57 ` [U-Boot] [PATCH 08/17] fs: fat: refactor write interface for a file offset AKASHI Takahiro
2018-07-20 2:57 ` [U-Boot] [PATCH 09/17] fs: fat: support write with non-zero offset AKASHI Takahiro
2018-07-20 17:46 ` Heinrich Schuchardt
2018-07-23 8:41 ` AKASHI Takahiro
2018-07-20 2:57 ` [U-Boot] [PATCH 10/17] cmd: fat: add offset parameter to fatwrite AKASHI Takahiro
2018-07-20 2:57 ` [U-Boot] [PATCH 11/17] fs: add mkdir interface AKASHI Takahiro
2018-07-20 17:35 ` Heinrich Schuchardt
2018-07-23 23:48 ` Simon Glass
2018-07-23 23:56 ` Tom Rini
2018-07-24 1:45 ` AKASHI Takahiro
2018-07-25 2:45 ` Simon Glass
2018-07-24 0:56 ` AKASHI Takahiro
2018-07-20 2:57 ` [U-Boot] [PATCH 12/17] fs: fat: remember the starting cluster number of directory AKASHI Takahiro
2018-07-20 2:57 ` [U-Boot] [PATCH 13/17] fs: fat: support mkdir AKASHI Takahiro
2018-07-20 17:14 ` Heinrich Schuchardt
2018-07-24 2:01 ` AKASHI Takahiro
2018-07-20 2:57 ` [U-Boot] [PATCH 14/17] cmd: fat: add fatmkdir command AKASHI Takahiro
2018-07-20 17:09 ` Heinrich Schuchardt
2018-07-24 2:07 ` AKASHI Takahiro
2018-07-20 2:57 ` [U-Boot] [PATCH 15/17] efi_loader: file: support creating a directory AKASHI Takahiro
2018-07-20 2:57 ` [U-Boot] [PATCH 16/17] efi_loader: implement a pseudo "file delete" AKASHI Takahiro
2018-07-20 2:57 ` [U-Boot] [PATCH 17/17] fs-test: fix false positive error at Test Case 12 AKASHI Takahiro
2018-07-29 7:02 ` Heinrich Schuchardt
2018-07-31 7:55 ` AKASHI Takahiro [this message]
2018-07-20 9:48 ` [U-Boot] [PATCH 00/17] fs: fat: extend FAT write operations Heinrich Schuchardt
2018-07-22 6:44 ` Heinrich Schuchardt
2018-07-23 7:35 ` AKASHI Takahiro
2018-07-23 14:46 ` Tom Rini
2018-08-06 22:34 ` Heinrich Schuchardt
2018-08-07 5:38 ` AKASHI Takahiro
2018-08-07 5:52 ` AKASHI Takahiro
2018-08-07 5:53 ` Heinrich Schuchardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180731075509.GK11258@linaro.org \
--to=takahiro.akashi@linaro.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.