All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <frederic@kernel.org>
To: Anna-Maria Gleixner <anna-maria@linutronix.de>
Cc: linux-kernel@vger.kernel.org, bigeasy@linutronix.de,
	tglx@linutronix.de, bristot@redhat.com,
	paulmck@linux.vnet.ibm.com, peterz@infradead.org
Subject: Re: [PATCH] nohz: Fix local_timer_softirq_pending()
Date: Tue, 31 Jul 2018 19:14:27 +0200	[thread overview]
Message-ID: <20180731171426.GD28353@lerouge> (raw)
In-Reply-To: <20180731161358.29472-1-anna-maria@linutronix.de>

On Tue, Jul 31, 2018 at 06:13:58PM +0200, Anna-Maria Gleixner wrote:
> local_timer_softirq_pending() checks whether the timer softirq is
> pending with: local_softirq_pending() & TIMER_SOFTIRQ.
> 
> This is wrong because TIMER_SOFTIRQ is the softirq number and not a
> bitmask. So the test checks for the wrong bit.
> 
> Use BIT(TIMER_SOFTIRQ) instead.
> 
> Fixes: 5d62c183f9e9 ("nohz: Prevent a timer interrupt storm in tick_nohz_stop_sched_tick()")
> Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>

Acked-by: Frederic Weisbecker <frederic@kernel.org>

Thanks!

  parent reply	other threads:[~2018-07-31 17:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-31 16:13 [PATCH] nohz: Fix local_timer_softirq_pending() Anna-Maria Gleixner
2018-07-31 16:50 ` Paul E. McKenney
2018-07-31 17:07 ` Daniel Bristot de Oliveira
2018-07-31 17:14 ` Frederic Weisbecker [this message]
2018-07-31 20:13 ` [tip:timers/urgent] " tip-bot for Anna-Maria Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180731171426.GD28353@lerouge \
    --to=frederic@kernel.org \
    --cc=anna-maria@linutronix.de \
    --cc=bigeasy@linutronix.de \
    --cc=bristot@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.