From: Guenter Roeck <linux@roeck-us.net>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Stefan Agner <stefan@agner.ch>, Christoph Hellwig <hch@lst.de>,
Krzysztof Kozlowski <krzk@kernel.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Fugang Duan <fugang.duan@nxp.com>
Subject: Re: [BUG BISECT] Ethernet fail on VF50 (OF: Don't set default coherent DMA mask)
Date: Tue, 31 Jul 2018 10:38:59 -0700 [thread overview]
Message-ID: <20180731173859.GA17007@roeck-us.net> (raw)
In-Reply-To: <10c2ca4d-d587-2705-2802-b6df3dc72fd4@arm.com>
On Tue, Jul 31, 2018 at 04:58:41PM +0100, Robin Murphy wrote:
> On 31/07/18 16:43, Guenter Roeck wrote:
> >On Tue, Jul 31, 2018 at 03:09:34PM +0100, Robin Murphy wrote:
> >>>Please note that sparc images still generate the warning (next-20180731).
> >>
> >>Ugh, OK, any ideas what sparc does to create these platform devices that
> >>isn't of_platform_device_create_pdata() and has somehow grown an implicit
> >>dependency on of_dma_configure() since 4.12? I'm looking, but nothing jumps
> >>out...
> >>
> >
> >I suspect it might be of_device_register(), called from
> > arch/sparc/kernel/of_device_64.c:scan_one_device()
> > arch/sparc/kernel/of_device_32.c:scan_one_device()
>
> Right, that's as far as I got as well, so I'm struggling to see how these
> things ever got DMA masks set before the of_dma_configure() call moved out
> of of_platform_device_create_pdata(), or why it wasn't a problem prior to
> the generic dma_ops rework if they didn't :/
>
Ah, ok. No idea, sorry. All I know is that the messages were first seen
with next-20180727.
Guenter
next prev parent reply other threads:[~2018-07-31 17:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 13:11 [BUG BISECT] Ethernet fail on VF50 (OF: Don't set default coherent DMA mask) Krzysztof Kozlowski
2018-07-27 13:18 ` Krzysztof Kozlowski
2018-07-27 14:04 ` Christoph Hellwig
2018-07-28 16:58 ` Guenter Roeck
2018-07-30 9:23 ` Christoph Hellwig
2018-07-30 14:38 ` Robin Murphy
2018-07-31 0:50 ` Guenter Roeck
2018-07-31 8:19 ` Stefan Agner
2018-07-31 12:32 ` Robin Murphy
2018-07-31 13:26 ` Guenter Roeck
2018-07-31 14:09 ` Robin Murphy
2018-07-31 15:43 ` Guenter Roeck
2018-07-31 15:58 ` Robin Murphy
2018-07-31 17:38 ` Guenter Roeck [this message]
2018-08-01 16:33 ` Robin Murphy
2018-08-01 18:23 ` Guenter Roeck
2018-07-31 15:53 ` Stefan Agner
2018-07-31 16:29 ` Robin Murphy
2018-07-31 19:02 ` Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180731173859.GA17007@roeck-us.net \
--to=linux@roeck-us.net \
--cc=ard.biesheuvel@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=hch@lst.de \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.