From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH v2 1/6] i2c: designware: use generic table matching Date: Tue, 31 Jul 2018 22:41:25 +0200 Message-ID: <20180731204125.GA1491@piout.net> References: <20180731134740.441-1-alexandre.belloni@bootlin.com> <20180731134740.441-2-alexandre.belloni@bootlin.com> <44e52856371e4b5c102df8f2efebd527fd26b066.camel@linux.intel.com> <0559c93256ae4f59aed278912bcbfd996e279839.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <0559c93256ae4f59aed278912bcbfd996e279839.camel@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Andy Shevchenko Cc: Wolfram Sang , Jarkko Nikula , James Hogan , Paul Burton , Mika Westerberg , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, Thomas Petazzoni , Allan Nielsen List-Id: linux-i2c@vger.kernel.org On 31/07/2018 17:23:04+0300, Andy Shevchenko wrote: > On Tue, 2018-07-31 at 17:02 +0300, Andy Shevchenko wrote: > > On Tue, 2018-07-31 at 15:47 +0200, Alexandre Belloni wrote: > > > Switch to device_get_match_data in probe to match the device > > > specific > > > data > > > instead of using the acpi specific function. > > > > > > > Reviewed-by: Andy Shevchenko > > Oops. See below. > > > > - id = acpi_match_device(pdev->dev.driver->acpi_match_table, > > > &pdev->dev); > > > - if (id && id->driver_data) > > > - dev->flags |= (u32)id->driver_data; > I'll change that cast to (uintptr_t). Else gcc complains about the size mismatch on 64 bit platform. I'm letting kbuild play with my branch a bit before sending v3. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com