From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Moti Haimovsky <motih@mellanox.com>
Cc: shahafs@mellanox.com, dev@dpdk.org, nelio.laranjeiro@6wind.com
Subject: Re: [PATCH v1] net/mlx5: fix RSS flow configuration crash
Date: Wed, 1 Aug 2018 16:13:44 +0200 [thread overview]
Message-ID: <20180801141344.GH5211@6wind.com> (raw)
In-Reply-To: <1533130807-9183-1-git-send-email-motih@mellanox.com>
On Wed, Aug 01, 2018 at 04:40:07PM +0300, Moti Haimovsky wrote:
> This commit fixes a segmentation fault observed when configuring
> mlx5 with RSS flow rule containing invalid queues indices such as
> negative numbers, queue numbers bigger than the number Rx queues the
> PMD or has no queues at all.
>
> Fixes: 592f05b29a25 ("net/mlx5: add RSS flow action")
> Cc: nelio.laranjeiro@6wind.com
>
> Signed-off-by: Moti Haimovsky <motih@mellanox.com>
> ---
> v1:
> * Added check for zero queues.
NACK until my previous comment regarding RTE_FLOW_ERROR_TYPE_ACTION_CONF is
taken into account.
--
Adrien Mazarguil
6WIND
next prev parent reply other threads:[~2018-08-01 14:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 10:43 [PATCH] net/mlx5: fix RSS flow configuration crash Moti Haimovsky
2018-08-01 11:01 ` Adrien Mazarguil
2018-08-01 13:40 ` [PATCH v1] " Moti Haimovsky
2018-08-01 14:13 ` Adrien Mazarguil [this message]
2018-08-02 8:41 ` [PATCH v2] " Moti Haimovsky
2018-08-02 11:17 ` Shahaf Shuler
2018-08-02 11:18 ` Adrien Mazarguil
2018-08-02 11:20 ` Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180801141344.GH5211@6wind.com \
--to=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=motih@mellanox.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=shahafs@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.