From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/cutelyst: Fix build dependencies
Date: Wed, 1 Aug 2018 14:27:12 +0200 [thread overview]
Message-ID: <20180801142712.5281ca21@windsurf> (raw)
In-Reply-To: <20180801114738.5044-1-dantti12@gmail.com>
Hello Daniel,
Thanks for providing this fix!
On Wed, 1 Aug 2018 08:47:38 -0300, Daniel Nicoletti wrote:
> Add missing optional dependencies need when
> the dependency was available, disabling Grantlee
> plugin for now as it failed to build.
>
> Signed-off-by: Daniel Nicoletti <dantti12@gmail.com>
I've applied, but after changing one thing:
> ---
> package/cutelyst/cutelyst.mk | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/package/cutelyst/cutelyst.mk b/package/cutelyst/cutelyst.mk
> index 438ac091c6..2d1c9b1532 100644
> --- a/package/cutelyst/cutelyst.mk
> +++ b/package/cutelyst/cutelyst.mk
> @@ -15,20 +15,16 @@ CUTELYST_DEPENDENCIES = qt5base
> CUTELYST_CONF_OPTS += \
> -DPLUGIN_CSRFPROTECTION=ON
>
> -ifeq ($(BR2_PACKAGE_GRANTLEE),y)
> -CUTELYST_CONF_OPTS += -DPLUGIN_VIEW_GRANTLEE=ON
> -else
> -CUTELYST_CONF_OPTS += -DPLUGIN_VIEW_GRANTLEE=OFF
> -endif
I've kept an unconditional -DPLUGIN_VIEW_GRANTLEE=OFF to make sure that
grantlee support is always disabled, even if grantlee gets
built/installed before cutelyst.
However, there are other build issues of the cutelyst package which
don't seem to be related:
- http://autobuild.buildroot.net/results/b4b/b4bd0807fed721d8f553f1392e7d1fa51545d046/build-end.log
Lots of Qt/C++ errors.
- http://autobuild.buildroot.net/results/555/555cf0cd59c9c832b15c604dae5bad3640f8b450/build-end.log
Doxygen missing. We have a host-doxygen package in Buildroot, but it
would be a lot nicer of Cutelyst would not require Doxygen. Any
chance to make this optional ? We don't really care about building
documentation in the context of Buildroot.
- http://autobuild.buildroot.net/results/771/7716878c3a26b93417188ad7eac91ace172815bb/build-end.log
lrelease not found
Could you have a look at those remaining build issues ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-08-01 12:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 11:47 [Buildroot] [PATCH] package/cutelyst: Fix build dependencies Daniel Nicoletti
2018-08-01 12:27 ` Thomas Petazzoni [this message]
2018-08-01 12:55 ` Daniel Nicoletti
2018-08-01 13:00 ` Daniel Nicoletti
2018-08-01 13:06 ` Thomas Petazzoni
2018-08-01 13:11 ` Daniel Nicoletti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180801142712.5281ca21@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.