From: "J . Bruce Fields" <bfields@fieldses.org>
To: Eric Biggers <ebiggers3@gmail.com>
Cc: linux-nfs@vger.kernel.org, Jeff Layton <jlayton@kernel.org>,
Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH] nfsd: constify write_op[]
Date: Wed, 1 Aug 2018 11:31:36 -0400 [thread overview]
Message-ID: <20180801153136.GC18338@fieldses.org> (raw)
In-Reply-To: <20180717180125.142261-1-ebiggers3@gmail.com>
On Tue, Jul 17, 2018 at 11:01:25AM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> write_op[] is never modified, so make it 'const'.
Thanks, applying for 2.19.--b.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> fs/nfsd/nfsctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
> index 2c46451c7d60..19aa4ded2590 100644
> --- a/fs/nfsd/nfsctl.c
> +++ b/fs/nfsd/nfsctl.c
> @@ -73,7 +73,7 @@ static ssize_t write_recoverydir(struct file *file, char *buf, size_t size);
> static ssize_t write_v4_end_grace(struct file *file, char *buf, size_t size);
> #endif
>
> -static ssize_t (*write_op[])(struct file *, char *, size_t) = {
> +static ssize_t (*const write_op[])(struct file *, char *, size_t) = {
> [NFSD_Fh] = write_filehandle,
> [NFSD_FO_UnlockIP] = write_unlock_ip,
> [NFSD_FO_UnlockFS] = write_unlock_fs,
> --
> 2.18.0.203.gfac676dfb9-goog
prev parent reply other threads:[~2018-08-01 17:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 18:01 [PATCH] nfsd: constify write_op[] Eric Biggers
2018-08-01 15:31 ` J . Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180801153136.GC18338@fieldses.org \
--to=bfields@fieldses.org \
--cc=ebiggers3@gmail.com \
--cc=ebiggers@google.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.