All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Dennis Zhou <dennisszhou@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>, Josef Bacik <jbacik@fb.com>,
	kernel-team@fb.com, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH v2] block: make iolatency avg_lat exponentially decay
Date: Wed, 1 Aug 2018 08:49:58 -0700	[thread overview]
Message-ID: <20180801154958.GP1206094@devbig004.ftw2.facebook.com> (raw)
In-Reply-To: <20180801002559.36261-1-dennisszhou@gmail.com>

Hello,

On Tue, Jul 31, 2018 at 05:25:59PM -0700, Dennis Zhou wrote:
...
> +	/*
> +	 * CALC_LOAD takes in a number stored in fixed point representation.
> +	 * Because we are using this for IO time in ns, the values stored
> +	 * are significantly larger than the FIXED_1 denominator (2048).
> +	 * Therefore, rounding errors in the calculation are negligible and
> +	 * can be ignored.
> +	 */
> +	exp_idx = min_t(int, BLKIOLATENCY_NR_EXP_FACTORS - 1,
> +			iolat->cur_win_nsec / BLKIOLATENCY_EXP_BUCKET_SIZE);

Build bot is complaining about naked 64bit div.  Should use one of the
div64*() helpers.

Looks good to me.  Once Johannes's concerns are addressed, please feel
free to add

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun

  parent reply	other threads:[~2018-08-01 15:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-01  0:25 [PATCH v2] block: make iolatency avg_lat exponentially decay Dennis Zhou
2018-08-01  4:46 ` kbuild test robot
2018-08-01 15:49 ` Tejun Heo [this message]
2018-08-01 16:10   ` Tejun Heo
2018-08-02  6:11     ` Dennis Zhou
2018-08-01 16:02 ` Johannes Weiner
2018-08-01 16:26 ` Josef Bacik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180801154958.GP1206094@devbig004.ftw2.facebook.com \
    --to=tj@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=dennisszhou@gmail.com \
    --cc=hannes@cmpxchg.org \
    --cc=jbacik@fb.com \
    --cc=kernel-team@fb.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.