From: Al Viro <viro@ZenIV.linux.org.uk>
To: Christoph Hellwig <hch@lst.de>
Cc: Avi Kivity <avi@scylladb.com>,
linux-aio@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] aio: implement IOCB_CMD_POLL
Date: Thu, 2 Aug 2018 00:54:12 +0100 [thread overview]
Message-ID: <20180801235412.GT30522@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20180730071544.23998-4-hch@lst.de>
On Mon, Jul 30, 2018 at 09:15:43AM +0200, Christoph Hellwig wrote:
> + apt.error = -EINVAL; /* same as no support for IOCB_CMD_POLL */
> + mask = vfs_poll(req->file, &apt.pt) & req->events;
> + if (mask || apt.error) {
> + bool removed = false;
> +
> + /* we did not manage to set up a waitqueue, done */
> + if (unlikely(!req->head))
> + goto out_fput;
> +out_fput:
> + fput(req->file);
> + return apt.error;
Ugh... So anything that simply returns a constant value, without
even bothering to do poll_wait() (on the theory that no matter how
much you wait, nothing will change) is going to git -EINVAL?
What am I missing here?
next prev parent reply other threads:[~2018-08-02 1:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 7:15 aio poll and a new in-kernel poll API V21 (aka 2.0) Christoph Hellwig
2018-07-30 7:15 ` [PATCH 1/4] timerfd: add support for keyed wakeups Christoph Hellwig
2018-07-30 7:15 ` [PATCH 2/4] aio: add a iocb refcount Christoph Hellwig
2018-08-01 23:19 ` Al Viro
2018-08-02 8:59 ` Christoph Hellwig
2018-07-30 7:15 ` [PATCH 3/4] aio: implement IOCB_CMD_POLL Christoph Hellwig
2018-08-01 23:54 ` Al Viro [this message]
2018-08-02 9:00 ` Christoph Hellwig
2018-08-02 0:21 ` Al Viro
2018-08-02 9:22 ` Christoph Hellwig
2018-08-02 16:00 ` Al Viro
2018-08-02 16:08 ` Christoph Hellwig
2018-08-02 16:08 ` Al Viro
2018-08-02 16:16 ` Christoph Hellwig
2018-08-02 21:48 ` Al Viro
2018-07-30 7:15 ` [PATCH 4/4] aio: allow direct aio poll comletions for keyed wakeups Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2018-08-06 8:30 aio poll V22 (aka 2.0) Christoph Hellwig
2018-08-06 8:30 ` [PATCH 3/4] aio: implement IOCB_CMD_POLL Christoph Hellwig
2018-07-26 8:28 aio poll and a new in-kernel poll API V20 (aka 2.0) Christoph Hellwig
2018-07-26 8:29 ` [PATCH 3/4] aio: implement IOCB_CMD_POLL Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180801235412.GT30522@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=avi@scylladb.com \
--cc=hch@lst.de \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.