From: "Michael S. Tsirkin" <mst@redhat.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: David Miller <davem@davemloft.net>,
caleb.raitto@gmail.com, Jason Wang <jasowang@redhat.com>,
Network Development <netdev@vger.kernel.org>,
Caleb Raitto <caraitto@google.com>
Subject: Re: [PATCH net-next] virtio_net: force_napi_tx module param.
Date: Thu, 2 Aug 2018 01:48:42 +0300 [thread overview]
Message-ID: <20180802014755-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAF=yD-+Wvy_93h2=OV=hkrj7SRoR_NMpOyc8qMStUy74+6-t+Q@mail.gmail.com>
On Wed, Aug 01, 2018 at 06:43:53PM -0400, Willem de Bruijn wrote:
> > > So e.g. we could set an affinity hint to a group of CPUs that
> > > > might transmit to this queue.
> > >
> > > We also want to set the xps mask for all cpus in the group to this queue.
> > >
> > > Is there a benefit over explicitly choosing one cpu from the set, btw?
> >
> > If only one CPU actually transmits on this queue then probably yes.
> > And virtio doesn't know whether that's the case.
>
> Oh, yes, good example.
>
> To plumb that through, vp_set_vq_affinity would have to take a cpu
> mask like irq_set_affinity_hint, instead of a single value.
>
> Though I don't suggest doing that as part of the core
> virtnet_set_affinity changes.
Why not? It seems a reasonable thing to do.
--
MST
next prev parent reply other threads:[~2018-08-02 0:36 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 23:11 [PATCH net-next] virtio_net: force_napi_tx module param Caleb Raitto
2018-07-24 0:53 ` Stephen Hemminger
2018-07-24 1:23 ` Willem de Bruijn
2018-07-24 10:42 ` Michael S. Tsirkin
2018-07-24 14:01 ` Willem de Bruijn
2018-07-24 18:38 ` Michael S. Tsirkin
2018-07-24 20:52 ` Willem de Bruijn
2018-07-24 22:23 ` Michael S. Tsirkin
2018-07-24 22:31 ` Willem de Bruijn
2018-07-24 22:46 ` Michael S. Tsirkin
2018-07-25 0:02 ` Willem de Bruijn
2018-07-25 0:17 ` Jon Olson
2018-07-30 6:06 ` Jason Wang
2018-08-01 22:27 ` Michael S. Tsirkin
2018-08-28 19:57 ` Willem de Bruijn
2018-08-29 7:56 ` Jason Wang
2018-08-29 13:01 ` Willem de Bruijn
2018-09-09 23:07 ` Willem de Bruijn
2018-09-10 5:59 ` Jason Wang
2018-07-29 16:00 ` David Miller
2018-07-29 20:33 ` Michael S. Tsirkin
2018-07-29 20:36 ` David Miller
2018-07-29 21:09 ` Willem de Bruijn
2018-07-29 21:32 ` Willem de Bruijn
2018-07-31 12:34 ` Michael S. Tsirkin
2018-08-01 15:46 ` Willem de Bruijn
2018-08-01 15:56 ` Willem de Bruijn
2018-08-01 22:25 ` Michael S. Tsirkin
2018-08-01 22:43 ` Willem de Bruijn
2018-08-01 22:48 ` Michael S. Tsirkin [this message]
2018-08-01 23:33 ` Willem de Bruijn
2018-07-30 19:51 ` Stephen Hemminger
2018-07-31 1:41 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180802014755-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=caleb.raitto@gmail.com \
--cc=caraitto@google.com \
--cc=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.