From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:47234 "EHLO
        ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725765AbeHBEyT (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Thu, 2 Aug 2018 00:54:19 -0400
Date: Thu, 2 Aug 2018 04:05:22 +0100
From: Al Viro <viro@ZenIV.linux.org.uk>
To: zhong jiang <zhongjiang@huawei.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/binfmt_elf_fdpic: remove redundant condition check in
 writenote
Message-ID: <20180802030522.GX30522@ZenIV.linux.org.uk>
References: <1533175474-17785-1-git-send-email-zhongjiang@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1533175474-17785-1-git-send-email-zhongjiang@huawei.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Thu, Aug 02, 2018 at 10:04:34AM +0800, zhong jiang wrote:
> It is unncessary to use double test for a expression. so just
> remove one of them.

... except when something in that expression might have side effects,
that is.