All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jheng-Jhong Wu <goodwater.wu@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: mt29f_spinand: fix memory leak while programming pages
Date: Thu, 2 Aug 2018 10:02:58 +0200	[thread overview]
Message-ID: <20180802080258.GA13222@kroah.com> (raw)
In-Reply-To: <1533196290-9669-1-git-send-email-goodwater.wu@gmail.com>

On Thu, Aug 02, 2018 at 03:51:30PM +0800, Jheng-Jhong Wu wrote:
> In spinand_program_page(), it uses devm_kzalloc() to allocate memory to
> wbuf dynamically if internal ECC is on, but it doesn't free memory
> allocated to wbuf at the end of this function. Before the spinand device
> is removed and frees memory automatically, programming pages may run many
> times. This leads to a memory leak issue when internal ECC is on.

How is this a memory leak?  The memory will be freed when the struct
device is removed from the system.  How did you test that there was a
leak?

> Changelog:
> 
> v2:
> - use kzalloc()/kfree() to replace devm_kzalloc()/devm_kfree()
> - add some descriptions to commit message

this changelog goes below the --- line.

thanks,

greg k-h

  reply	other threads:[~2018-08-02  8:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-01  9:44 [PATCH] staging: mt29f_spinand: fix memory leak while programming pages Jheng-Jhong Wu
2018-08-01 11:45 ` Dan Carpenter
     [not found]   ` <CALtPoQCyoe5V0m5=3K1XeZm41aDCaJ0rmYU-a=qkm=Yb8jgMxg@mail.gmail.com>
2018-08-02  3:42     ` Jheng-Jhong Wu
2018-08-02  6:12       ` Dan Carpenter
2018-08-02  7:51 ` [PATCH v2] " Jheng-Jhong Wu
2018-08-02  8:02   ` Greg Kroah-Hartman [this message]
2018-08-02  8:31     ` Jheng-Jhong Wu
2018-08-02  8:41       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180802080258.GA13222@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=goodwater.wu@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.