From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Todd Poynor <toddpoynor@gmail.com>
Cc: Rob Springer <rspringer@google.com>,
John Joseph <jnjoseph@google.com>,
Ben Chan <benchan@chromium.org>,
devel@driverdev.osuosl.org, Todd Poynor <toddpoynor@google.com>,
Dmitry Torokhov <dtor@chromium.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/8] Revert "staging: gasket: core: hold reference to pci_dev while used"
Date: Thu, 2 Aug 2018 11:00:08 +0200 [thread overview]
Message-ID: <20180802090008.GE23992@kroah.com> (raw)
In-Reply-To: <20180802084245.239689-9-toddpoynor@gmail.com>
On Thu, Aug 02, 2018 at 01:42:45AM -0700, Todd Poynor wrote:
> From: Todd Poynor <toddpoynor@google.com>
>
> There's no need to take an additional reference on the pci_dev structure
> for the pointer copy saved in gasket data structures.
>
> This reverts commit 8dd8a48b9a7dae5493494a8603adddfdf1914716.
Hint, when dealing with sha1 numbers in the kernel, we like the
following format to make it a bit easier to understand:
8dd8a48b9a7d ("staging: gasket: core: hold reference to pci_dev while used")
which can be generated by doing:
git show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n"
Can you fix this up and resend?
thanks,
greg k-h
prev parent reply other threads:[~2018-08-02 9:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 8:42 [PATCH 0/8] staging: gasket: cleanups du jour Todd Poynor
2018-08-02 8:42 ` [PATCH 1/8] staging: gasket: apex: enable power save mode by default Todd Poynor
2018-08-02 8:42 ` [PATCH 2/8] staging: gasket: core: print driver version code at registration time Todd Poynor
2018-08-02 8:57 ` Greg Kroah-Hartman
2018-08-02 8:42 ` [PATCH 3/8] staging: gasket: core: move driver loaded log after error cases Todd Poynor
2018-08-02 8:57 ` Greg Kroah-Hartman
2018-08-02 8:42 ` [PATCH 4/8] staging: gasket: core: device register debug log cleanups Todd Poynor
2018-08-02 8:57 ` Greg Kroah-Hartman
2018-08-02 8:42 ` [PATCH 5/8] staging: gasket: core: add subsystem and device info to error logs Todd Poynor
2018-08-02 8:58 ` Greg Kroah-Hartman
2018-08-02 8:42 ` [PATCH 6/8] staging: gasket: remove "reset type" param from framework Todd Poynor
2018-08-02 8:42 ` [PATCH 7/8] staging: gasket: apex: drop reset type param Todd Poynor
2018-08-02 8:42 ` [PATCH 8/8] Revert "staging: gasket: core: hold reference to pci_dev while used" Todd Poynor
2018-08-02 9:00 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180802090008.GE23992@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=benchan@chromium.org \
--cc=devel@driverdev.osuosl.org \
--cc=dtor@chromium.org \
--cc=jnjoseph@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rspringer@google.com \
--cc=toddpoynor@gmail.com \
--cc=toddpoynor@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.