From: Hendrik Brueckner <brueckner@linux.ibm.com>
To: linux-s390@vger.kernel.org
Subject: Re: [PATCH 1/5] zfcpdump: Remove unused macros
Date: Thu, 02 Aug 2018 09:55:55 +0000 [thread overview]
Message-ID: <20180802095555.GA5361@linux.ibm.com> (raw)
In-Reply-To: <244d868b-4754-3e51-f98e-2ccf633bb729@redhat.com>
On Wed, Jul 25, 2018 at 01:36:11PM +0200, Philipp Rudo wrote:
> There are no more users for these macros. Remove them.
>
> Signed-off-by: Philipp Rudo <prudo@linux.ibm.com>
> ---
> zipl/include/zipl.h | 2 --
> zipl/src/Makefile | 2 --
> 2 files changed, 4 deletions(-)
>
> diff --git a/zipl/include/zipl.h b/zipl/include/zipl.h
> index 2aed54fb..7670a0f9 100644
> --- a/zipl/include/zipl.h
> +++ b/zipl/include/zipl.h
> @@ -48,8 +48,6 @@
> #define MENU_DEFAULT_PROMPT 0
> #define MENU_DEFAULT_TIMEOUT 0
>
> -#define FSDUMP_IMAGE STRINGIFY(ZFCPDUMP_DIR) "/" STRINGIFY(ZFCPDUMP_FS_IMAGE)
> -#define FSDUMP_RAMDISK STRINGIFY(ZFCPDUMP_DIR) "/" STRINGIFY(ZFCPDUMP_FS_RD)
> #define FSDUMP_PART_IMAGE STRINGIFY(ZFCPDUMP_DIR) "/" \
> STRINGIFY(ZFCPDUMP_PART_IMAGE)
> #define FSDUMP_PART_RAMDISK STRINGIFY(ZFCPDUMP_DIR) "/" \
> diff --git a/zipl/src/Makefile b/zipl/src/Makefile
> index 1634c0d5..f8c36dc2 100644
> --- a/zipl/src/Makefile
> +++ b/zipl/src/Makefile
> @@ -3,8 +3,6 @@ include ../../common.mak
>
> ALL_CPPFLAGS += -I../include -I../boot \
> -DZFCPDUMP_DIR=$(ZFCPDUMP_DIR) \
> - -DZFCPDUMP_FS_IMAGE=$(ZFCPDUMP_FS_IMAGE) \
> - -DZFCPDUMP_FS_RD=$(ZFCPDUMP_FS_RD) \
> -DZFCPDUMP_PART_IMAGE=$(ZFCPDUMP_PART_IMAGE) \
> -DZFCPDUMP_PART_RD=$(ZFCPDUMP_PART_RD) \
> -D_FILE_OFFSET_BITS=64 $(NO_PIE_CFLAGS)
Reviewed-by: Hendrik Brueckner <brueckner@linux.ibm.com>
next parent reply other threads:[~2018-08-02 9:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <244d868b-4754-3e51-f98e-2ccf633bb729@redhat.com>
2018-08-02 9:55 ` Hendrik Brueckner [this message]
2018-07-25 11:36 [PATCH 1/5] zfcpdump: Remove unused macros Philipp Rudo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180802095555.GA5361@linux.ibm.com \
--to=brueckner@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.