From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v2 02/10] mfd: wcd9335: add support to wcd9335 core Date: Thu, 2 Aug 2018 10:57:41 +0100 Message-ID: <20180802095741.GP4662@dell> References: <20180727121806.18209-1-srinivas.kandagatla@linaro.org> <20180727121806.18209-3-srinivas.kandagatla@linaro.org> <20180802083351.GN4662@dell> <9a33e0ce-a385-cdad-f610-655562bec1f5@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by alsa0.perex.cz (Postfix) with ESMTP id 8FD4B2677C8 for ; Thu, 2 Aug 2018 11:57:44 +0200 (CEST) Received: by mail-wr1-f66.google.com with SMTP id h15-v6so1473863wrs.7 for ; Thu, 02 Aug 2018 02:57:44 -0700 (PDT) Content-Disposition: inline In-Reply-To: <9a33e0ce-a385-cdad-f610-655562bec1f5@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Srinivas Kandagatla Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, bgoswami@codeaurora.org, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, robh+dt@kernel.org, tiwai@suse.com, vkoul@kernel.org, broonie@kernel.org List-Id: alsa-devel@alsa-project.org T24gVGh1LCAwMiBBdWcgMjAxOCwgU3Jpbml2YXMgS2FuZGFnYXRsYSB3cm90ZToKPiBPbiAwMi8w OC8xOCAwOTozMywgTGVlIEpvbmVzIHdyb3RlOgo+ID4gT24gRnJpLCAyNyBKdWwgMjAxOCwgU3Jp bml2YXMgS2FuZGFnYXRsYSB3cm90ZToKPiA+IAo+ID4gPiBRdWFsY29tbSBXQ0Q5MzM1IENvZGVj IGlzIGEgc3RhbmRhbG9uZSBIaS1GaSBhdWRpbyBjb2RlYyBJQywKPiA+ID4gSXQgaGFzIG11bGl0 cGxlIGJsb2NrcyBsaWtlIFNvdW5kd2lyZSBjb250cm9sbGVyLCBjb2RlYywKPiA+ID4gQ29kZWMg cHJvY2Vzc2luZyBlbmdpbmUsIENsYXNzSCBjb250cm9sbGVyLCBpbnRlcnJ1cHQgbXV4Lgo+ID4g PiBJdCBzdXBwb3J0cyBib3RoIEkyUy9JMkMgYW5kIFNMSU1idXMgYXVkaW8gaW50ZXJmYWNlcy4K PiA+ID4gCj4gPiA+IFRoaXMgcGF0Y2ggYWRkcyBzdXBwb3J0IHRvIFNMSU1idXMgYXVkaW8gaW50 ZXJmYWNlLgo+ID4gPiAKPiA+ID4gU2lnbmVkLW9mZi1ieTogU3Jpbml2YXMgS2FuZGFnYXRsYSA8 c3Jpbml2YXMua2FuZGFnYXRsYUBsaW5hcm8ub3JnPgo+ID4gPiAtLS0KPiA+ID4gICBkcml2ZXJz L21mZC9LY29uZmlnICAgICAgICAgICAgICAgICAgIHwgIDE4ICsrCj4gPiA+ICAgZHJpdmVycy9t ZmQvTWFrZWZpbGUgICAgICAgICAgICAgICAgICB8ICAgNCArCj4gPiA+ICAgZHJpdmVycy9tZmQv d2NkOTMzNS1jb3JlLmMgICAgICAgICAgICB8IDI2OCArKysrKysrKysrKysrKysrCj4gPiA+ICAg aW5jbHVkZS9saW51eC9tZmQvd2NkOTMzNS9yZWdpc3RlcnMuaCB8IDU4MCArKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrCj4gPiA+ICAgaW5jbHVkZS9saW51eC9tZmQvd2NkOTMzNS93 Y2Q5MzM1LmggICB8ICA0MiArKysKPiA+ID4gICA1IGZpbGVzIGNoYW5nZWQsIDkxMiBpbnNlcnRp b25zKCspCj4gPiA+ICAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvbWZkL3djZDkzMzUtY29y ZS5jCj4gPiA+ICAgY3JlYXRlIG1vZGUgMTAwNjQ0IGluY2x1ZGUvbGludXgvbWZkL3djZDkzMzUv cmVnaXN0ZXJzLmgKPiA+ID4gICBjcmVhdGUgbW9kZSAxMDA2NDQgaW5jbHVkZS9saW51eC9tZmQv d2NkOTMzNS93Y2Q5MzM1LmgKPiA+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21mZC9L Y29uZmlnIGIvZHJpdmVycy9tZmQvS2NvbmZpZwo+ID4gPiBpbmRleCBmM2ZhNTE2MDExZWMuLjZl NWI1ZjNjZmUyMCAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9tZmQvS2NvbmZpZwo+ID4gPiAr KysgYi9kcml2ZXJzL21mZC9LY29uZmlnCj4gPiA+IEBAIC0xODA3LDYgKzE4MDcsMjQgQEAgY29u ZmlnIE1GRF9XTTk3eHgKPiA+ID4gICAJICBzdXBwb3J0IGZvciB0aGUgV005N3h4LCBpbiBvcmRl ciB0byB1c2UgdGhlIGFjdHVhbCBmdW5jdGlvbmFsdGl5IG9mCj4gPiA+ICAgCSAgdGhlIGRldmlj ZSBvdGhlciBkcml2ZXJzIG11c3QgYmUgZW5hYmxlZC4KPiA+ID4gK2NvbmZpZyBNRkRfV0NEOTMz NQo+ID4gPiArCXRyaXN0YXRlCj4gPiA+ICsJc2VsZWN0IE1GRF9DT1JFCj4gPiA+ICsJc2VsZWN0 IFJFR01BUAo+ID4gPiArCXNlbGVjdCBSRUdNQVBfSVJRCj4gPiA+ICsKPiA+ID4gK2NvbmZpZyBN RkRfV0NEOTMzNV9TTElNCj4gPiA+ICsJdHJpc3RhdGUgIlF1YWxjb21tIFdDRDkzMzUgd2l0aCBT TElNYnVzIgo+ID4gPiArCXNlbGVjdCBNRkRfV0NEOTMzNQo+ID4gPiArCXNlbGVjdCBSRUdNQVBf U0xJTUJVUwo+ID4gPiArCWRlcGVuZHMgb24gU0xJTUJVUwo+ID4gPiArCWhlbHAKPiA+ID4gKwlU aGUgV0NEOTMzNSBpcyBhIHN0YW5kYWxvbmUgSGktRmkgYXVkaW8gY29kZWMgSUMsIHN1cHBvcnRz Cj4gPiAKPiA+IHMvY29kZWMvQ09ERUMvCj4gWWVwLgoKSWYgeW91IGFncmVlIHdpdGggc29tZXRo aW5nLCBiZXN0IGp1c3QgdG8gc25pcCBpdC4KCk5vIG5lZWQgdG8gcmVwbHkgYXQgYWxsIGlmIHlv dSBhZ3JlZSB3aXRoIGV2ZXJ5dGhpbmcuCgpbLi4uXQoKPiA+ID4gK3N0YXRpYyBpbnQgd2NkOTMz NV9wb3dlcl9vbl9yZXNldChzdHJ1Y3Qgd2NkOTMzNSAqd2NkKQo+ID4gPiArewo+ID4gPiArCXN0 cnVjdCBkZXZpY2UgKmRldiA9IHdjZC0+ZGV2Owo+ID4gPiArCWludCByZXQ7Cj4gPiA+ICsKPiA+ ID4gKwlyZXQgPSByZWd1bGF0b3JfYnVsa19lbmFibGUoV0NEOTMzNV9NQVhfU1VQUExZLCB3Y2Qt PnN1cHBsaWVzKTsKPiA+ID4gKwlpZiAocmV0ICE9IDApIHsKPiA+ID4gKwkJZGV2X2VycihkZXYs ICJGYWlsZWQgdG8gZ2V0IHN1cHBsaWVzOiBlcnIgPSAlZFxuIiwgcmV0KTsKPiA+ID4gKwkJcmV0 dXJuIHJldDsKPiA+ID4gKwl9Cj4gPiA+ICsKPiA+ID4gKwkvKgo+ID4gPiArCSAqIEZvciBXQ0Q5 MzM1LCBpdCB0YWtlcyBhYm91dCA2MDB1cyBmb3IgdGhlIFZvdXRfQSBhbmQKPiA+ID4gKwkgKiBW b3V0X0QgdG8gYmUgcmVhZHkgYWZ0ZXIgQlVDS19TSURPIGlzIHBvd2VyZWQgdXAuCj4gPiA+ICsJ ICogU1lTX1JTVF9OIHNob3VsZG4ndCBiZSBwdWxsZWQgaGlnaCBkdXJpbmcgdGhpcyB0aW1lCj4g PiA+ICsJICovCj4gPiA+ICsJdXNsZWVwX3JhbmdlKDYwMCwgNjUwKTsKPiA+ID4gKwo+ID4gPiAr CWdwaW9fZGlyZWN0aW9uX291dHB1dCh3Y2QtPnJlc2V0X2dwaW8sIDApOwo+ID4gPiArCW1zbGVl cCgyMCk7Cj4gPiAKPiA+IFdoYXQncyB0aGlzIGZvcj8gIFdoeSBjYW4ndCB5b3UganVzdDoKPiA+ IAo+IFRoaXMgaXMganVzdCBtYWtpbmcgc3VyZSB0aGF0IHJlc2V0IGxpbmUgaXMgbG93IGJlZm9y ZSBhY3R1YWwgdGhlIGNoaXAgaXMKPiB0YWtlbiBvdXQgb2YgcmVzZXQuCgpJZiBpdCBjb25mdXNl ZCBtZSwgaXQgbWlnaHQgY29uZnVzZSBvdGhlcnMuCgpCZXN0IHRvIGFkZCBhIGNvbW1lbnQgdG8g dGhlIHR1bmUgb2Y6CgogICJUb2dnbGUgcmVzZXQgbGluZSBvZmYvb24gdG8gZW5zdXJlIC4uLiAi Cgo+ID4gICAgZ3Bpb19kaXJlY3Rpb25fb3V0cHV0KHdjZC0+cmVzZXRfZ3BpbywgMSk7Cj4gPiAK PiA+IC4uLiBhbmQgZHJvcCB0aGUgbmV4dCAyIGxpbmVzPwoKWy4uLl0KCj4gPiA+ICtzdGF0aWMg Y29uc3Qgc3RydWN0IG1mZF9jZWxsIHdjZDkzMzVfZGV2aWNlc1tdID0gewo+ID4gPiArCXsKPiA+ ID4gKwkJLm5hbWUgPSAid2NkOTMzNS1jb2RlYyIsCj4gPiA+ICsJfSwKPiA+ID4gK307Cj4gPiAK PiA+IFdoZW4gYXJlIHlvdSBnb2luZyB0byBhZGQgdGhlIG90aGVyIGRldmljZXM/Cj4gPiAKPiBX ZSBhcmUgdHJ5aW5nIHRvIHNvcnQgb2YgaHcgc2V0dXAgdG8gdGVzdCBvdGhlciBkZXZpY2VzIGxp a2Ugc291bmR3aXJlCj4gY29udHJvbGxlciwgd2lsbCBhZGQgdGhlc2Ugb25jZSB3ZSBhcmUgaW4g YSBwb3NpdGlvbiB0byB0ZXN0IHRoZW0uCgpFbnN1cmUgdGhhdCB5b3UgZG8sIG9yIEknbGwgcmV2 ZXJ0IHRoZSB3aG9sZSBkcml2ZXIgYXMgIm5vdCBhbiBNRkQiIDopCgo+ID4gQnkgdGhlIHdheSwg b25lIGxpbmUgZW50cmllcyBzaG91bGQgYmUgcGxhY2VkIG9uIG9uZSBsaW5lLgo+ID4gCj4gPiA+ ICsJeyAubmFtZSA9ICJ3Y2Q5MzM1LWNvZGVjIiB9LAoKWy4uLl0KCj4gPiA+ICtzdGF0aWMgaW50 IHdjZDkzMzVfc2xpbV9zdGF0dXMoc3RydWN0IHNsaW1fZGV2aWNlICpzZGV2LAo+ID4gPiArCQkJ CSBlbnVtIHNsaW1fZGV2aWNlX3N0YXR1cyBzKQo+ID4gCj4gPiAncycgaXMgbm90IGEgZ29vZCB2 YXJpYWJsZSBuYW1lLiAgU3VnZ2VzdCAnc3RhdHVzJy4KPiA+IAo+IEFncmVlZCEKPiA+ID4gK3sK PiA+ID4gKwlzdHJ1Y3QgZGV2aWNlX25vZGUgKmlmZF9ucDsKPiA+IAo+ID4gV2hhdCdzICdpZmQn Pwo+ID4gCj4gU0xJTWJ1cyBJbnRlcmZhY2UgZGV2aWNlLgoKVGhhdCdzIGEgdGVycmlibGUgdmFy aWFibGUgbmFtZS4gOikKCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10KTGluYXJvIFNlcnZpY2Vz IFRlY2huaWNhbCBMZWFkCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBB Uk0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkFsc2EtZGV2ZWwgbWFpbGlu ZyBsaXN0CkFsc2EtZGV2ZWxAYWxzYS1wcm9qZWN0Lm9yZwpodHRwOi8vbWFpbG1hbi5hbHNhLXBy b2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8vYWxzYS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBE5FC43142 for ; Thu, 2 Aug 2018 09:57:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 73B13214FB for ; Thu, 2 Aug 2018 09:57:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="JhvAokP1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 73B13214FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732049AbeHBLsL (ORCPT ); Thu, 2 Aug 2018 07:48:11 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:42017 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730431AbeHBLsK (ORCPT ); Thu, 2 Aug 2018 07:48:10 -0400 Received: by mail-wr1-f68.google.com with SMTP id e7-v6so1464392wrs.9 for ; Thu, 02 Aug 2018 02:57:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=tebFwpcT0fXv0Wndqx54cj5GZH3DroiuVfifBPq9OM0=; b=JhvAokP1lzYvNDNHp6/nNDsNdKrqwm2o4jFQASag/w25Nju2LQ/jQTk4lp9AmQqc/1 mNvkbjR2KhtX2EAGkDX5f6yfTZdQZnvznPAroyn7lnOHtrzEFKhh37wmq+9AJT76VXl7 /1z7uTpDJa2Cam25kL5URYTexmJV7tncTLQkk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=tebFwpcT0fXv0Wndqx54cj5GZH3DroiuVfifBPq9OM0=; b=l9KTtezZ9I2ksWVJd/yxGACBBHVJb//JygE9MRG+quXm4jvtUVXgtAIHtBRgzOvrGO 6ZrmYS+7iRksvRjiEjyDOj8UKdh/UFDKF4YEOSmyx5mwY6ArY6ppdA0mSnXZuHJ8sgP+ kvK3vUxGDfm2o39R7A3bAnZ3pfm336x+i8W6uDbH6p43i6dtQgFQwz4z4l142Zlgfwbh Se3PxSTiztixj/fFcK5N/Ls6w1Ig+o4SgNAd5p7jNvNcTGjmnH4VU5b4N+DjvGXeKf6S Yba5JrT3BdhYO7DM7nBAb6wds/nHUseuYMI8QgIjS04uL1DQfbWMC0pQx/4hGJnHtCvE x7RQ== X-Gm-Message-State: AOUpUlGewxf7sMuQ9/WaNke6Aeh3ctwV0sZosqkqNiiPy1YJsU9MVbEr ZK9MusRr2PNTxg38DzH5Ux3JMw== X-Google-Smtp-Source: AAOMgpcO1go3fvBTyA3ggP2JeSi8KHLVyb14XEo54R4EtaIVUvmLwze78soI3L8dSbkSMIk1sSju8A== X-Received: by 2002:a5d:4b90:: with SMTP id b16-v6mr1362010wrt.168.1533203864038; Thu, 02 Aug 2018 02:57:44 -0700 (PDT) Received: from dell ([95.149.160.4]) by smtp.gmail.com with ESMTPSA id d14-v6sm1062543wrr.12.2018.08.02.02.57.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Aug 2018 02:57:43 -0700 (PDT) Date: Thu, 2 Aug 2018 10:57:41 +0100 From: Lee Jones To: Srinivas Kandagatla Cc: robh+dt@kernel.org, broonie@kernel.org, mark.rutland@arm.com, lgirdwood@gmail.com, tiwai@suse.com, bgoswami@codeaurora.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, vkoul@kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH v2 02/10] mfd: wcd9335: add support to wcd9335 core Message-ID: <20180802095741.GP4662@dell> References: <20180727121806.18209-1-srinivas.kandagatla@linaro.org> <20180727121806.18209-3-srinivas.kandagatla@linaro.org> <20180802083351.GN4662@dell> <9a33e0ce-a385-cdad-f610-655562bec1f5@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9a33e0ce-a385-cdad-f610-655562bec1f5@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 02 Aug 2018, Srinivas Kandagatla wrote: > On 02/08/18 09:33, Lee Jones wrote: > > On Fri, 27 Jul 2018, Srinivas Kandagatla wrote: > > > > > Qualcomm WCD9335 Codec is a standalone Hi-Fi audio codec IC, > > > It has mulitple blocks like Soundwire controller, codec, > > > Codec processing engine, ClassH controller, interrupt mux. > > > It supports both I2S/I2C and SLIMbus audio interfaces. > > > > > > This patch adds support to SLIMbus audio interface. > > > > > > Signed-off-by: Srinivas Kandagatla > > > --- > > > drivers/mfd/Kconfig | 18 ++ > > > drivers/mfd/Makefile | 4 + > > > drivers/mfd/wcd9335-core.c | 268 ++++++++++++++++ > > > include/linux/mfd/wcd9335/registers.h | 580 ++++++++++++++++++++++++++++++++++ > > > include/linux/mfd/wcd9335/wcd9335.h | 42 +++ > > > 5 files changed, 912 insertions(+) > > > create mode 100644 drivers/mfd/wcd9335-core.c > > > create mode 100644 include/linux/mfd/wcd9335/registers.h > > > create mode 100644 include/linux/mfd/wcd9335/wcd9335.h > > > > > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > > > index f3fa516011ec..6e5b5f3cfe20 100644 > > > --- a/drivers/mfd/Kconfig > > > +++ b/drivers/mfd/Kconfig > > > @@ -1807,6 +1807,24 @@ config MFD_WM97xx > > > support for the WM97xx, in order to use the actual functionaltiy of > > > the device other drivers must be enabled. > > > +config MFD_WCD9335 > > > + tristate > > > + select MFD_CORE > > > + select REGMAP > > > + select REGMAP_IRQ > > > + > > > +config MFD_WCD9335_SLIM > > > + tristate "Qualcomm WCD9335 with SLIMbus" > > > + select MFD_WCD9335 > > > + select REGMAP_SLIMBUS > > > + depends on SLIMBUS > > > + help > > > + The WCD9335 is a standalone Hi-Fi audio codec IC, supports > > > > s/codec/CODEC/ > Yep. If you agree with something, best just to snip it. No need to reply at all if you agree with everything. [...] > > > +static int wcd9335_power_on_reset(struct wcd9335 *wcd) > > > +{ > > > + struct device *dev = wcd->dev; > > > + int ret; > > > + > > > + ret = regulator_bulk_enable(WCD9335_MAX_SUPPLY, wcd->supplies); > > > + if (ret != 0) { > > > + dev_err(dev, "Failed to get supplies: err = %d\n", ret); > > > + return ret; > > > + } > > > + > > > + /* > > > + * For WCD9335, it takes about 600us for the Vout_A and > > > + * Vout_D to be ready after BUCK_SIDO is powered up. > > > + * SYS_RST_N shouldn't be pulled high during this time > > > + */ > > > + usleep_range(600, 650); > > > + > > > + gpio_direction_output(wcd->reset_gpio, 0); > > > + msleep(20); > > > > What's this for? Why can't you just: > > > This is just making sure that reset line is low before actual the chip is > taken out of reset. If it confused me, it might confuse others. Best to add a comment to the tune of: "Toggle reset line off/on to ensure ... " > > gpio_direction_output(wcd->reset_gpio, 1); > > > > ... and drop the next 2 lines? [...] > > > +static const struct mfd_cell wcd9335_devices[] = { > > > + { > > > + .name = "wcd9335-codec", > > > + }, > > > +}; > > > > When are you going to add the other devices? > > > We are trying to sort of hw setup to test other devices like soundwire > controller, will add these once we are in a position to test them. Ensure that you do, or I'll revert the whole driver as "not an MFD" :) > > By the way, one line entries should be placed on one line. > > > > > + { .name = "wcd9335-codec" }, [...] > > > +static int wcd9335_slim_status(struct slim_device *sdev, > > > + enum slim_device_status s) > > > > 's' is not a good variable name. Suggest 'status'. > > > Agreed! > > > +{ > > > + struct device_node *ifd_np; > > > > What's 'ifd'? > > > SLIMbus Interface device. That's a terrible variable name. :) -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog