From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Pau =?utf-8?B?TW9ubsOp?= Subject: Re: [PATCH v4 18/32] libxl_qmp: Separate QMP message generation from qmp_send_prepare Date: Thu, 2 Aug 2018 12:34:31 +0200 Message-ID: <20180802103431.vezxedjutdsw2kmz@mac> References: <20180727140614.13256-1-anthony.perard@citrix.com> <20180727140614.13256-19-anthony.perard@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1flAwM-0008T3-8G for xen-devel@lists.xenproject.org; Thu, 02 Aug 2018 10:34:42 +0000 Content-Disposition: inline In-Reply-To: <20180727140614.13256-19-anthony.perard@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Anthony PERARD Cc: xen-devel@lists.xenproject.org, Ian Jackson , Wei Liu List-Id: xen-devel@lists.xenproject.org T24gRnJpLCBKdWwgMjcsIDIwMTggYXQgMDM6MDY6MDBQTSArMDEwMCwgQW50aG9ueSBQRVJBUkQg d3JvdGU6Cj4gVG8gYmUgYWJsZSB0byByZS11c2UgcW1wX3ByZXBhcmVfcW1wX2NtZCB3aXRoIGxp YnhsX19ldl9xbXAuCj4gCj4gQWxzbywgYWRkIHRoZSBRTVAgZW5kIG9mIGNvbW1hbmQgJ1xyXG4n IGludG8gdGhlIGdlbmVyYXRlZCBzdHJpbmcuCj4gCj4gU2lnbmVkLW9mZi1ieTogQW50aG9ueSBQ RVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJpeC5jb20+Cj4gLS0tCj4gIHRvb2xzL2xpYnhsL2xp YnhsX3FtcC5jIHwgNjIgKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0K PiAgMSBmaWxlIGNoYW5nZWQsIDQ0IGluc2VydGlvbnMoKyksIDE4IGRlbGV0aW9ucygtKQo+IAo+ IGRpZmYgLS1naXQgYS90b29scy9saWJ4bC9saWJ4bF9xbXAuYyBiL3Rvb2xzL2xpYnhsL2xpYnhs X3FtcC5jCj4gaW5kZXggNjY1YjZmNWQwNS4uMzhhNDM5NTI2NiAxMDA2NDQKPiAtLS0gYS90b29s cy9saWJ4bC9saWJ4bF9xbXAuYwo+ICsrKyBiL3Rvb2xzL2xpYnhsL2xpYnhsX3FtcC5jCj4gQEAg LTU3OCwxNyArNTc4LDE3IEBAIHN0YXRpYyBpbnQgcW1wX25leHQobGlieGxfX2djICpnYywgbGli eGxfX3FtcF9oYW5kbGVyICpxbXApCj4gICAgICByZXR1cm4gcmM7Cj4gIH0KPiAgCj4gLXN0YXRp YyBjaGFyICpxbXBfc2VuZF9wcmVwYXJlKGxpYnhsX19nYyAqZ2MsIGxpYnhsX19xbXBfaGFuZGxl ciAqcW1wLAo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBjaGFyICpjbWQs IGxpYnhsX19qc29uX29iamVjdCAqYXJncywKPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgcW1wX2NhbGxiYWNrX3QgY2FsbGJhY2ssIHZvaWQgKm9wYXF1ZSwKPiAtICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgcW1wX3JlcXVlc3RfY29udGV4dCAqY29udGV4dCkKPiAtewo+IC0g ICAgY29uc3QgdW5zaWduZWQgY2hhciAqYnVmID0gTlVMTDsKPiAtICAgIGNoYXIgKnJldCA9IE5V TEw7Cj4gLSAgICBsaWJ4bF95YWpsX2xlbmd0aCBsZW4gPSAwOwo+ICtzdGF0aWMgY2hhciAqcW1w X3ByZXBhcmVfcW1wX2NtZChsaWJ4bF9fZ2MgKmdjLAoKSXMgaXQgcmVhbGx5IG5lZWRlZCB0byBo YXZlIHFtcCB0d2ljZSBpbiB0aGUgZnVuY3Rpb24gbmFtZT8KcW1wX3ByZXBhcmVfY21kIExHVE0u Cgo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBjaGFyICpjbWQsCj4g KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IGxpYnhsX19qc29uX29iamVj dCAqYXJncywKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW50IGlkLAo+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzaXplX3QgKmxlbl9yKQo+ICt7Cj4gKyAg ICBjb25zdCB1bnNpZ25lZCBjaGFyICpidWY7CgpXaGlsZSB0aGVyZSBJIHdvdWxkIGRyb3AgdGhl IHVuc2lnbmVkLi4uCgo+ICsgICAgbGlieGxfeWFqbF9sZW5ndGggbGVuOwo+ICAgICAgeWFqbF9n ZW5fc3RhdHVzIHM7Cj4gICAgICB5YWpsX2dlbiBoYW5kOwo+IC0gICAgY2FsbGJhY2tfaWRfcGFp ciAqZWxtID0gTlVMTDsKPiArICAgIGNoYXIgKnJldCA9IE5VTEw7Cj4gIAo+ICAgICAgaGFuZCA9 IGxpYnhsX3lhamxfZ2VuX2FsbG9jKE5VTEwpOwo+ICAKPiBAQCAtNjAwLDcgKzYwMCw3IEBAIHN0 YXRpYyBjaGFyICpxbXBfc2VuZF9wcmVwYXJlKGxpYnhsX19nYyAqZ2MsIGxpYnhsX19xbXBfaGFu ZGxlciAqcW1wLAo+ICAgICAgbGlieGxfX3lhamxfZ2VuX2FzY2lpeihoYW5kLCAiZXhlY3V0ZSIp Owo+ICAgICAgbGlieGxfX3lhamxfZ2VuX2FzY2lpeihoYW5kLCBjbWQpOwo+ICAgICAgbGlieGxf X3lhamxfZ2VuX2FzY2lpeihoYW5kLCAiaWQiKTsKPiAtICAgIHlhamxfZ2VuX2ludGVnZXIoaGFu ZCwgKytxbXAtPmxhc3RfaWRfdXNlZCk7Cj4gKyAgICB5YWpsX2dlbl9pbnRlZ2VyKGhhbmQsIGlk KTsKPiAgICAgIGlmIChhcmdzKSB7Cj4gICAgICAgICAgbGlieGxfX3lhamxfZ2VuX2FzY2lpeiho YW5kLCAiYXJndW1lbnRzIik7Cj4gICAgICAgICAgbGlieGxfX2pzb25fb2JqZWN0X3RvX3lhamxf Z2VuKGdjLCBoYW5kLCBhcmdzKTsKPiBAQCAtNjEwLDYgKzYxMCwzNiBAQCBzdGF0aWMgY2hhciAq cW1wX3NlbmRfcHJlcGFyZShsaWJ4bF9fZ2MgKmdjLCBsaWJ4bF9fcW1wX2hhbmRsZXIgKnFtcCwK PiAgICAgIHMgPSB5YWpsX2dlbl9nZXRfYnVmKGhhbmQsICZidWYsICZsZW4pOwo+ICAKPiAgICAg IGlmIChzKSB7Cj4gKyAgICAgICAgZ290byBvdXQ7Cj4gKyAgICB9Cj4gKwo+ICsgICAgcmV0ID0g bGlieGxfX21hbGxvYyhOT0dDLCBsZW4gKyAzKTsKPiArICAgIHN0cm5jcHkocmV0LCAoY29uc3Qg Y2hhciAqKWJ1ZiwgbGVuICsgMyk7CgouLi4gc28gdGhhdCB5b3UgY2FuIGRyb3AgdGhlIGNhc3Qg ZnJvbSBoZXJlLgoKPiArICAgIHN0cm5jcHkocmV0ICsgbGVuLCAiXHJcbiIsIDMpOwo+ICsgICAg bGVuICs9IDI7Cj4gKwo+ICsgICAgaWYgKGxlbl9yKQo+ICsgICAgICAgICpsZW5fciA9IGxlbjsK PiArCj4gK291dDoKPiArICAgIHlhamxfZ2VuX2ZyZWUoaGFuZCk7Cj4gKyAgICByZXR1cm4gcmV0 Owo+ICt9Cj4gKwo+ICtzdGF0aWMgY2hhciAqcW1wX3NlbmRfcHJlcGFyZShsaWJ4bF9fZ2MgKmdj LCBsaWJ4bF9fcW1wX2hhbmRsZXIgKnFtcCwKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgY29uc3QgY2hhciAqY21kLCBsaWJ4bF9fanNvbl9vYmplY3QgKmFyZ3MsCj4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHFtcF9jYWxsYmFja190IGNhbGxiYWNrLCB2b2lkICpvcGFx dWUsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHFtcF9yZXF1ZXN0X2NvbnRleHQg KmNvbnRleHQsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNpemVfdCAqbGVuX3Ip Cj4gK3sKPiArICAgIGNoYXIgKmJ1ZjsKPiArICAgIGNhbGxiYWNrX2lkX3BhaXIgKmVsbTsKPiAr Cj4gKyAgICBidWYgPSBxbXBfcHJlcGFyZV9xbXBfY21kKGdjLAo+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBjbWQsIGFyZ3MsICsrcW1wLT5sYXN0X2lkX3VzZWQsCj4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIE5VTEwpOwoKSW5kZW50YXRpb24gaXMgdmVyeSB3ZWlyZCBo ZXJlLiBBRkFJQ1QgaXQgY2FuIGZpdCBpbiBhIHNpbmdsZSBsaW5lPwoKVGhhbmtzLCBSb2dlci4K Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZl bCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlz dHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw=