From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH v2] net/mlx5: fix RSS flow configuration crash Date: Thu, 2 Aug 2018 13:18:33 +0200 Message-ID: <20180802111833.GL5211@6wind.com> References: <1533130807-9183-1-git-send-email-motih@mellanox.com> <1533199267-9658-1-git-send-email-motih@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: shahafs@mellanox.com, dev@dpdk.org, nelio.laranjeiro@6wind.com To: Moti Haimovsky Return-path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 1D3EC1B45B for ; Thu, 2 Aug 2018 13:18:51 +0200 (CEST) Received: by mail-wm0-f68.google.com with SMTP id y9-v6so2075707wma.5 for ; Thu, 02 Aug 2018 04:18:51 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1533199267-9658-1-git-send-email-motih@mellanox.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Aug 02, 2018 at 11:41:07AM +0300, Moti Haimovsky wrote: > This commit fixes a segmentation fault observed when configuring > mlx5 with RSS flow rule containing invalid queues indices such as > negative numbers, queue numbers bigger than the number Rx queues the > PMD or has no queues at all. > > Fixes: 592f05b29a25 ("net/mlx5: add RSS flow action") > Cc: nelio.laranjeiro@6wind.com > > Signed-off-by: Moti Haimovsky > --- > v2: > * Modifications according to review by Adrien Mazarguil. > in reply to 1533130807-9183-1-git-send-email-motih@mellanox.com Almost, there is one new occurrence with the same issue, see below. By the way, like for "types" and "level" fields, a zero value in "queue_num" could be interpreted as default in order to target all configured queues, for the convenience of applications that do not care. This is not explicitly documented so it's just a recommendation though. > v1: > * Added check for zero queues. > --- > drivers/net/mlx5/mlx5_flow.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index 6c3021a..5576044 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -2065,6 +2065,11 @@ struct mlx5_flow_tunnel_info { > RTE_FLOW_ERROR_TYPE_ACTION_CONF, > &rss->key_len, > "RSS hash key too large"); > + if (!rss->queue_num) > + return rte_flow_error_set(error, ENOTSUP, > + RTE_FLOW_ERROR_TYPE_ACTION_CONF, > + &rss->queue_num, Here ^^ > + "no queues were provided for RSS"); > if (rss->queue_num > priv->config.ind_table_max_size) > return rte_flow_error_set(error, ENOTSUP, > RTE_FLOW_ERROR_TYPE_ACTION_CONF, > @@ -2077,6 +2082,12 @@ struct mlx5_flow_tunnel_info { > "some RSS protocols are not" > " supported"); > for (i = 0; i != rss->queue_num; ++i) { > + if (rss->queue[i] >= priv->rxqs_n) > + return rte_flow_error_set > + (error, EINVAL, > + RTE_FLOW_ERROR_TYPE_ACTION_CONF, > + rss, > + "queue index out of range"); > if (!(*priv->rxqs)[rss->queue[i]]) > return rte_flow_error_set > (error, EINVAL, > -- > 1.8.3.1 > -- Adrien Mazarguil 6WIND