From: Stephen Hemminger <stephen@networkplumber.org>
To: Peter Oskolkov <posk@google.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Florian Westphal <fw@strlen.de>
Subject: Re: [PATCH net-next 1/3] ip: discard IPv4 datagrams with overlapping segments.
Date: Thu, 2 Aug 2018 15:54:46 -0700 [thread overview]
Message-ID: <20180802155446.604d1a9b@xeon-e3> (raw)
In-Reply-To: <20180802224600.43070-2-posk@google.com>
On Thu, 2 Aug 2018 22:45:58 +0000
Peter Oskolkov <posk@google.com> wrote:
> diff --git a/include/uapi/linux/snmp.h b/include/uapi/linux/snmp.h
> index e5ebc83827ab..da1a144f1a51 100644
> --- a/include/uapi/linux/snmp.h
> +++ b/include/uapi/linux/snmp.h
> @@ -40,6 +40,7 @@ enum
> IPSTATS_MIB_REASMREQDS, /* ReasmReqds */
> IPSTATS_MIB_REASMOKS, /* ReasmOKs */
> IPSTATS_MIB_REASMFAILS, /* ReasmFails */
> + IPSTATS_MIB_REASM_OVERLAPS, /* ReasmOverlaps */
> IPSTATS_MIB_FRAGOKS, /* FragOKs */
> IPSTATS_MIB_FRAGFAILS, /* FragFails */
> IPSTATS_MIB_FRAGCREATES, /* FragCreates */
Inserting new entries in the middle of an enum means the numeric
values will change. Isn't this going to break userspace ABI?
next prev parent reply other threads:[~2018-08-03 0:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 22:45 [PATCH net-next 0/3] ip: Use rb trees for IP frag queue Peter Oskolkov
2018-08-02 22:45 ` [PATCH net-next 1/3] ip: discard IPv4 datagrams with overlapping segments Peter Oskolkov
2018-08-02 22:54 ` Stephen Hemminger [this message]
2018-08-02 23:33 ` Eric Dumazet
2018-08-02 23:56 ` Stephen Hemminger
2018-08-02 22:45 ` [PATCH net-next 2/3] net: modify skb_rbtree_purge to return the truesize of all purged skbs Peter Oskolkov
2018-08-02 22:46 ` [PATCH net-next 3/3] ip: use rb trees for IP frag queue Peter Oskolkov
2018-08-06 0:17 ` [PATCH net-next 0/3] ip: Use " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180802155446.604d1a9b@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=posk@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.