From: Stephen Hemminger <stephen@networkplumber.org>
To: Florian Westphal <fw@strlen.de>
Cc: <netdev@vger.kernel.org>, Peter Oskolkov <posk@google.com>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH nf-next v2 1/1] ipv6: defrag: drop non-last frags smaller than min mtu
Date: Thu, 2 Aug 2018 17:14:03 -0700 [thread overview]
Message-ID: <20180802171403.58a5e561@xeon-e3> (raw)
In-Reply-To: <20180803000539.17394-1-fw@strlen.de>
On Fri, 3 Aug 2018 02:05:39 +0200
Florian Westphal <fw@strlen.de> wrote:
> + if (-skb_network_offset(skb) + skb->len < IPV6_MIN_MTU &&
Is there a reason to write the arithmetic expression in this order?
Why not:
if (skb->len - skb_network_offset(skb) < IPV6_MIN_MTU &&
prev parent reply other threads:[~2018-08-03 2:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-03 0:05 [PATCH nf-next v2 1/1] ipv6: defrag: drop non-last frags smaller than min mtu Florian Westphal
2018-08-03 0:14 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180802171403.58a5e561@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=posk@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.