All of lore.kernel.org
 help / color / mirror / Atom feed
From: areklis909@gmail.com (Arkadiusz Lis)
To: kernelnewbies@lists.kernelnewbies.org
Subject: First patch
Date: Thu, 2 Aug 2018 23:49:03 +0200	[thread overview]
Message-ID: <20180802214903.GA5959@arek-VirtualBox> (raw)

Hi guys,
I created my first patch. Could you please take a look
and check for mistakes? It's a small clean up removing checkpatch.pl
warnings. It was generated using 'git format-patch master..<mybranch>'.  
See below:

>From 231fa77d595536cdaacf364b02dd64fd45a6adc4 Mon Sep 17 00:00:00 2001
From: Arkadiusz Lis <areklis909@gmail.com>
Date: Thu, 2 Aug 2018 23:38:17 +0200
Subject: [PATCH] Staging: One Laptop Per Child: fix coding style and license
 issues

Add argument names to the function pointers in struct
dcon_platform_data.
Add SPDX-License-Identifiers to the source files.

Signed-off-by: Arkadiusz Lis <areklis909@gmail.com>
---
 drivers/staging/olpc_dcon/olpc_dcon.c        | 1 +
 drivers/staging/olpc_dcon/olpc_dcon.h        | 6 +++---
 drivers/staging/olpc_dcon/olpc_dcon_xo_1.c   | 1 +
 drivers/staging/olpc_dcon/olpc_dcon_xo_1_5.c | 1 +
 4 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c
index 2744c9f..318adc4 100644
--- a/drivers/staging/olpc_dcon/olpc_dcon.c
+++ b/drivers/staging/olpc_dcon/olpc_dcon.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * Mainly by David Woodhouse, somewhat modified by Jordan Crouse
  *
diff --git a/drivers/staging/olpc_dcon/olpc_dcon.h b/drivers/staging/olpc_dcon/olpc_dcon.h
index fa89bb9..0ce1a7a 100644
--- a/drivers/staging/olpc_dcon/olpc_dcon.h
+++ b/drivers/staging/olpc_dcon/olpc_dcon.h
@@ -91,10 +91,10 @@ struct dcon_priv {
 };

 struct dcon_platform_data {
-	int (*init)(struct dcon_priv *);
+	int (*init)(struct dcon_priv *dcon);
 	void (*bus_stabilize_wiggle)(void);
-	void (*set_dconload)(int);
-	int (*read_status)(u8 *);
+	void (*set_dconload)(int val);
+	int (*read_status)(u8 *status);
 };

 #include <linux/interrupt.h>
diff --git a/drivers/staging/olpc_dcon/olpc_dcon_xo_1.c b/drivers/staging/olpc_dcon/olpc_dcon_xo_1.c
index 633c58c..c72f492 100644
--- a/drivers/staging/olpc_dcon/olpc_dcon_xo_1.c
+++ b/drivers/staging/olpc_dcon/olpc_dcon_xo_1.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * Mainly by David Woodhouse, somewhat modified by Jordan Crouse
  *
diff --git a/drivers/staging/olpc_dcon/olpc_dcon_xo_1_5.c b/drivers/staging/olpc_dcon/olpc_dcon_xo_1_5.c
index 6458442..07b70eb 100644
--- a/drivers/staging/olpc_dcon/olpc_dcon_xo_1_5.c
+++ b/drivers/staging/olpc_dcon/olpc_dcon_xo_1_5.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * Copyright (c) 2009,2010       One Laptop per Child
  *
--
1.9.1

             reply	other threads:[~2018-08-02 21:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-02 21:49 Arkadiusz Lis [this message]
2018-08-03  6:36 ` First patch valdis.kletnieks at vt.edu
  -- strict thread matches above, loose matches on Subject: below --
2015-12-23  3:37 first patch maoma king
2015-12-23  4:02 ` Mike Krinkin
2015-12-27 22:28 ` Jerry Snitselaar
2009-11-17  5:38 First Patch Michael Spradling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180802214903.GA5959@arek-VirtualBox \
    --to=areklis909@gmail.com \
    --cc=kernelnewbies@lists.kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.