From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
netdev@vger.kernel.org,
Jakub Kicinski <jakub.kicinski@netronome.com>,
John Fastabend <john.fastabend@gmail.com>,
brouer@redhat.com
Subject: Re: [PATCH v8 bpf-next 04/10] xdp: Helper function to clear kernel pointers in xdp_frame
Date: Fri, 3 Aug 2018 11:06:10 +0200 [thread overview]
Message-ID: <20180803110610.5f3235f8@redhat.com> (raw)
In-Reply-To: <1533283098-2397-5-git-send-email-makita.toshiaki@lab.ntt.co.jp>
On Fri, 3 Aug 2018 16:58:12 +0900
Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp> wrote:
> xdp_frame has kernel pointers which should not be readable from bpf
> programs. When we want to reuse xdp_frame region but it may be read by
> bpf programs later, we can use this helper to clear kernel pointers.
> This is more efficient than calling memset() for the entire struct.
>
> Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
After this patch is applied, I will take care of updating cpumap in a
similar way. Thanks.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2018-08-03 11:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-03 7:58 [PATCH v8 bpf-next 00/10] veth: Driver XDP Toshiaki Makita
2018-08-03 7:58 ` [PATCH v8 bpf-next 01/10] net: Export skb_headers_offset_update Toshiaki Makita
2018-08-03 7:58 ` [PATCH v8 bpf-next 02/10] veth: Add driver XDP Toshiaki Makita
2018-08-07 14:26 ` Daniel Borkmann
2018-08-08 0:53 ` Toshiaki Makita
2018-08-03 7:58 ` [PATCH v8 bpf-next 03/10] veth: Avoid drops by oversized packets when XDP is enabled Toshiaki Makita
2018-08-03 7:58 ` [PATCH v8 bpf-next 04/10] xdp: Helper function to clear kernel pointers in xdp_frame Toshiaki Makita
2018-08-03 9:06 ` Jesper Dangaard Brouer [this message]
2018-08-03 7:58 ` [PATCH v8 bpf-next 05/10] veth: Handle xdp_frames in xdp napi ring Toshiaki Makita
2018-08-03 9:07 ` Jesper Dangaard Brouer
2018-08-03 7:58 ` [PATCH v8 bpf-next 06/10] veth: Add ndo_xdp_xmit Toshiaki Makita
2018-08-03 7:58 ` [PATCH v8 bpf-next 07/10] bpf: Make redirect_info accessible from modules Toshiaki Makita
2018-08-03 7:58 ` [PATCH v8 bpf-next 08/10] xdp: Helpers for disabling napi_direct of xdp_return_frame Toshiaki Makita
2018-08-03 7:58 ` [PATCH v8 bpf-next 09/10] veth: Add XDP TX and REDIRECT Toshiaki Makita
2018-08-03 7:58 ` [PATCH v8 bpf-next 10/10] veth: Support per queue XDP ring Toshiaki Makita
2018-08-03 9:45 ` [PATCH v8 bpf-next 00/10] veth: Driver XDP Jesper Dangaard Brouer
2018-08-03 11:14 ` Toshiaki Makita
2018-08-06 8:22 ` [Intel-wired-lan] " =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?=
2018-08-06 8:22 ` Björn Töpel
2018-08-10 14:24 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180803110610.5f3235f8@redhat.com \
--to=brouer@redhat.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=jakub.kicinski@netronome.com \
--cc=john.fastabend@gmail.com \
--cc=makita.toshiaki@lab.ntt.co.jp \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.