From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH 5/5] drm/vc4: Fix negative X/Y positioning of planes using T_TILES modifier Date: Fri, 3 Aug 2018 11:06:18 +0200 Message-ID: <20180803110618.0bd41fc5@bbrezillon> References: <20180725153209.14366-1-boris.brezillon@bootlin.com> <20180725153209.14366-6-boris.brezillon@bootlin.com> <87bmas1k60.fsf@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id 9E0E26E2B3 for ; Fri, 3 Aug 2018 09:06:20 +0000 (UTC) In-Reply-To: <87bmas1k60.fsf@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Anholt , Daniel Vetter Cc: David Airlie , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAyNyBKdWwgMjAxOCAxMzo0NjozMSAtMDcwMApFcmljIEFuaG9sdCA8ZXJpY0Bhbmhv bHQubmV0PiB3cm90ZToKCj4gQm9yaXMgQnJlemlsbG9uIDxib3Jpcy5icmV6aWxsb25AYm9vdGxp bi5jb20+IHdyaXRlczoKPiAKPiA+IEZyb206IEVyaWMgQW5ob2x0IDxlcmljQGFuaG9sdC5uZXQ+ Cj4gPgo+ID4gWC9ZIHBvc2l0aW9uaW5nIG9mIFQtZm9ybWF0IGJ1ZmZlcnMgaXMgcXVpdGUgdHJp Y2t5IGFuZCB0aGUgY3VycmVudAo+ID4gaW1wbGVtZW50YXRpb24gd2FzIGZhaWxpbmcgdG8gcG9z aXRpb24gYSBwbGFuZSB1c2luZyB0aGlzIGZvcm1hdAo+ID4gY29ycmVjdGx5IHdoZW4gdGhlIFgs IFkgb3IgYm90aCBYIGFuZCBZIG9mZnNldHMgd2VyZSBuZWdhdGl2ZS4gIAo+IAo+IFdhaXQsIHdl cmUgdGhpbmdzIHdvcmtpbmcgZm9yIHlvdSB3aXRoIGV2ZW4gcG9zdGl2aWUgWC9ZIG9mZnNldHMg b24gVD8KCkkgdGhpbmsgSSB3YXMgdGFsa2luZyBhYm91dCBjcnRjX3gveSwgd2hpbGUgeW91IHdl cmUgcHJvYmFibHkgdGFsa2luZwphYm91dCBzcmNfeC95LiBJZiB5b3UgaGF2ZSBzcmNfeC95ID0g MCBhbmQgY3J0Y194L3kgPj0gMCBpdCB3b3JrcyBmaW5lLAppZiB5b3UgaGF2ZSBzcmNfeC95ID0g MCBhbmQgY3J0Y194L3kgPCAwIGl0IGRvZXNuJ3Qgd29yaywgYW5kIGlmIHlvdQpoYXZlIHNyY194 L3kgIT0gMCBpdCBkb2Vzbid0IHdvcmsgZWl0aGVyLgoKPiBCZWNhdXNlIGl0IHdhc24ndCBmb3Ig bWUsIGFuZCBJIHRoaW5rIHRoZSB0aWxlX2hfbWFzayBjaGFuZ2UgaXMKPiBpbXBvcnRhbnQgZm9y IG1ha2luZyBwb3NpdGl2ZSB3b3JrLgoKWWVzLCBmb3IgcG9zaXRpdmUgc3JjX3gveSBpdCBkb2Vz IG1hdHRlci4gSSdsbCBjbGFyaWZ5IHRoYXQgaW4gbXkKY29tbWl0IG1lc3NhZ2UuCgo+IAo+ID4g U2lnbmVkLW9mZi1ieTogRXJpYyBBbmhvbHQgPGVyaWNAYW5ob2x0Lm5ldD4KPiA+IFNpZ25lZC1v ZmYtYnk6IEJvcmlzIEJyZXppbGxvbiA8Ym9yaXMuYnJlemlsbG9uQGJvb3RsaW4uY29tPgo+ID4g LS0tCj4gPiBIaSBFcmljLAo+ID4KPiA+IEkga2VwdCB0aGUgU29CIGFuZCBhdXRob3JzaGlwIHNp bmNlIHlvdSdyZSB0aGUgb3JpZ2luYWwgYXV0aG9yLCBidXQKPiA+IEkgYWxzbyBzaWduaWZpY2Fu dGx5IHJld29ya2VkIHRoZSBjb2RlLCBzbyBJJ2QgYmUgbW9yZSBjb25maWRlbnQgaWYgeW91Cj4g PiBjb3VsZCBoYXZlIGEgY2xvc2UgbG9vayBhdCB0aGlzIGNvZGUuICAKPiAKPiBJIHRoaW5rIHlv dSBzaG91bGQgZGVmaW5pdGVseSBncmFiIGF1dGhvcnNoaXAgb24gdGhpcyBvbmUuICBZb3UgZGlk IHRoZQo+IHdvcmsgdG8gbWFrZSBpdCBhY3R1YWxseSB3b3JrLgo+IAo+ID4gQWxzbywgSSBpbnRl bnRpb25hbGx5IGRpZCBub3QgYWRkIGEgRml4ZXMgYW5kIENjLXN0YWJsZSB0byB0aGlzIGNvbW1p dAo+ID4gYmVjYXVzZSBpdCBkZXBlbmRzIG9uIGEgcmV3b3JrIHdlJ3ZlIGRvbmUgaW4KPiA+IHZj NF9wbGFuZV9zZXR1cF9jbGlwcGluZ19hbmRfc2NhbGluZygpIHdoaWNoIGNhbm5vdCBiZSBlYXNp bHkKPiA+IGJhY2twb3J0ZWQuCj4gPiBXaGF0IEkgY291bGQgZG8gdGhvdWdoIGlzIGFkZCBhIHBh dGNoIHRoYXQgcmVqZWN0cyBhbGwgbmVnYXRpdmUKPiA+IGNydGNfe3gseX0uICAKPiAKPiBBZ3Jl ZWQuICBHaXZlbiB0aGF0IHdlJ3JlIHRyeWluZyB0byBmaXggYSBidWcgdGhhdCBub2JvZHkgZWxz ZSBoYXMKPiByZXBvcnRlZCB0byBtZSB5ZXQsIEkgdGhpbmsgd2UgY2FuIHNraXAgZGVhbGluZyB3 aXRoIHRoaXMgZm9yIHN0YWJsZS4KPiAKPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS92YzQv dmM0X3BsYW5lLmMgfCA1MSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0t LQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCA0NCBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQo+ ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9wbGFuZS5jIGIvZHJp dmVycy9ncHUvZHJtL3ZjNC92YzRfcGxhbmUuYwo+ID4gaW5kZXggMmI4YmExYzQxMmJlLi5hZGU0 N2MzZjY1ZDEgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9wbGFuZS5j Cj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9wbGFuZS5jCj4gPiBAQCAtNTM5LDIy ICs1MzksNTkgQEAgc3RhdGljIGludCB2YzRfcGxhbmVfbW9kZV9zZXQoc3RydWN0IGRybV9wbGFu ZSAqcGxhbmUsCj4gPiAgCQkJCQkJIChpID8gaF9zdWJzYW1wbGUgOiAxKSAqCj4gPiAgCQkJCQkJ IGZiLT5mb3JtYXQtPmNwcFtpXTsKPiA+ICAJCX0KPiA+ICsKPiA+ICAJCWJyZWFrOwo+ID4gIAo+ ID4gIAljYXNlIERSTV9GT1JNQVRfTU9EX0JST0FEQ09NX1ZDNF9UX1RJTEVEOiB7Cj4gPiAtCQkv KiBGb3IgVC10aWxlZCwgdGhlIEZCIHBpdGNoIGlzICJob3cgbWFueSBieXRlcyBmcm9tCj4gPiAt CQkgKiBvbmUgcm93IHRvIHRoZSBuZXh0LCBzdWNoIHRoYXQgcGl0Y2ggKiB0aWxlX2ggPT0KPiA+ IC0JCSAqIHRpbGVfc2l6ZSAqIHRpbGVzX3Blcl9yb3cuIgo+ID4gLQkJICovCj4gPiAgCQl1MzIg dGlsZV9zaXplX3NoaWZ0ID0gMTI7IC8qIFQgdGlsZXMgYXJlIDRrYiAqLwo+ID4gKwkJLyogV2hv bGUtdGlsZSBvZmZzZXRzLCBtb3N0bHkgZm9yIHNldHRpbmcgdGhlIHBpdGNoLiAqLwo+ID4gKwkJ dTMyIHRpbGVfd19zaGlmdCA9IGZiLT5mb3JtYXQtPmNwcFswXSA9PSAyID8gNiA6IDU7Cj4gPiAg CQl1MzIgdGlsZV9oX3NoaWZ0ID0gNTsgLyogMTYgYW5kIDMyYnBwIGFyZSAzMiBwaXhlbHMgaGln aCAqLwo+ID4gKwkJdTMyIHRpbGVfd19tYXNrID0gKDEgPDwgdGlsZV93X3NoaWZ0KSAtIDE7Cj4g PiArCQkvKiBUaGUgaGVpZ2h0IG1hc2sgb24gMzItYml0LXBlci1waXhlbCB0aWxlcyBpcyA2Mywg aS5lLiAyCj4gPiArCQkgKiB0aW1lcyB0aGUgaGVpZ2h0IChpbiBwaXhlbHMpIG9mIGEgNGsgdGls ZS4gSSBqdXN0IGFzc3VtZWQKPiA+ICsJCSAqIHRoaXMgaXMgYWxzbyB0cnVlIGZvciBvdGhlciBS R0IgZm9ybWF0cywgYnV0IG1heWJlIGl0J3Mgbm90Lgo+ID4gKwkJICovCj4gPiArCQl1MzIgdGls ZV9oX21hc2sgPSAoMiA8PCB0aWxlX2hfc2hpZnQpIC0gMTsgIAo+IAo+IE9ubHkgMiBhbmQgNC1i eXRlIGZvcm1hdHMgYXJlIHN1cHBvcnRlZCBmb3IgVCBmb3JtYXQsIGFuZCB0aWxlcyBhcmUgMzIK PiBwaXhlbHMgaGlnaCBmb3IgYm90aCBvZiB0aG9zZS4KCk9rYXksIEknbGwgZHJvcCB0aGUgc2Vj b25kIHNlbnRlbmNlIHRoZW4uCgo+IAo+IE90aGVyIHRoYW4gdGhhdCwKPiAKPiBSZXZpZXdlZC1i eTogRXJpYyBBbmhvbHQgPGVyaWNAYW5ob2x0Lm5ldD4KPiAKPiBJIGhhdmUgYSBjb21tZW50IG9u IHBhdGNoIDMgSSdkIGxpa2UgdG8gc29ydCBvdXQsIGJ1dCBvdGhlciB0aGFuIHRoYXQKPiBJJ20g cGxlYXNlZCB3aXRoIHRoaXMgd2hvbGUgc2VyaWVzLiAgVGhhbmtzIGZvciBwZXJzZXZlcmluZyBv biBpdCEKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=