From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ido Schimmel Subject: Re: [PATCH net 1/4] mlxsw: core_acl_flex_actions: Return error for conflicting actions Date: Fri, 3 Aug 2018 16:03:54 +0300 Message-ID: <20180803130354.GA16394@splinter.mtl.com> References: <20180803125744.16200-1-idosch@mellanox.com> <20180803125744.16200-2-idosch@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, jiri@mellanox.com, petrm@mellanox.com, nird@mellanox.com, mlxsw@mellanox.com To: netdev@vger.kernel.org, sfr@canb.auug.org.au Return-path: Received: from mail-eopbgr80041.outbound.protection.outlook.com ([40.107.8.41]:31520 "EHLO EUR04-VI1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730028AbeHCPAV (ORCPT ); Fri, 3 Aug 2018 11:00:21 -0400 Content-Disposition: inline In-Reply-To: <20180803125744.16200-2-idosch@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: +Stephen On Fri, Aug 03, 2018 at 03:57:41PM +0300, Ido Schimmel wrote: > From: Nir Dotan > > Spectrum switch ACL action set is built in groups of three actions > which may point to additional actions. A group holds a single record > which can be set as goto record for pointing at a following group > or can be set to mark the termination of the lookup. This is perfectly > adequate for handling a series of actions to be executed on a packet. > While the SW model allows configuration of conflicting actions > where it is clear that some actions will never execute, the mlxsw > driver must block such configurations as it creates a conflict > over the single terminate/goto record value. ... > Where it is clear that the last action will never execute, the > mlxsw driver was issuing a warning instead of returning an error. > Therefore replace that warning with an error for this specific > case. > > Fixes: 4cda7d8d7098 ("mlxsw: core: Introduce flexible actions support") > Signed-off-by: Nir Dotan > Reviewed-by: Jiri Pirko > Signed-off-by: Ido Schimmel > --- > .../mellanox/mlxsw/core_acl_flex_actions.c | 42 +++++++++---------- Dave / Stephen, please note that this is going to conflict with recent extack changes in net-next when you merge net into net-next. Resolution is available here: https://github.com/jpirko/linux_mlxsw/blob/combined_queue/drivers/net/ethernet/mellanox/mlxsw/core_acl_flex_actions.c Thanks and sorry about the conflict