All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bill O'Donnell <billodo@redhat.com>
To: Thomas Bianchi <thomas.bianchi8@gmail.com>
Cc: linux-xfs@vger.kernel.org,
	"Darrick J. Wong" <darrick.wong@oracle.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: substitute spaces with tabs
Date: Fri, 3 Aug 2018 09:56:32 -0500	[thread overview]
Message-ID: <20180803145632.GB20657@redhat.com> (raw)
In-Reply-To: <1533140611-23467-1-git-send-email-thomas.bianchi8@gmail.com>

On Wed, Aug 01, 2018 at 06:22:25PM +0200, Thomas Bianchi wrote:
> Inside xfs_attr_shortform_list removes spaces at the beginnig of the line
> and replaces with tabs.
> Issue found by checkpatch.
> 
> ERROR: code indent should use tabs where possible
> 
> Signed-off-by: Thomas Bianchi <thomas.bianchi8@gmail.com>
> ---
looks fine.
Reviewed-by: Bill O'Donnell <billodo@redhat.com>

>  fs/xfs/xfs_attr_list.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_attr_list.c b/fs/xfs/xfs_attr_list.c
> index f9ca801..a580340 100644
> --- a/fs/xfs/xfs_attr_list.c
> +++ b/fs/xfs/xfs_attr_list.c
> @@ -87,7 +87,7 @@
>  	 */
>  	if (context->bufsize == 0 ||
>  	    (XFS_ISRESET_CURSOR(cursor) &&
> -             (dp->i_afp->if_bytes + sf->hdr.count * 16) < context->bufsize)) {
> +	     (dp->i_afp->if_bytes + sf->hdr.count * 16) < context->bufsize)) {
>  		for (i = 0, sfe = &sf->list[0]; i < sf->hdr.count; i++) {
>  			context->put_listent(context,
>  					     sfe->flags,
> -- 
> 1.8.3.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2018-08-03 16:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-01 16:22 [PATCH] xfs: substitute spaces with tabs Thomas Bianchi
2018-08-01 23:19 ` Darrick J. Wong
2018-08-03 14:56 ` Bill O'Donnell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180803145632.GB20657@redhat.com \
    --to=billodo@redhat.com \
    --cc=darrick.wong@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=thomas.bianchi8@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.