From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Date: Fri, 03 Aug 2018 20:05:18 +0000 Subject: Re: [PATCH] vfs: potential deadlock in insert_inode_locked() Message-Id: <20180803200518.GC30522@ZenIV.linux.org.uk> List-Id: References: <20180803193101.e422aso76vzbo3ko@kili.mountain> In-Reply-To: <20180803193101.e422aso76vzbo3ko@kili.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: linux-fsdevel@vger.kernel.org, kernel-janitors@vger.kernel.org On Fri, Aug 03, 2018 at 10:31:01PM +0300, Dan Carpenter wrote: > We added a new error path to insert_inode_locked() but we need to drop > the inode_hash_lock spin_lock before we return. Folded, with credits. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zeniv.linux.org.uk ([195.92.253.2]:40216 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729796AbeHCWDF (ORCPT ); Fri, 3 Aug 2018 18:03:05 -0400 Date: Fri, 3 Aug 2018 21:05:18 +0100 From: Al Viro To: Dan Carpenter Cc: linux-fsdevel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] vfs: potential deadlock in insert_inode_locked() Message-ID: <20180803200518.GC30522@ZenIV.linux.org.uk> References: <20180803193101.e422aso76vzbo3ko@kili.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180803193101.e422aso76vzbo3ko@kili.mountain> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Aug 03, 2018 at 10:31:01PM +0300, Dan Carpenter wrote: > We added a new error path to insert_inode_locked() but we need to drop > the inode_hash_lock spin_lock before we return. Folded, with credits.