From: Edward Thomson <ethomson@edwardthomson.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC PATCH 1/1] recover: restoration of deleted worktree files
Date: Sat, 4 Aug 2018 16:19:56 +0000 [thread overview]
Message-ID: <20180804161956.GA6@1032a7a09014> (raw)
In-Reply-To: <xmqqpnyyt9di.fsf@gitster-ct.c.googlers.com>
On Sat, Aug 04, 2018 at 08:54:49AM -0700, Junio C Hamano wrote:
>
> My first reaction was to say that I am not going to take a new
> command written only for bash with full bashism, even if it came
> with docs, tests nor Makefile integration, for Git itself. Then I
> reconsidered, as not everything related to Git is git-core, and all
> of the above traits are sign of this patch _not_ meant for git-core.
Yes, obviously I was not suggesting that this would be mergeable with
the bashims, as I mentioned in my cover letter.
In any case, it sounds like you're not particularly interested in
this, although I certainly appreciate you taking the time to suggest
improvements despite that. There's some good feedback there.
Cheers-
-ed
next prev parent reply other threads:[~2018-08-04 16:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-04 14:22 [RFC PATCH 0/1] Introduce git-recover Edward Thomson
2018-08-04 14:24 ` [RFC PATCH 1/1] recover: restoration of deleted worktree files Edward Thomson
2018-08-04 15:54 ` Junio C Hamano
2018-08-04 16:17 ` Robert P. J. Day
2018-08-04 17:33 ` Todd Zullinger
2018-08-04 16:19 ` Edward Thomson [this message]
2018-08-04 16:48 ` Junio C Hamano
2018-08-05 1:34 ` [RFC PATCH 0/1] Introduce git-recover Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180804161956.GA6@1032a7a09014 \
--to=ethomson@edwardthomson.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.