From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: USB: Removing NULL check for pool since dma_pool_destroy is safe From: Greg Kroah-Hartman Message-Id: <20180805142709.GA11958@kroah.com> Date: Sun, 5 Aug 2018 16:27:09 +0200 To: Salil Kapur Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gU2F0LCBBdWcgMDQsIDIwMTggYXQgMTI6MTA6MjJBTSAtMDcwMCwgU2FsaWwgS2FwdXIgd3Jv dGU6Cj4gUmVtb3ZpbmcgTlVMTCBjaGVjayBmb3IgcG9vbCBzaW5jZSBkbWFfcG9vbF9kZXN0cm95 IGlzIHNhZmUKPiAKPiBTaWduZWQtb2ZmLWJ5OiBTYWxpbCBLYXB1ciA8c2FsaWxrYXB1cjkzQGdt YWlsLmNvbT4KPiAtLS0KPiDCoGRyaXZlcnMvdXNiL2NvcmUvYnVmZmVyLmMgfCA4ICsrLS0tLS0t Cj4gwqAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQo+IAo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL3VzYi9jb3JlL2J1ZmZlci5jIGIvZHJpdmVycy91c2IvY29y ZS9idWZmZXIuYwo+IGluZGV4IDc3ZWVmOGFjZmY5NC4uZjY0MTM0MmNkZWMwIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvdXNiL2NvcmUvYnVmZmVyLmMKPiArKysgYi9kcml2ZXJzL3VzYi9jb3JlL2J1 ZmZlci5jCj4gQEAgLTEwMSwxMiArMTAxLDggQEAgdm9pZCBoY2RfYnVmZmVyX2Rlc3Ryb3koc3Ry dWN0IHVzYl9oY2QgKmhjZCkKPiDCoMKgwqDCoCDCoMKgwqAgcmV0dXJuOwo+IMKgCj4gwqDCoMKg wqAgZm9yIChpID0gMDsgaSA8IEhDRF9CVUZGRVJfUE9PTFM7IGkrKykgewo+IC3CoMKgwqAgwqDC oMKgIHN0cnVjdCBkbWFfcG9vbCAqcG9vbCA9IGhjZC0+cG9vbFtpXTsKPiAtCj4gLcKgwqDCoCDC oMKgwqAgaWYgKHBvb2wpIHsKPiAtwqDCoMKgIMKgwqDCoCDCoMKgwqAgZG1hX3Bvb2xfZGVzdHJv eShwb29sKTsKPiAtwqDCoMKgIMKgwqDCoCDCoMKgwqAgaGNkLT5wb29sW2ldID0gTlVMTDsKPiAt wqDCoMKgIMKgwqDCoCB9Cj4gK8KgwqDCoCDCoMKgwqAgZG1hX3Bvb2xfZGVzdHJveShoY2QtPnBv b2xbaV0pOwo+ICvCoMKgwqAgwqDCoMKgIGhjZC0+cG9vbFtpXSA9IE5VTEw7Cj4gwqDCoMKgwqAg fQo+IMKgfQo+IMKgCj4gLS0gCj4gMi4xNC40CgpIaSwKClRoaXMgaXMgdGhlIGZyaWVuZGx5IHBh dGNoLWJvdCBvZiBHcmVnIEtyb2FoLUhhcnRtYW4uICBZb3UgaGF2ZSBzZW50IGhpbQphIHBhdGNo IHRoYXQgaGFzIHRyaWdnZXJlZCB0aGlzIHJlc3BvbnNlLiAgSGUgdXNlZCB0byBtYW51YWxseSBy ZXNwb25kCnRvIHRoZXNlIGNvbW1vbiBwcm9ibGVtcywgYnV0IGluIG9yZGVyIHRvIHNhdmUgaGlz IHNhbml0eSAoaGUga2VwdAp3cml0aW5nIHRoZSBzYW1lIHRoaW5nIG92ZXIgYW5kIG92ZXIsIHll dCB0byBkaWZmZXJlbnQgcGVvcGxlKSwgSSB3YXMKY3JlYXRlZC4gIEhvcGVmdWxseSB5b3Ugd2ls bCBub3QgdGFrZSBvZmZlbmNlIGFuZCB3aWxsIGZpeCB0aGUgcHJvYmxlbQppbiB5b3VyIHBhdGNo IGFuZCByZXN1Ym1pdCBpdCBzbyB0aGF0IGl0IGNhbiBiZSBhY2NlcHRlZCBpbnRvIHRoZSBMaW51 eAprZXJuZWwgdHJlZS4KCllvdSBhcmUgcmVjZWl2aW5nIHRoaXMgbWVzc2FnZSBiZWNhdXNlIG9m IHRoZSBmb2xsb3dpbmcgY29tbW9uIGVycm9yKHMpCmFzIGluZGljYXRlZCBiZWxvdzoKCi0gWW91 ciBwYXRjaCBpcyBtYWxmb3JtZWQgKHRhYnMgY29udmVydGVkIHRvIHNwYWNlcywgbGluZXdyYXBw ZWQsIGV0Yy4pCiAgYW5kIGNhbiBub3QgYmUgYXBwbGllZC4gIFBsZWFzZSByZWFkIHRoZSBmaWxl LAogIERvY3VtZW50YXRpb24vZW1haWwtY2xpZW50cy50eHQgaW4gb3JkZXIgdG8gZml4IHRoaXMu CgpJZiB5b3Ugd2lzaCB0byBkaXNjdXNzIHRoaXMgcHJvYmxlbSBmdXJ0aGVyLCBvciB5b3UgaGF2 ZSBxdWVzdGlvbnMgYWJvdXQKaG93IHRvIHJlc29sdmUgdGhpcyBpc3N1ZSwgcGxlYXNlIGZlZWwg ZnJlZSB0byByZXNwb25kIHRvIHRoaXMgZW1haWwgYW5kCkdyZWcgd2lsbCByZXBseSBvbmNlIGhl IGhhcyBkdWcgb3V0IGZyb20gdGhlIHBlbmRpbmcgcGF0Y2hlcyByZWNlaXZlZApmcm9tIG90aGVy IGRldmVsb3BlcnMuCgp0aGFua3MsCgpncmVnIGstaCdzIHBhdGNoIGVtYWlsIGJvdAotLS0KVG8g dW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlIGxp bnV4LXVzYiIgaW4KdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5l bC5vcmcKTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpv cmRvbW8taW5mby5odG1sCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B282C46471 for ; Sun, 5 Aug 2018 14:27:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D505821885 for ; Sun, 5 Aug 2018 14:27:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D505821885 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726865AbeHEQb7 (ORCPT ); Sun, 5 Aug 2018 12:31:59 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:38108 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726207AbeHEQb7 (ORCPT ); Sun, 5 Aug 2018 12:31:59 -0400 Received: from localhost (unknown [89.188.5.116]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 8C96C40B; Sun, 5 Aug 2018 14:27:12 +0000 (UTC) Date: Sun, 5 Aug 2018 16:27:09 +0200 From: Greg KH To: Salil Kapur Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: Removing NULL check for pool since dma_pool_destroy is safe Message-ID: <20180805142709.GA11958@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 04, 2018 at 12:10:22AM -0700, Salil Kapur wrote: > Removing NULL check for pool since dma_pool_destroy is safe > > Signed-off-by: Salil Kapur > --- >  drivers/usb/core/buffer.c | 8 ++------ >  1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/usb/core/buffer.c b/drivers/usb/core/buffer.c > index 77eef8acff94..f641342cdec0 100644 > --- a/drivers/usb/core/buffer.c > +++ b/drivers/usb/core/buffer.c > @@ -101,12 +101,8 @@ void hcd_buffer_destroy(struct usb_hcd *hcd) >          return; >   >      for (i = 0; i < HCD_BUFFER_POOLS; i++) { > -        struct dma_pool *pool = hcd->pool[i]; > - > -        if (pool) { > -            dma_pool_destroy(pool); > -            hcd->pool[i] = NULL; > -        } > +        dma_pool_destroy(hcd->pool[i]); > +        hcd->pool[i] = NULL; >      } >  } >   > -- > 2.14.4 Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch is malformed (tabs converted to spaces, linewrapped, etc.) and can not be applied. Please read the file, Documentation/email-clients.txt in order to fix this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot