From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rahul Lakkireddy Subject: Re: [endianness bug] cxgb4: mk_act_open_req() buggers ->{local,peer}_ip on big-endian hosts Date: Mon, 6 Aug 2018 17:45:01 +0530 Message-ID: <20180806121459.GA5591@chelsio.com> References: <20180805172238.GH15082@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: ganeshgr@chelsio.com, David Miller , "netdev@vger.kernel.org" To: Al Viro Return-path: Received: from stargate.chelsio.com ([12.32.117.8]:30549 "EHLO stargate.chelsio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731137AbeHFOZi (ORCPT ); Mon, 6 Aug 2018 10:25:38 -0400 Content-Disposition: inline In-Reply-To: <20180805172238.GH15082@ZenIV.linux.org.uk> Sender: netdev-owner@vger.kernel.org List-ID: On Sunday, August 08/05/18, 2018 at 22:52:38 +0530, Al Viro wrote: > Unlike fs.val.lport and fs.val.fport, cxgb4_process_flow_match() > sets fs.val.{l,f}ip to net-endian values without conversion - they come > straight from flow_dissector_key_ipv4_addrs ->dst and ->src resp. So > the assignment in mk_act_open_req() ought to be a straigh copy. > > As far as I know, T4 PCIe cards do exist, so it's not as if that > thing could only be found on little-endian systems... > > Signed-off-by: Al Viro > --- > diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c > index 00fc5f1afb1d..7dddb9e748b8 100644 > --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c > +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c > @@ -1038,10 +1038,8 @@ static void mk_act_open_req(struct filter_entry *f, struct sk_buff *skb, > OPCODE_TID(req) = htonl(MK_OPCODE_TID(CPL_ACT_OPEN_REQ, qid_filterid)); > req->local_port = cpu_to_be16(f->fs.val.lport); > req->peer_port = cpu_to_be16(f->fs.val.fport); > - req->local_ip = f->fs.val.lip[0] | f->fs.val.lip[1] << 8 | > - f->fs.val.lip[2] << 16 | f->fs.val.lip[3] << 24; > - req->peer_ip = f->fs.val.fip[0] | f->fs.val.fip[1] << 8 | > - f->fs.val.fip[2] << 16 | f->fs.val.fip[3] << 24; > + memcpy(&req->local_ip, f->fs.val.lip, 4); > + memcpy(&req->peer_ip, f->fs.val.fip, 4); > req->opt0 = cpu_to_be64(NAGLE_V(f->fs.newvlan == VLAN_REMOVE || > f->fs.newvlan == VLAN_REWRITE) | > DELACK_V(f->fs.hitcnts) | Thanks for fix Al! Acked-by: Rahul Lakkireddy