From: Oleg Nesterov <oleg@redhat.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Milind Chabbi <chabbi.milind@gmail.com>,
lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
David Ahern <dsahern@gmail.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Frederic Weisbecker <frederic@kernel.org>
Subject: Re: [PATCH 2/2] perf/hw_breakpoint: Modify breakpoint even if the new attr has disabled set
Date: Mon, 6 Aug 2018 15:46:58 +0200 [thread overview]
Message-ID: <20180806134658.GE7840@redhat.com> (raw)
In-Reply-To: <20180806132353.GA7463@krava>
On 08/06, Jiri Olsa wrote:
>
> > Afaics you do not need to clear attr.disabled, modify_user_hw_breakpoint_check()
> > updates it if err = 0. So I think
> >
> > if (!bp->attr.disabled)
> > perf_event_enable(bp);
> >
> > will look a bit better.
> >
> >
> > But, with or without this fix, shouldn't we set .disabled = 1 if modify_() fails?
> > IIUC this doesn't matter, bp->attr.disabled is not really used anyway, but looks a
> > bit confusing.
> >
>
> yea, I was looking on that, but as u said it makes no difference
> and I wanted to keep the patch as simple as possible ;-)
OK. So both patches look good to me.
Acked-by: Oleg Nesterov <oleg@redhat.com>
next prev parent reply other threads:[~2018-08-06 13:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-06 10:12 [PATCH 0/2] perf/hw_breakpoint: Fix breakpoint modify Jiri Olsa
2018-08-06 10:12 ` [PATCH 1/2] perf tests: Add breakpoint modify test Jiri Olsa
2018-08-06 10:12 ` [PATCH 2/2] perf/hw_breakpoint: Modify breakpoint even if the new attr has disabled set Jiri Olsa
2018-08-06 12:48 ` Oleg Nesterov
2018-08-06 13:07 ` Oleg Nesterov
2018-08-06 13:37 ` Jiri Olsa
2018-08-06 13:49 ` Oleg Nesterov
2018-08-06 14:21 ` Jiri Olsa
2018-08-06 13:23 ` Jiri Olsa
2018-08-06 13:46 ` Oleg Nesterov [this message]
2018-08-06 15:08 ` [PATCH 3/2] perf/hw_breakpoint: Remove superfluous bp->attr.disabled = 0 " Jiri Olsa
2018-08-06 16:34 ` Oleg Nesterov
2018-08-07 8:16 ` Jiri Olsa
2018-08-07 9:10 ` Oleg Nesterov
2018-08-07 14:39 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180806134658.GE7840@redhat.com \
--to=oleg@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=chabbi.milind@gmail.com \
--cc=dsahern@gmail.com \
--cc=frederic@kernel.org \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.