From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sinclair Yeh Subject: Re: [PATCH v3 10/10] drm/vmwgfx: Use __drm_atomic_helper_plane_reset instead of copying the logic Date: Mon, 6 Aug 2018 09:57:53 -0700 Message-ID: <20180806165752.GD17089@vmware.com> References: <20180804161530.12275-1-alexandru-cosmin.gheorghe@arm.com> <20180804161530.12275-11-alexandru-cosmin.gheorghe@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180804161530.12275-11-alexandru-cosmin.gheorghe@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alexandru Gheorghe Cc: alexandre.belloni@bootlin.com, airlied@linux.ie, liviu.dudau@arm.com, dri-devel@lists.freedesktop.org, laurent.pinchart@ideasonboard.com, thellstrom@vmware.com, krzk@kernel.org, maxime.ripard@bootlin.com, wens@csie.org, kgene@kernel.org, malidp@foss.arm.com, linux-graphics-maintainer@vmware.com, sunpeng.li@amd.com, boris.brezillon@bootlin.com, linux-samsung-soc@vger.kernel.org, nd@arm.com, Tony.Cheng@amd.com, linux-arm-kernel@lists.infradead.org, sw0312.kim@samsung.com, nicolas.ferre@microchip.com, shirish.s@amd.com, kyungmin.park@samsung.com, alexander.deucher@amd.com, christian.koenig@amd.com List-Id: linux-samsung-soc@vger.kernel.org QWNrZWQtYnk6IFNpbmNsYWlyIFllaCA8c3llaEB2bXdhcmUuY29tPgoKT24gU2F0LCBBdWcgMDQs IDIwMTggYXQgMDU6MTU6MzBQTSArMDEwMCwgQWxleGFuZHJ1IEdoZW9yZ2hlIHdyb3RlOgo+IEEg bmV3IGhlbHBlciBmdW5jdGlvbihfX2RybV9hdG9taWNfaGVscGVyX3BsYW5lX3Jlc2V0KSBoYXMg YmVlbiBhZGRlZAo+IGZvciBsaW5raW5nIGEgcGxhbmUgd2l0aCBpdHMgc3RhdGUgYW5kIHJlc2V0 dGluZyB0aGUgY29yZQo+IHByb3BlcnRpZXMoYWxwaGEsIHJvdGF0aW9uLCBldGMuKSB0byB0aGVp ciBkZWZhdWx0IHZhbHVlcy4KPiBVc2UgdGhhdCBpbnN0ZWFkIG9mIGR1cGxpY2F0aW5nIHRoZSBs b2dpYy4KPiAKPiBSZXZpZXdlZC1ieTogU2luY2xhaXIgWWVoIDxzeWVoQHZtd2FyZS5jb20+Cj4g UmV2aWV3ZWQtYnk6IERlZXBhayBSYXdhdCA8ZHJhd2F0QHZtd2FyZS5jb20+Cj4gU2lnbmVkLW9m Zi1ieTogQWxleGFuZHJ1IEdoZW9yZ2hlIDxhbGV4YW5kcnUtY29zbWluLmdoZW9yZ2hlQGFybS5j b20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS92bXdnZngvdm13Z2Z4X2ttcy5jIHwgNCArLS0t Cj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMyBkZWxldGlvbnMoLSkKPiAKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3Ztd2dmeC92bXdnZnhfa21zLmMgYi9kcml2ZXJz L2dwdS9kcm0vdm13Z2Z4L3Ztd2dmeF9rbXMuYwo+IGluZGV4IDRhMGYwZjQxYWZhMS4uNjE4MjRl MzYwNjE5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS92bXdnZngvdm13Z2Z4X2ttcy5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3Ztd2dmeC92bXdnZnhfa21zLmMKPiBAQCAtNzIwLDkg KzcyMCw3IEBAIHZvaWQgdm13X2R1X3BsYW5lX3Jlc2V0KHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5l KQo+ICAJCXJldHVybjsKPiAgCX0KPiAgCj4gLQlwbGFuZS0+c3RhdGUgPSAmdnBzLT5iYXNlOwo+ IC0JcGxhbmUtPnN0YXRlLT5wbGFuZSA9IHBsYW5lOwo+IC0JcGxhbmUtPnN0YXRlLT5yb3RhdGlv biA9IERSTV9NT0RFX1JPVEFURV8wOwo+ICsJX19kcm1fYXRvbWljX2hlbHBlcl9wbGFuZV9yZXNl dChwbGFuZSwgJnZwcy0+YmFzZSk7Cj4gIH0KPiAgCj4gIAo+IC0tIAo+IDIuMTguMAo+IApfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: syeh@vmware.com (Sinclair Yeh) Date: Mon, 6 Aug 2018 09:57:53 -0700 Subject: [PATCH v3 10/10] drm/vmwgfx: Use __drm_atomic_helper_plane_reset instead of copying the logic In-Reply-To: <20180804161530.12275-11-alexandru-cosmin.gheorghe@arm.com> References: <20180804161530.12275-1-alexandru-cosmin.gheorghe@arm.com> <20180804161530.12275-11-alexandru-cosmin.gheorghe@arm.com> Message-ID: <20180806165752.GD17089@vmware.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Acked-by: Sinclair Yeh On Sat, Aug 04, 2018 at 05:15:30PM +0100, Alexandru Gheorghe wrote: > A new helper function(__drm_atomic_helper_plane_reset) has been added > for linking a plane with its state and resetting the core > properties(alpha, rotation, etc.) to their default values. > Use that instead of duplicating the logic. > > Reviewed-by: Sinclair Yeh > Reviewed-by: Deepak Rawat > Signed-off-by: Alexandru Gheorghe > --- > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c > index 4a0f0f41afa1..61824e360619 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c > @@ -720,9 +720,7 @@ void vmw_du_plane_reset(struct drm_plane *plane) > return; > } > > - plane->state = &vps->base; > - plane->state->plane = plane; > - plane->state->rotation = DRM_MODE_ROTATE_0; > + __drm_atomic_helper_plane_reset(plane, &vps->base); > } > > > -- > 2.18.0 >