From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony PERARD Subject: Re: [PATCH v4 23/32] libxl_qmp: Respond to QMP greeting Date: Mon, 6 Aug 2018 18:41:37 +0100 Message-ID: <20180806174137.GS1327@perard.uk.xensource.com> References: <20180727140614.13256-1-anthony.perard@citrix.com> <20180727140614.13256-24-anthony.perard@citrix.com> <20180802112635.iab5bi7tfi2yk7yq@mac> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1fmjVl-000800-LZ for xen-devel@lists.xenproject.org; Mon, 06 Aug 2018 17:41:41 +0000 Content-Disposition: inline In-Reply-To: <20180802112635.iab5bi7tfi2yk7yq@mac> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Roger Pau =?iso-8859-1?Q?Monn=E9?= Cc: xen-devel@lists.xenproject.org, Ian Jackson , Wei Liu List-Id: xen-devel@lists.xenproject.org T24gVGh1LCBBdWcgMDIsIDIwMTggYXQgMDE6MjY6MzVQTSArMDIwMCwgUm9nZXIgUGF1IE1vbm7D qSB3cm90ZToKPiBPbiBGcmksIEp1bCAyNywgMjAxOCBhdCAwMzowNjowNVBNICswMTAwLCBBbnRo b255IFBFUkFSRCB3cm90ZToKPiA+IFNpZ25lZC1vZmYtYnk6IEFudGhvbnkgUEVSQVJEIDxhbnRo b255LnBlcmFyZEBjaXRyaXguY29tPgo+ID4gLS0tCj4gPiAgdG9vbHMvbGlieGwvbGlieGxfcW1w LmMgfCAzNiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0KPiA+ICAxIGZpbGUg Y2hhbmdlZCwgMzAgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAt LWdpdCBhL3Rvb2xzL2xpYnhsL2xpYnhsX3FtcC5jIGIvdG9vbHMvbGlieGwvbGlieGxfcW1wLmMK PiA+IGluZGV4IGU2NDliODA1NGQuLjgzYWZjZTMxOTIgMTAwNjQ0Cj4gPiAtLS0gYS90b29scy9s aWJ4bC9saWJ4bF9xbXAuYwo+ID4gKysrIGIvdG9vbHMvbGlieGwvbGlieGxfcW1wLmMKPiA+IEBA IC0xMzA5LDYgKzEzMDksOSBAQCBpbnQgbGlieGxfX3FtcF9pbml0aWFsaXphdGlvbnMobGlieGxf X2djICpnYywgdWludDMyX3QgZG9taWQsCj4gPiAgCj4gPiAgLyogLS0tLS0tLS0tLS0tIEltcGxl bWVudGF0aW9uIG9mIGxpYnhsX19ldl9xbXAgLS0tLS0tLS0tLS0tLS0tLSAqLwo+ID4gIAo+ID4g Ky8qIGhhcmQgY29kZWQgbWVzc2FnZSBJRCB1c2VkIGZvciBjYXBhYmlsaXR5IG5lZ29jaWF0aW9u ICovCj4gPiArc3RhdGljIGludCBxbXBfY2FwYWJpbGl0eV9uZWdvY2lhdGlvbl9tc2dpZCA9IDE7 Cj4gCj4gQ291bGQgdGhpcyBiZSBhIGRlZmluZSBpbnN0ZWFkPyBPciBhdCBsZWFzdCBjb25zdGlm eSBpdCBiZWNhdXNlIGl0Cj4gZG9lc24ndCBzZWVtIGxpa2UgaXQncyBtb2RpZmllZCAoYXQgbGVh c3QgaW4gdGhpcyBwYXRjaCkuCgpJIGd1ZXNzIGEgZGVmaW5lIHdpbGwgZG8uCgo+ID4gIHN0YXRp YyBpbnQgcW1wX2V2X3ByZXBhcmVfY21kKGxpYnhsX19nYyAqZ2MsCj4gPiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgbGlieGxfX2V2X3FtcCAqZXYsCj4gPiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgY29uc3QgY2hhciAqY21kLAo+ID4gQEAgLTEzNzksNyArMTM4Miw3IEBA IHN0YXRpYyBpbnQgcW1wX2V2X2hhbmRsZV9yZXNwb25zZShsaWJ4bF9fZWdjICplZ2MsCj4gPiAg ICAgIH0KPiA+ICAKPiA+ICAgICAgaWQgPSBsaWJ4bF9fanNvbl9vYmplY3RfZ2V0X2ludGVnZXIo byk7Cj4gPiAtICAgIGlmIChpZCAhPSBldi0+aWQpCj4gPiArICAgIGlmIChpZCAhPSBldi0+aWQg JiYgaWQgIT0gcW1wX2NhcGFiaWxpdHlfbmVnb2NpYXRpb25fbXNnaWQpCj4gPiAgICAgICAgICBy ZXR1cm4gMDsKPiA+ICAKPiA+ICAgICAgc3dpdGNoICh0eXBlKSB7Cj4gPiBAQCAtMTQxMyw5ICsx NDE2LDIxIEBAIHN0YXRpYyBpbnQgcW1wX2V2X2hhbmRsZV9yZXNwb25zZShsaWJ4bF9fZWdjICpl Z2MsCj4gPiAgICAgICAgICBhYm9ydCgpOwo+ID4gICAgICB9Cj4gPiAgCj4gPiAtICAgIGV2LT5p ZCA9IC0xOwo+ID4gLSAgICBldi0+Y2FsbGJhY2soZWdjLCBldiwgcmVzcG9uc2UsIHJjKTsgLyog bXVzdCBiZSBsYXN0ICovCj4gPiAtICAgIHJldHVybiAxOwo+ID4gKyAgICAvKgo+ID4gKyAgICAg KiBFdmVuIGlmIHRoZSBjdXJyZW50IHN0YXRlIGlzIGNhcGFiaWxpdHlfbmVnb2NpYXRpb24gYW5k IHRoZSBjb3JyZWN0IElECj4gPiArICAgICAqIGFzIGJlZW4gcmVjZWl2ZWQsIGNhbGwgdGhlIGNh bGxiYWNrIG9uIGVycm9yLgo+ID4gKyAgICAgKi8KPiA+ICsgICAgaWYgKGV2LT5xbXBfc3RhdGUg PT0gcW1wX3N0YXRlX2NhcGFiaWxpdHlfbmVnb2NpYXRpb24gJiYKPiA+ICsgICAgICAgIGlkID09 IHFtcF9jYXBhYmlsaXR5X25lZ29jaWF0aW9uX21zZ2lkICYmCj4gPiArICAgICAgICByYyA9PSAw KSB7Cj4gPiArICAgICAgICBldi0+cW1wX3N0YXRlID0gcW1wX3N0YXRlX2Nvbm5lY3RlZDsKPiA+ ICsgICAgICAgIGxpYnhsX19ldl9mZF9tb2RpZnkoZ2MsICZldi0+cW1wX2VmZCwgZXYtPnFtcF9l ZmQuZXZlbnRzIHwgUE9MTE9VVCk7Cj4gPiArICAgICAgICByZXR1cm4gMDsKPiA+ICsgICAgfSBl bHNlIHsKPiA+ICsgICAgICAgIGV2LT5pZCA9IC0xOwo+ID4gKyAgICAgICAgZXYtPmNhbGxiYWNr KGVnYywgZXYsIHJlc3BvbnNlLCByYyk7IC8qIG11c3QgYmUgbGFzdCAqLwo+ID4gKyAgICAgICAg cmV0dXJuIDE7Cj4gPiArICAgIH0KPiA+ICB9Cj4gPiAgCj4gPiAgLyogcmV0dXJuIDEgd2hlbiBh IHVzZXIgY2FsbGJhY2sgYXMgYmVlbiBjYWxsZWQgKi8KPiA+IEBAIC0xNDI5LDYgKzE0NDQsMTEg QEAgc3RhdGljIGludCBxbXBfZXZfaGFuZGxlX21lc3NhZ2UobGlieGxfX2VnYyAqZWdjLAo+ID4g ICAgICBzd2l0Y2ggKHR5cGUpIHsKPiA+ICAgICAgY2FzZSBMSUJYTF9fUU1QX01FU1NBR0VfVFlQ RV9RTVA6Cj4gPiAgICAgICAgICAvKiBncmVldGluZyBtZXNzYWdlICovCj4gPiArICAgICAgICBh c3NlcnQoZXYtPnFtcF9zdGF0ZSA9PSBxbXBfc3RhdGVfY29ubmVjdGluZyk7Cj4gPiArICAgICAg ICBldi0+cW1wX3N0YXRlID0gcW1wX3N0YXRlX2dyZWV0aW5nOwo+ID4gKyAgICAgICAgLyogQWxs b3cgcW1wX2V2X2NhbGxiYWNrX3dyaXRhYmxlIHRvIGJlIGNhbGxlZCBpbiBvcmRlciB0byBzZW5k Cj4gPiArICAgICAgICAgKiBxbXBfY2FwYWJpbGl0aWVzICovCj4gPiArICAgICAgICBsaWJ4bF9f ZXZfZmRfbW9kaWZ5KGdjLCAmZXYtPnFtcF9lZmQsIGV2LT5xbXBfZWZkLmV2ZW50cyB8IFBPTExP VVQpOwo+ID4gICAgICAgICAgcmV0dXJuIDA7Cj4gPiAgICAgIGNhc2UgTElCWExfX1FNUF9NRVNT QUdFX1RZUEVfUkVUVVJOOgo+ID4gICAgICBjYXNlIExJQlhMX19RTVBfTUVTU0FHRV9UWVBFX0VS Uk9SOgo+ID4gQEAgLTE1NjMsNyArMTU4MywxMSBAQCBzdGF0aWMgaW50IHFtcF9ldl9jYWxsYmFj a193cml0YWJsZShsaWJ4bF9fZ2MgKmdjLCBsaWJ4bF9fZXZfcW1wICpldiwgaW50IGZkKQo+ID4g ICAgICAgKiBiZSBzZW5kIGZvciBub3cgd2lsbCBiZSBpbiB0aGlzIGNhbGwuICovCj4gPiAgICAg IGxpYnhsX19ldl9mZF9tb2RpZnkoZ2MsICZldi0+cW1wX2VmZCwgZXYtPnFtcF9lZmQuZXZlbnRz ICYgflBPTExPVVQpOwo+ID4gIAo+ID4gLSAgICBpZiAoZXYtPnFtcF9zdGF0ZSA9PSBxbXBfc3Rh dGVfY29ubmVjdGVkKSB7Cj4gPiArICAgIGlmIChldi0+cW1wX3N0YXRlID09IHFtcF9zdGF0ZV9n cmVldGluZykgewo+ID4gKyAgICAgICAgYnVmID0gcW1wX3ByZXBhcmVfcW1wX2NtZChnYywgInFt cF9jYXBhYmlsaXRpZXMiLCBOVUxMLAo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBxbXBfY2FwYWJpbGl0eV9uZWdvY2lhdGlvbl9tc2dpZCwgJmxlbik7Cj4gPiArICAgICAg ICBldi0+cW1wX3N0YXRlID0gcW1wX3N0YXRlX2NhcGFiaWxpdHlfbmVnb2NpYXRpb247Cj4gPiAr ICAgIH0gZWxzZSBpZiAoZXYtPnFtcF9zdGF0ZSA9PSBxbXBfc3RhdGVfY29ubmVjdGVkKSB7Cj4g Cj4gQSBzd2l0Y2ggKGV2LT5xbXBfc3RhdGUpIG1pZ2h0IGJlIGJldHRlci4KCkkgZ3Vlc3MsIGl0 J3MgbGVzcyByZXBldGl0aW9uIG9mIGV2LT5xbXBfc3RhdGUuIEknbGwgc3dpdGNoLgoKVGhhbmtz LAoKLS0gCkFudGhvbnkgUEVSQVJECgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5w cm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8v eGVuLWRldmVs