From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v8,3/3] dmaengine: fsl-edma: add ColdFire mcf5441x edma support From: Angelo Dureghello Message-Id: <20180806202313.GA6092@jerusalem> Date: Mon, 6 Aug 2018 22:23:13 +0200 To: Stefan Agner Cc: Krzysztof Kozlowski , vinod.koul@linaro.org, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-m68k@vger.kernel.org List-ID: SGkgU3RlZmFuLApPbiBNb24sIEF1ZyAwNiwgMjAxOCBhdCAwMjoyMTo1MlBNICswMjAwLCBTdGVm YW4gQWduZXIgd3JvdGU6Cj4gT24gMDYuMDguMjAxOCAxMDowOSwgS3J6eXN6dG9mIEtvemxvd3Nr aSB3cm90ZToKPiA+IE9uIDMgQXVndXN0IDIwMTggYXQgMjE6MzIsIEFuZ2VsbyBEdXJlZ2hlbGxv IDxhbmdlbG9Ac3lzYW0uaXQ+IHdyb3RlOgo+ID4+IFRoaXMgcGF0Y2ggYWRkcyBzdXBwb3J0IGZv ciBDb2xkRmlyZSBtY2Y1NDQxeC1mYW1pbHkgZWRtYQo+ID4+IG1vZHVsZS4KPiA+Pgo+ID4+IFRo ZSBDb2xkRmlyZSBlZG1hIG1vZHVsZSBpcyBzbGlnaHRseSBkaWZmZXJlbnQgZnJvbSBmc2wtZWRt YSwKPiA+PiBzbyBhIG5ldyBkcml2ZXIgaXMgYWRkZWQuIEJ1dCBtb3N0IG9mIHRoZSBjb2RlIGlz IGNvbW1vbgo+ID4+IGJldHdlZW4gZnNsLWVkbWEgYW5kIG1jZi1lZG1hIHNvIGl0IGhhcyBiZWVu IGNvbGxlY3RlZCBpbnRvIGEKPiA+PiBzZXBhcmF0ZSBjb21tb24gbW9kdWxlIGZzbC1lZG1hLWNv bW1vbiAocGF0Y2ggMS8zKS4KPiA+Pgo+ID4+IFNpZ25lZC1vZmYtYnk6IEFuZ2VsbyBEdXJlZ2hl bGxvIDxhbmdlbG9Ac3lzYW0uaXQ+Cj4gWy4uLl0KPiA+PiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9s aW51eC9wbGF0Zm9ybV9kYXRhL2RtYS1tY2YtZWRtYS5oIGIvaW5jbHVkZS9saW51eC9wbGF0Zm9y bV9kYXRhL2RtYS1tY2YtZWRtYS5oCj4gPj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiA+PiBpbmRl eCAwMDAwMDAwMDAwMDAuLjlhMTgxOWFjYjI4Zgo+ID4+IC0tLSAvZGV2L251bGwKPiA+PiArKysg Yi9pbmNsdWRlL2xpbnV4L3BsYXRmb3JtX2RhdGEvZG1hLW1jZi1lZG1hLmgKPiA+PiBAQCAtMCww ICsxLDM4IEBACj4gPj4gKy8qIFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiBHUEwtMi4wICovCj4g Pj4gKy8qCj4gPj4gKyAqIEZyZWVzY2FsZSBlRE1BIHBsYXRmb3JtIGRhdGEsIENvbGRGaXJlIFNv QydzIGZhbWlseS4KPiA+PiArICoKPiA+PiArICogQ29weXJpZ2h0IChjKSAyMDE3IEFuZ2VsbyBE dXJlZ2hlbGxvIDxhbmdlbG9Ac3lzYW0uaXQ+Cj4gPj4gKyAqCj4gPj4gKyAqIFRoaXMgcHJvZ3Jh bSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IgbW9kaWZ5 Cj4gPj4gKyAqIGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExp Y2Vuc2UgdmVyc2lvbiAyIGFzCj4gPj4gKyAqIHB1Ymxpc2hlZCBieSB0aGUgRnJlZSBTb2Z0d2Fy ZSBGb3VuZGF0aW9uLgo+ID4+ICsgKgo+ID4+ICsgKiBUaGlzIHByb2dyYW0gaXMgZGlzdHJpYnV0 ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwKPiA+PiArICogYnV0IFdJVEhP VVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YKPiA+ PiArICogTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NF LiAgU2VlIHRoZQo+ID4+ICsgKiBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBk ZXRhaWxzLgo+ID4+ICsgKi8KPiA+PiArCj4gPj4gKyNpZm5kZWYgX19NQUNIX01DRl9FRE1BX0hf Xwo+ID4+ICsjZGVmaW5lIF9fTUFDSF9NQ0ZfRURNQV9IX18KPiA+IAo+ID4gVGhlIGd1YXJkIHNo b3VsZCByYXRoZXIgbWF0Y2ggY3VycmVudCBsb2NhdGlvbiwgZS5nLgo+ID4gX19MSU5VWF9QTEFU Rk9STV9EQVRBX01DRl9FRE1BX0hfXwo+ID4gCj4gPiBUZXN0ZWQtYnk6IEtyenlzenRvZiBLb3ps b3dza2kgPGtyemtAa2VybmVsLm9yZz4KPiA+IAo+IAo+IFNvIHRoaXMgcmV2aXNpb24gZml4ZWQg dGhlIGlzc3VlIHdlIGhhZCBzZWVuIHdpdGggdGhlIHByZXZpb3VzIHZlcnNpb24/Cj4gRG8gd2Ug a25vdyB3aGF0IGl0IHdhcyBleGFjdGx5Pwo+IApXZWxsLCBuby4gSSByZXN0YXJ0ZWQgY29tcGxl dGVseSB0aGUgcGF0Y2ggZnJvbSBzY3JhdGNoIG1vdmluZy9jaGFuZ2luZwp0aGUgY29kZSBjYXJl ZnVsbHkuIEkgYXZvaWRlZCBjaGFuZ2VzIHRvIEZyZWVzY2FsZSBjb2RlIGFzIG11Y2ggCmFzIHBv c3NpYmxlLgoKPiAtLQo+IFN0ZWZhbgo+IC0tCj4gVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxp c3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlIGRtYWVuZ2luZSIgaW4KPiB0aGUgYm9keSBv ZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZwo+IE1vcmUgbWFqb3Jkb21v IGluZm8gYXQgIGh0dHA6Ly92Z2VyLmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbAoKUmVn YXJkcywKQW5nZWxvCi0tLQpUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUg bGluZSAidW5zdWJzY3JpYmUgZG1hZW5naW5lIiBpbgp0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8g bWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZwpNb3JlIG1ham9yZG9tbyBpbmZvIGF0ICBodHRwOi8v dmdlci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Angelo Dureghello Subject: Re: [PATCH v8 3/3] dmaengine: fsl-edma: add ColdFire mcf5441x edma support Date: Mon, 6 Aug 2018 22:23:13 +0200 Message-ID: <20180806202313.GA6092@jerusalem> References: <20180803193244.12084-1-angelo@sysam.it> <20180803193244.12084-3-angelo@sysam.it> <0be6407cf2c5721ef59b6e3ae233394d@agner.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <0be6407cf2c5721ef59b6e3ae233394d@agner.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Stefan Agner Cc: dmaengine@vger.kernel.org, linux-m68k@vger.kernel.org, vinod.koul@linaro.org, Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org List-Id: linux-m68k@vger.kernel.org Hi Stefan, On Mon, Aug 06, 2018 at 02:21:52PM +0200, Stefan Agner wrote: > On 06.08.2018 10:09, Krzysztof Kozlowski wrote: > > On 3 August 2018 at 21:32, Angelo Dureghello wrote: > >> This patch adds support for ColdFire mcf5441x-family edma > >> module. > >> > >> The ColdFire edma module is slightly different from fsl-edma, > >> so a new driver is added. But most of the code is common > >> between fsl-edma and mcf-edma so it has been collected into a > >> separate common module fsl-edma-common (patch 1/3). > >> > >> Signed-off-by: Angelo Dureghello > [...] > >> diff --git a/include/linux/platform_data/dma-mcf-edma.h b/include/linux/platform_data/dma-mcf-edma.h > >> new file mode 100644 > >> index 000000000000..9a1819acb28f > >> --- /dev/null > >> +++ b/include/linux/platform_data/dma-mcf-edma.h > >> @@ -0,0 +1,38 @@ > >> +/* SPDX-License-Identifier: GPL-2.0 */ > >> +/* > >> + * Freescale eDMA platform data, ColdFire SoC's family. > >> + * > >> + * Copyright (c) 2017 Angelo Dureghello > >> + * > >> + * This program is free software; you can redistribute it and/or modify > >> + * it under the terms of the GNU General Public License version 2 as > >> + * published by the Free Software Foundation. > >> + * > >> + * This program is distributed in the hope that it will be useful, > >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of > >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > >> + * GNU General Public License for more details. > >> + */ > >> + > >> +#ifndef __MACH_MCF_EDMA_H__ > >> +#define __MACH_MCF_EDMA_H__ > > > > The guard should rather match current location, e.g. > > __LINUX_PLATFORM_DATA_MCF_EDMA_H__ > > > > Tested-by: Krzysztof Kozlowski > > > > So this revision fixed the issue we had seen with the previous version? > Do we know what it was exactly? > Well, no. I restarted completely the patch from scratch moving/changing the code carefully. I avoided changes to Freescale code as much as possible. > -- > Stefan > -- > To unsubscribe from this list: send the line "unsubscribe dmaengine" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Regards, Angelo From mboxrd@z Thu Jan 1 00:00:00 1970 From: angelo@sysam.it (Angelo Dureghello) Date: Mon, 6 Aug 2018 22:23:13 +0200 Subject: [PATCH v8 3/3] dmaengine: fsl-edma: add ColdFire mcf5441x edma support In-Reply-To: <0be6407cf2c5721ef59b6e3ae233394d@agner.ch> References: <20180803193244.12084-1-angelo@sysam.it> <20180803193244.12084-3-angelo@sysam.it> <0be6407cf2c5721ef59b6e3ae233394d@agner.ch> Message-ID: <20180806202313.GA6092@jerusalem> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Stefan, On Mon, Aug 06, 2018 at 02:21:52PM +0200, Stefan Agner wrote: > On 06.08.2018 10:09, Krzysztof Kozlowski wrote: > > On 3 August 2018 at 21:32, Angelo Dureghello wrote: > >> This patch adds support for ColdFire mcf5441x-family edma > >> module. > >> > >> The ColdFire edma module is slightly different from fsl-edma, > >> so a new driver is added. But most of the code is common > >> between fsl-edma and mcf-edma so it has been collected into a > >> separate common module fsl-edma-common (patch 1/3). > >> > >> Signed-off-by: Angelo Dureghello > [...] > >> diff --git a/include/linux/platform_data/dma-mcf-edma.h b/include/linux/platform_data/dma-mcf-edma.h > >> new file mode 100644 > >> index 000000000000..9a1819acb28f > >> --- /dev/null > >> +++ b/include/linux/platform_data/dma-mcf-edma.h > >> @@ -0,0 +1,38 @@ > >> +/* SPDX-License-Identifier: GPL-2.0 */ > >> +/* > >> + * Freescale eDMA platform data, ColdFire SoC's family. > >> + * > >> + * Copyright (c) 2017 Angelo Dureghello > >> + * > >> + * This program is free software; you can redistribute it and/or modify > >> + * it under the terms of the GNU General Public License version 2 as > >> + * published by the Free Software Foundation. > >> + * > >> + * This program is distributed in the hope that it will be useful, > >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of > >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > >> + * GNU General Public License for more details. > >> + */ > >> + > >> +#ifndef __MACH_MCF_EDMA_H__ > >> +#define __MACH_MCF_EDMA_H__ > > > > The guard should rather match current location, e.g. > > __LINUX_PLATFORM_DATA_MCF_EDMA_H__ > > > > Tested-by: Krzysztof Kozlowski > > > > So this revision fixed the issue we had seen with the previous version? > Do we know what it was exactly? > Well, no. I restarted completely the patch from scratch moving/changing the code carefully. I avoided changes to Freescale code as much as possible. > -- > Stefan > -- > To unsubscribe from this list: send the line "unsubscribe dmaengine" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Regards, Angelo