From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Date: Tue, 07 Aug 2018 14:26:46 +0000 Subject: Re: [PATCH] drm/i915/gvt: Off by one in intel_vgpu_write_fence() Message-Id: <20180807142646.GA2210@intel.com> List-Id: References: <20180807023944.GZ22630@zhen-hp.sh.intel.com> <20180807064602.sagf25ettlvfpidm@kili.mountain> In-Reply-To: <20180807064602.sagf25ettlvfpidm@kili.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: David Airlie , intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, intel-gvt-dev@lists.freedesktop.org On Tue, Aug 07, 2018 at 09:46:02AM +0300, Dan Carpenter wrote: > The > should be >= here so that we don't read one element beyond the > end of the array. > > Fixes: 28a60dee2ce6 ("drm/i915/gvt: vGPU HW resource management") > Signed-off-by: Dan Carpenter Reviewed-by: Rodrigo Vivi > > diff --git a/drivers/gpu/drm/i915/gvt/aperture_gm.c b/drivers/gpu/drm/i915/gvt/aperture_gm.c > index 380eeb2a0e83..fe754022e356 100644 > --- a/drivers/gpu/drm/i915/gvt/aperture_gm.c > +++ b/drivers/gpu/drm/i915/gvt/aperture_gm.c > @@ -131,7 +131,7 @@ void intel_vgpu_write_fence(struct intel_vgpu *vgpu, > > assert_rpm_wakelock_held(dev_priv); > > - if (WARN_ON(fence > vgpu_fence_sz(vgpu))) > + if (WARN_ON(fence >= vgpu_fence_sz(vgpu))) > return; > > reg = vgpu->fence.regs[fence]; From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH] drm/i915/gvt: Off by one in intel_vgpu_write_fence() Date: Tue, 7 Aug 2018 07:26:46 -0700 Message-ID: <20180807142646.GA2210@intel.com> References: <20180807023944.GZ22630@zhen-hp.sh.intel.com> <20180807064602.sagf25ettlvfpidm@kili.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180807064602.sagf25ettlvfpidm@kili.mountain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dan Carpenter Cc: David Airlie , intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, intel-gvt-dev@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBBdWcgMDcsIDIwMTggYXQgMDk6NDY6MDJBTSArMDMwMCwgRGFuIENhcnBlbnRlciB3 cm90ZToKPiBUaGUgPiBzaG91bGQgYmUgPj0gaGVyZSBzbyB0aGF0IHdlIGRvbid0IHJlYWQgb25l IGVsZW1lbnQgYmV5b25kIHRoZQo+IGVuZCBvZiB0aGUgYXJyYXkuCj4gCj4gRml4ZXM6IDI4YTYw ZGVlMmNlNiAoImRybS9pOTE1L2d2dDogdkdQVSBIVyByZXNvdXJjZSBtYW5hZ2VtZW50IikKPiBT aWduZWQtb2ZmLWJ5OiBEYW4gQ2FycGVudGVyIDxkYW4uY2FycGVudGVyQG9yYWNsZS5jb20+CgpS ZXZpZXdlZC1ieTogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgoKPiAKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3Z0L2FwZXJ0dXJlX2dtLmMgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9ndnQvYXBlcnR1cmVfZ20uYwo+IGluZGV4IDM4MGVlYjJhMGU4My4u ZmU3NTQwMjJlMzU2IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d2dC9hcGVy dHVyZV9nbS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3Z0L2FwZXJ0dXJlX2dtLmMK PiBAQCAtMTMxLDcgKzEzMSw3IEBAIHZvaWQgaW50ZWxfdmdwdV93cml0ZV9mZW5jZShzdHJ1Y3Qg aW50ZWxfdmdwdSAqdmdwdSwKPiAgCj4gIAlhc3NlcnRfcnBtX3dha2Vsb2NrX2hlbGQoZGV2X3By aXYpOwo+ICAKPiAtCWlmIChXQVJOX09OKGZlbmNlID4gdmdwdV9mZW5jZV9zeih2Z3B1KSkpCj4g KwlpZiAoV0FSTl9PTihmZW5jZSA+PSB2Z3B1X2ZlbmNlX3N6KHZncHUpKSkKPiAgCQlyZXR1cm47 Cj4gIAo+ICAJcmVnID0gdmdwdS0+ZmVuY2UucmVnc1tmZW5jZV07Cl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50 ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=