Re: [PATCH 1/3] Added SWTOOLS which is needed to build processor libs (DSPLIB, MATHLIB, etc) from source.

[Denys Dmytriyenko <denys@ti.com>]

On Tue, Aug 07, 2018 at 10:45:44AM -0400, Jianzhong Xu wrote:
> Signed-off-by: Jianzhong Xu <xuj@ti.com>
> ---
>  recipes-ti/swtools/swtools_git.bb | 45 +++++++++++++++++++++++++++++++++++++++
>  1 file changed, 45 insertions(+)
>  create mode 100644 recipes-ti/swtools/swtools_git.bb
> 
> diff --git a/recipes-ti/swtools/swtools_git.bb b/recipes-ti/swtools/swtools_git.bb
> new file mode 100644
> index 0000000..bd4c005
> --- /dev/null
> +++ b/recipes-ti/swtools/swtools_git.bb
> @@ -0,0 +1,45 @@
> +DESCRIPTION = "TI Software Tools"

SUMMARY


> +HOMEPAGE = "https://bitbucket.itg.ti.com/projects/PROC_LIBS/repos/swtools/browse"

No bitbucket links


> +SECTION = "devel"
> +LICENSE = "BSD"
> +LIC_FILES_CHKSUM = "file://ti/mas/swtools/copyright.txt;md5=b1f52a1435051fdb18f8885b0384147d"
> +
> +require ../includes/ti-paths.inc
> +
> +DEPENDS = "ti-cgt6x-native \
> +           ti-sysbios \ 
> +           ti-xdctools-native"
> +
> +PV = "5_0_8"
> +PR = "r0"
> +S = "${WORKDIR}/git"
> +BRANCH = "master"
> +SRC_URI = "git://git.ti.com/ep-processor-libraries/swtools.git;protocol=git;branch=${BRANCH}"
> +SRCREV = "881267836907de650edadc56b8e57ab45428021d"
> +
> +export C64PCODEGENTOOL="${CGTOOLS_INSTALL_DIR}"
> +export C674CODEGENTOOL="${CGTOOLS_INSTALL_DIR}"
> +export C66CODEGENTOOL ="${CGTOOLS_INSTALL_DIR}"
> +
> +PATH_append = ":${XDC_INSTALL_DIR}"
> +XDCPATH.="${XDCCGROOT}/include;${XDC_INSTALL_DIR}/packages;${SYSBIOS_INSTALL_DIR}/packages;"

Both of these lines do similar things of appending a string, but using 
different syntax. It's not an issues, but I was wondering if it was on 
purpose...

Also would be nice to keep spacing and indentation consistent. I.e. bitbake 
assignment operators have spaces around them, unlike shell.


> +export XDCPATH
> +
> +do_compile() {
> +	cd ${S}/ti/mas/swtools
> +	xdc
> +}
> +
> +do_install() {
> +    CP_ARGS="-Prf --preserve=mode,timestamps --no-preserve=ownership"
> +    install -d ${D}${SWTOOLS_INSTALL_DIR_RECIPE}
> +    cp -pPrf ${S}/* ${D}${SWTOOLS_INSTALL_DIR_RECIPE}
> +}
> +
> +FILES_${PN}-dev += "${SWTOOLS_INSTALL_DIR_RECIPE}"
> +
> +INSANE_SKIP_${PN}-dev = "arch staticdev"
> +ALLOW_EMPTY_${PN} = "1"
> +
> -- 
> 1.9.1
> 
> -- 
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti