From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14921C46470 for ; Wed, 8 Aug 2018 12:24:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C5AE8219DB for ; Wed, 8 Aug 2018 12:24:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C5AE8219DB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727106AbeHHOn7 (ORCPT ); Wed, 8 Aug 2018 10:43:59 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:41292 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726680AbeHHOn7 (ORCPT ); Wed, 8 Aug 2018 10:43:59 -0400 Received: from localhost (unknown [194.244.16.108]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 4D385CC1; Wed, 8 Aug 2018 12:24:31 +0000 (UTC) Date: Wed, 8 Aug 2018 14:24:28 +0200 From: Greg Kroah-Hartman To: Leonardo =?iso-8859-1?Q?Br=E1s?= Cc: Thomas Petazzoni , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 15/15] staging: fbtft: Replaces custom debug macro with dev_dbg(). Message-ID: <20180808122428.GA22383@kroah.com> References: <8de0b9b85209f4b4a3c8f0f84188a0ee0964bf44.1533686201.git.leobras.c@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8de0b9b85209f4b4a3c8f0f84188a0ee0964bf44.1533686201.git.leobras.c@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 07, 2018 at 09:30:10PM -0300, Leonardo Brás wrote: > Changes custom macro to dev_dbg to avoid parameter multiple usage and use of typeof(). linewrap please. And while this is a good start, please replace the places this custom macro is called with dev_dbg(), and then delete this macro. Don't extend its life with a change like this :( thanks, greg k-h