All of lore.kernel.org
 help / color / mirror / Atom feed
From: jthumshirn@suse.de (Johannes Thumshirn)
Subject: [PATCH nvme-cli v2 1/2] fabrics: write ctrl_loss_tmo to fabrics device on connect
Date: Thu,  9 Aug 2018 11:25:22 +0200	[thread overview]
Message-ID: <20180809092523.10225-2-jthumshirn@suse.de> (raw)
In-Reply-To: <20180809092523.10225-1-jthumshirn@suse.de>

Commit 388c9dbe86be ("fabrics: add ctrl-loss-tmo to connect-all")
introduced the '--ctrl-loss-tmo' option for the connect-all command,
but we forgor to pass down the option to the kernel in connect_ctrl().

Signed-off-by: Johannes Thumshirn <jthumshirn at suse.de>
Fixes: 388c9dbe86be ("fabrics: add ctrl-loss-tmo to connect-all")

fixup! fabrics: write ctrl_loss_tmo to fabrics device on connect
---
 fabrics.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/fabrics.c b/fabrics.c
index 8437e323127a..241d8b86d8e6 100644
--- a/fabrics.c
+++ b/fabrics.c
@@ -621,6 +621,12 @@ static int connect_ctrl(struct nvmf_disc_rsp_page_entry *e)
 		p+= len;
 	}
 
+	if (cfg.ctrl_loss_tmo) {
+		len = sprintf(p, ",ctrl_loss_tmo=%s", cfg.ctrl_loss_tmo);
+		if (len < 0)
+			return -EINVAL;
+		p += len;
+	}
 
 	switch (e->trtype) {
 	case NVMF_TRTYPE_LOOP: /* loop */
-- 
2.16.4

  reply	other threads:[~2018-08-09  9:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-09  9:25 [PATCH nvme-cli v2 0/2] fabrics connect-all fixes Johannes Thumshirn
2018-08-09  9:25 ` Johannes Thumshirn [this message]
2018-08-09  9:25 ` [PATCH nvme-cli v2 2/2] fabrics: write keep-alive-timeout to fabrics device on connect Johannes Thumshirn
2018-08-09 14:59 ` [PATCH nvme-cli v2 0/2] fabrics connect-all fixes Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180809092523.10225-2-jthumshirn@suse.de \
    --to=jthumshirn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.