All of lore.kernel.org
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH 3/4] pc: acpi: add _CST support
Date: Thu, 9 Aug 2018 12:00:11 +0200	[thread overview]
Message-ID: <20180809120011.51023bf2@redhat.com> (raw)
In-Reply-To: <20180808231636-mutt-send-email-mst@kernel.org>

On Wed, 8 Aug 2018 23:17:48 +0300
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Wed, Aug 08, 2018 at 05:15:48PM +0200, Igor Mammedov wrote:
> > Reuse CPU hotplug IO registers for passing a CST entry
> > containing package for shalowest C1 using mwait and
> > read it out in guest with new CCST AML method.  
> 
> I don't see how 1 entry is enough. We need to describe full _CST package so
> that guest can do reasonable power management on the CPU.
I was assuming that CST are to be used for mwait/monitor idle combo
to help reduce latencies/vmexits on cpus wakeup from idle state, hence 1 entry.
It's trivial to add as much as needed entries though.
If you are fine with approach I can respin patch with arbitrary
number of CStates.
 
> > The CState support is optional and could be turned on
> > with '-global PIIX4_PM.cstate=on' CLI option.
> > 
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > ---
[...]

  reply	other threads:[~2018-08-09 10:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-08 15:15 [Qemu-devel] [RFC PATCH 0/4] "pc: acpi: _CST support" Igor Mammedov
2018-08-08 15:15 ` [Qemu-devel] [RFC PATCH 1/4] acpi: aml: add aml_register() Igor Mammedov
2018-08-08 15:15 ` [Qemu-devel] [RFC PATCH 2/4] acpi: add aml_create_byte_field() Igor Mammedov
2018-08-08 15:15 ` [Qemu-devel] [RFC PATCH 3/4] pc: acpi: add _CST support Igor Mammedov
2018-08-08 20:17   ` Michael S. Tsirkin
2018-08-09 10:00     ` Igor Mammedov [this message]
2018-08-09 23:01       ` Michael S. Tsirkin
2018-08-15 13:25         ` Igor Mammedov
2018-08-15 13:25         ` [Qemu-devel] [PATCH " Igor Mammedov
2018-08-08 15:15 ` [Qemu-devel] [RFC PATCH 4/4] acpi: add support for CST update notification Igor Mammedov
2018-08-08 20:20 ` [Qemu-devel] [RFC PATCH 0/4] "pc: acpi: _CST support" Michael S. Tsirkin
2018-08-09 10:13   ` Igor Mammedov
2018-08-09 23:09     ` Michael S. Tsirkin
2018-08-15 13:21       ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180809120011.51023bf2@redhat.com \
    --to=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.