All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Cc: Sandipan Das <sandipan@linux.ibm.com>,
	aneesh.kumar@linux.vnet.ibm.com, jolsa@redhat.com,
	linux-kernel@vger.kernel.org, ravi.bangoria@linux.ibm.com
Subject: Re: [PATCH] perf probe powerpc: Fix trace event post-processing
Date: Thu, 9 Aug 2018 14:44:10 -0300	[thread overview]
Message-ID: <20180809174410.GD5395@kernel.org> (raw)
In-Reply-To: <1533831952.2wznw8gaoa.naveen@linux.ibm.com>

Em Thu, Aug 09, 2018 at 09:56:24PM +0530, Naveen N. Rao escreveu:
> Sandipan Das wrote:
<SNIP>
> > This can be verified on a powerpc64le system as shown below.
<SNIP>
> > Before:
> >   # perf probe -v -a sys_open
<SNIP>
> >   # perf probe -v -a sys_open%return $retval
<SNIP>
> >   Failed to write event: Invalid argument
> >     Error: Failed to add events. Reason: Invalid argument (Code: -22)
> > After:
> >   # perf probe -v -a sys_open
<SNIP>
> >   Writing event: p:probe/sys_open _text+4276888
> >   Added new event:
> >     probe:sys_open       (on sys_open)
> >   ...
> > 
> >   # perf probe -v -a sys_open%return $retval
<SNIP>
> >   Writing event: r:probe/sys_open__return _text+4276888
> >   Added new event:
> >     probe:sys_open__return (on sys_open%return)
> > Fixes: 99e608b5954c ("perf probe ppc64le: Fix probe location when using DWARF")
> > Reported-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> > Signed-off-by: Sandipan Das <sandipan@linux.ibm.com>
 
> Acked-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>

Thanks, applied!

Excellent commit log message, btw, keep it up.

- arnaldo

  reply	other threads:[~2018-08-09 17:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-09 16:19 [PATCH] perf probe powerpc: Fix trace event post-processing Sandipan Das
2018-08-09 16:26 ` Naveen N. Rao
2018-08-09 17:44   ` Arnaldo Carvalho de Melo [this message]
2018-08-18 11:42 ` [tip:perf/urgent] " tip-bot for Sandipan Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180809174410.GD5395@kernel.org \
    --to=acme@kernel.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=naveen.n.rao@linux.vnet.ibm.com \
    --cc=ravi.bangoria@linux.ibm.com \
    --cc=sandipan@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.