All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] qt5wayland: add fix from upstream to compile without QtQuick
Date: Thu, 9 Aug 2018 23:47:36 +0200	[thread overview]
Message-ID: <20180809234736.010b22fc@windsurf> (raw)
In-Reply-To: <1533515813-11533-1-git-send-email-bos@je-eigen-domein.nl>

Hello Floris,

On Mon,  6 Aug 2018 02:36:53 +0200, Floris Bos wrote:

> diff --git a/package/qt5/qt5wayland/Config.in b/package/qt5/qt5wayland/Config.in
> index 0182d3c..9f144ac 100644
> --- a/package/qt5/qt5wayland/Config.in
> +++ b/package/qt5/qt5wayland/Config.in
> @@ -5,8 +5,6 @@ comment "qt5wayland needs an OpenGL-capable backend"

You forgot to drop the "depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE"
dependency from this comment, which only existed because of the
qt5declarative dependency. I've fixed that before applying.

>  config BR2_PACKAGE_QT5WAYLAND
>  	bool "qt5wayland"
>  	depends on BR2_PACKAGE_QT5_GL_AVAILABLE

Is this OpenGL support dependency needed because of qt5wayland itself,
or was it needed only because of the qt5declarative dependency ?

BR2_PACKAGE_WAYLAND doesn't require OpenGL support, so I'm wondering if
qt5wayland needs it or not. If it doesn't, could you send a follow-up
patch fixing this ?

In the mean time, I've applied your patch to next, after fixing the
issue mentioned above regarding the removal of the
BR2_PACKAGE_QT5_JSCORE_AVAILABLE dependency.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-08-09 21:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-06  0:36 [Buildroot] [PATCH v2 1/1] qt5wayland: add fix from upstream to compile without QtQuick Floris Bos
2018-08-09 21:47 ` Thomas Petazzoni [this message]
2018-08-09 21:55   ` Floris Bos
2018-08-09 22:00     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180809234736.010b22fc@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.