From: Joey Pabalinas <joeypabalinas@gmail.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Joey Pabalinas <joeypabalinas@gmail.com>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
Jiri Kosina <jikos@kernel.org>,
Daniel Martin <consume.noise@gmail.com>
Subject: Re: [PATCH 3/4] HID: multitouch: drop reports containing invalid values
Date: Thu, 9 Aug 2018 17:27:47 -1000 [thread overview]
Message-ID: <20180810032747.fawrnvyacl27ss6t@gmail.com> (raw)
In-Reply-To: <CAO-hwJLPm2UgqYU7CgsqX1CNp5JjHu0mZJp-kZnPmZ2qhi1CxQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 794 bytes --]
On Tue, Jul 03, 2018 at 10:13:54AM +0200, Benjamin Tissoires wrote:
> Hi Joey,
> You can't really use plain values like that. There is a tiny chance
> these values are valid on an other device.
> IIRC, MS spec says that we should ignore out of band values if they
> are tagged as such. Such input are tagged with NULL values
> (http://www.usb.org/developers/hidpage/HID1_11.pdf page 31) and MS
> spec mentioned this.
>
> All in all, if you have this bit set, you need to compare the value
> with the logical_max/min for each field.
>
> I never encountered a device that required this, so you are probably
> the lucky one :)
Ah, you are completely right. After giving that pdf a read over
I will definitely be dropping this patch from the v2.
--
Cheers,
Joey Pabalinas
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-08-10 3:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-01 0:19 [PATCH 0/4] reduce Surface Pro 3 multitouch jitter Joey Pabalinas
2018-08-09 23:39 ` [PATCH RESEND " Joey Pabalinas
2018-07-01 0:19 ` [PATCH 1/4] HID: multitouch: add MT_QUIRK_NOT_SEEN_MEANS_UP to MT_CLS_WIN_8 quirks Joey Pabalinas
2018-08-09 23:39 ` [PATCH RESEND " Joey Pabalinas
2018-07-03 7:53 ` [PATCH " Benjamin Tissoires
2018-08-09 23:57 ` Joey Pabalinas
2018-08-10 3:54 ` [PATCH RESEND " Joey Pabalinas
2018-07-01 0:19 ` [PATCH 2/4] HID: multitouch: don't check HID_GROUP_MULTITOUCH_WIN_8 for serial protocol Joey Pabalinas
2018-08-09 23:39 ` [PATCH RESEND " Joey Pabalinas
2018-07-03 8:16 ` [PATCH " Benjamin Tissoires
2018-08-10 3:50 ` Joey Pabalinas
2018-07-01 0:19 ` [PATCH 3/4] HID: multitouch: drop reports containing invalid values Joey Pabalinas
2018-08-09 23:39 ` [PATCH RESEND " Joey Pabalinas
2018-07-03 8:13 ` [PATCH " Benjamin Tissoires
2018-08-10 3:27 ` Joey Pabalinas [this message]
2018-07-01 0:19 ` [PATCH 4/4] HID: multitouch: remove unneeded else conditional cases Joey Pabalinas
2018-08-09 23:39 ` [PATCH RESEND " Joey Pabalinas
2018-07-03 8:17 ` [PATCH " Benjamin Tissoires
2018-08-10 0:03 ` Joey Pabalinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180810032747.fawrnvyacl27ss6t@gmail.com \
--to=joeypabalinas@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=consume.noise@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.