From: Eduardo Habkost <ehabkost@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org,
richard.henderson@linaro.org, Cleber Rosa <crosa@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH 1/4] scripts/decodetree.py: add a disassembly generator (HACK!)
Date: Fri, 10 Aug 2018 00:32:00 -0300 [thread overview]
Message-ID: <20180810033200.GA8773@localhost.localdomain> (raw)
In-Reply-To: <20180808123934.17450-2-alex.bennee@linaro.org>
On Wed, Aug 08, 2018 at 01:39:31PM +0100, Alex Bennée wrote:
> Given our issues with failing disassembly we could try and re-use the
> decode tree data to output what instruction is being decoded. This
> will be used if registered as a fall-back for when the "proper"
> disassembler fails to decode an instruction.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
I don't have an opinion on the approach you are taking, but the
Python code you are adding is consistent with the existing style
of the script.
That said, I find the existing code full of output() calls very
hard to read. If anybody wants to volunteer to improve the
readability of the output generation, it would be welcome.
Acked-by: Eduardo Habkost <ehabkost@redhat.com>
--
Eduardo
next prev parent reply other threads:[~2018-08-10 3:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 12:39 [RFC PATCH 0/4] add hand-rolled fallback when capstone fails Alex Bennée
2018-08-08 12:39 ` [Qemu-devel] " Alex Bennée
2018-08-08 12:39 ` [RFC PATCH 1/4] scripts/decodetree.py: add a disassembly generator (HACK!) Alex Bennée
2018-08-08 12:39 ` [Qemu-devel] " Alex Bennée
2018-08-10 3:32 ` Eduardo Habkost [this message]
2018-08-10 8:55 ` Alex Bennée
2018-08-10 12:21 ` Eduardo Habkost
2018-08-08 12:39 ` [RFC PATCH 2/4] target/arm: move decoder helpers into header Alex Bennée
2018-08-08 12:39 ` [Qemu-devel] " Alex Bennée
2018-08-08 12:39 ` [RFC PATCH 3/4] target/arm: add a fallback disassemble function Alex Bennée
2018-08-08 12:39 ` [Qemu-devel] " Alex Bennée
2018-08-08 12:39 ` [RFC PATCH 4/4] disas: allow capstone to defer to a fallback function on failure Alex Bennée
2018-08-08 12:39 ` [Qemu-devel] " Alex Bennée
2018-08-08 16:09 ` Alex Bennée
2018-08-08 16:09 ` [Qemu-devel] " Alex Bennée
2018-08-15 10:15 ` [Qemu-devel] [RFC PATCH 0/4] add hand-rolled fallback when capstone fails no-reply
2018-08-15 10:15 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180810033200.GA8773@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=crosa@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.