From: Moritz Fischer <mdf@kernel.org>
To: davem@davemloft.net
Cc: keescook@chromium.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, alex.williams@ni.com,
Moritz Fischer <mdf@kernel.org>
Subject: [PATCH 2/2] net: nixge: Don't store skb in app4 field of descriptor
Date: Fri, 10 Aug 2018 18:19:41 -0700 [thread overview]
Message-ID: <20180811011941.6187-3-mdf@kernel.org> (raw)
In-Reply-To: <20180811011941.6187-1-mdf@kernel.org>
Don't store skb in app4 field of descriptor since it is
not being used anywhere (including hardware).
Signed-off-by: Moritz Fischer <mdf@kernel.org>
---
drivers/net/ethernet/ni/nixge.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/ni/nixge.c b/drivers/net/ethernet/ni/nixge.c
index ac31b0d30415..76efed058f33 100644
--- a/drivers/net/ethernet/ni/nixge.c
+++ b/drivers/net/ethernet/ni/nixge.c
@@ -503,7 +503,6 @@ static int nixge_start_xmit(struct sk_buff *skb, struct net_device *ndev)
tx_skb->skb = skb;
cur_p->cntrl |= XAXIDMA_BD_CTRL_TXEOF_MASK;
- cur_p->app4 = (unsigned long)skb;
tail_p = priv->tx_bd_p + sizeof(*priv->tx_bd_v) * priv->tx_bd_tail;
/* Start the transfer */
--
2.18.0
next prev parent reply other threads:[~2018-08-11 1:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-11 1:19 [PATCH 0/2] net: nixge: Minor cleanups Moritz Fischer
2018-08-11 1:19 ` [PATCH 1/2] net: nixge: Do not zero application specific fields in desc Moritz Fischer
2018-08-11 1:19 ` Moritz Fischer [this message]
2018-08-13 15:49 ` [PATCH 0/2] net: nixge: Minor cleanups David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180811011941.6187-3-mdf@kernel.org \
--to=mdf@kernel.org \
--cc=alex.williams@ni.com \
--cc=davem@davemloft.net \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.