From: Greg KH <gregkh@linuxfoundation.org>
To: Ajay Singh <ajay.kathat@microchip.com>
Cc: linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
venkateswara.kaja@microchip.com, ganesh.krishna@microchip.com,
adham.abozaeid@microchip.com, aditya.shankar@microchip.com
Subject: Re: [PATCH 2/5] staging: wilc1000: fixes for undefined reference to `__this_module' error
Date: Sun, 12 Aug 2018 08:42:50 +0200 [thread overview]
Message-ID: <20180812064250.GA31152@kroah.com> (raw)
In-Reply-To: <1534049265-5600-3-git-send-email-ajay.kathat@microchip.com>
On Sun, Aug 12, 2018 at 10:17:42AM +0530, Ajay Singh wrote:
> wilc_debug.o object file is included for both SDIO and SPI module. When
> anyone(either SDIO or SPI) module is compiled as loaded module and another
> as buildin module then below compilation error occurs.
>
> "drivers/staging/wilc1000/wilc_debugfs.o:(.data+0x10): undefined
> reference to `__this_module'"
>
> Moved the declaration of file_operation variable in SDIO/SPI files and
> pass this as parameter to wilc_debugfs_init(). Remove 'fops' element
> from 'wilc_debugfs_info_t' struct, as its not required.
>
> Fixes: 9abc44ba4e2f ("staging: wilc1000: fix TODO to compile spi and sdio components in single module")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
> ---
Can this be the first patch in the series so it can go to Linus for 4.19
and the rest can be postponed for later?
thanks,
greg k-h
next prev parent reply other threads:[~2018-08-12 9:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-12 4:47 [PATCH 0/5] staging: wilc1000: compilation error fixes & cleanup changes Ajay Singh
2018-08-12 4:47 ` [PATCH 1/5] staging: wilc1000: avoid arrray of 'wilc_debugfs_info_t' type Ajay Singh
2018-08-12 11:29 ` Greg KH
2018-08-12 11:48 ` Ajay Singh
2018-08-12 15:24 ` Greg KH
2018-08-13 4:36 ` Ajay Singh
2018-08-12 4:47 ` [PATCH 2/5] staging: wilc1000: fixes for undefined reference to `__this_module' error Ajay Singh
2018-08-12 6:42 ` Greg KH [this message]
2018-08-12 11:22 ` Ajay Singh
2018-08-12 11:27 ` Greg KH
2018-08-12 11:35 ` Greg KH
2018-08-12 12:18 ` Ajay Singh
2018-08-12 15:23 ` Greg KH
2018-08-14 10:56 ` Dan Carpenter
2018-08-14 11:10 ` Arend van Spriel
2018-08-14 11:10 ` Ajay Singh
2018-08-12 4:47 ` [PATCH 3/5] staging: wilc1000: remove the use of 'wilc_debugfs_info_t' struct Ajay Singh
2018-08-12 4:47 ` [PATCH 4/5] staging: wilc1000: change permission to 0600 in debugfs_create_file() call Ajay Singh
2018-08-12 11:36 ` Greg KH
2018-08-12 4:47 ` [PATCH 5/5] staging: wilc1000: use void return for wilc_debugfs_init() Ajay Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180812064250.GA31152@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=adham.abozaeid@microchip.com \
--cc=aditya.shankar@microchip.com \
--cc=ajay.kathat@microchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=ganesh.krishna@microchip.com \
--cc=linux-wireless@vger.kernel.org \
--cc=venkateswara.kaja@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.