All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 01/17] perl-cgi: add host
Date: Sun, 12 Aug 2018 14:11:47 +0200	[thread overview]
Message-ID: <20180812141147.5942e27f@windsurf> (raw)
In-Reply-To: <20180811182749.20924-2-chrismcc@gmail.com>

Hello Christopher,

On Sat, 11 Aug 2018 11:27:33 -0700, Christopher McCrory wrote:
> Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
> ---
>  package/perl-cgi/perl-cgi.mk | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/perl-cgi/perl-cgi.mk b/package/perl-cgi/perl-cgi.mk
> index b8115de6ad..476f5f69c3 100644
> --- a/package/perl-cgi/perl-cgi.mk
> +++ b/package/perl-cgi/perl-cgi.mk
> @@ -8,7 +8,9 @@ PERL_CGI_VERSION = 4.38
>  PERL_CGI_SOURCE = CGI-$(PERL_CGI_VERSION).tar.gz
>  PERL_CGI_SITE = $(BR2_CPAN_MIRROR)/authors/id/L/LE/LEEJO
>  PERL_CGI_DEPENDENCIES = perl-html-parser
> +HOST_PERL_CGI_DEPENDENCIES = host-perl-html-parser

host-perl-html-parser does not exist, until PATCH 02/17 of this series.
Therefore, the order of the patches in your series is not good, and the
series is not bisectable. If I apply only PATCH 01/17, things are
broken because host-perl-cgi-perl will try to build
host-perl-html-parser, which doesn't exist.

Please be careful when ordering the patches: they should be organized
in the correct order to make sure that everything builds at every point
of the series.

In this specific example, you should have the following order:

 (1) Introduce host-perl-html-tagset

 (2) Introduce host-perl-html-parser, which uses host-perl-html-tagset

 (3) Introduce host-perl-cgi, which uses host-perl-html-parser

Does that make sense ?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-08-12 12:11 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-11 18:27 [Buildroot] [PATCH 00/17] even more perl modules Christopher McCrory
2018-08-11 18:27 ` [Buildroot] [PATCH 01/17] perl-cgi: add host Christopher McCrory
2018-08-12 12:11   ` Thomas Petazzoni [this message]
2018-08-13 13:23     ` Christopher McCrory
2018-08-11 18:27 ` [Buildroot] [PATCH 02/17] perl-html-parser: " Christopher McCrory
2018-08-11 18:27 ` [Buildroot] [PATCH 03/17] perl-html-tagset: " Christopher McCrory
2018-08-11 18:27 ` [Buildroot] [PATCH 04/17] perl-class-std-fast: new package Christopher McCrory
2018-08-12 16:45   ` François Perrad
2018-08-12 21:17   ` Thomas Petazzoni
2018-08-12 21:18     ` Thomas Petazzoni
2018-08-13 11:21   ` Thomas Petazzoni
2018-08-11 18:27 ` [Buildroot] [PATCH 05/17] perl-data-optlist: " Christopher McCrory
2018-08-12 16:46   ` François Perrad
2018-08-13 11:21   ` Thomas Petazzoni
2018-08-11 18:27 ` [Buildroot] [PATCH 06/17] perl-module-runtime: add host Christopher McCrory
2018-08-12  9:21   ` François Perrad
2018-08-12 12:13     ` Thomas Petazzoni
2018-08-13 21:59       ` Thomas Petazzoni
2018-08-11 18:27 ` [Buildroot] [PATCH 07/17] perl-dist-checkconflicts: new package Christopher McCrory
2018-08-14  3:59   ` François Perrad
2018-08-11 18:27 ` [Buildroot] [PATCH 08/17] perl-io-socket-multicast: " Christopher McCrory
2018-08-12 16:48   ` François Perrad
2018-08-13 12:16   ` Thomas Petazzoni
2018-08-11 18:27 ` [Buildroot] [PATCH 09/17] perl-mime-tools: " Christopher McCrory
2018-08-12 16:49   ` François Perrad
2018-08-13 12:16   ` Thomas Petazzoni
2018-08-11 18:27 ` [Buildroot] [PATCH 10/17] perl-module-implementation: " Christopher McCrory
2018-08-12 16:50   ` François Perrad
2018-08-13 21:31   ` Thomas Petazzoni
2018-08-11 18:27 ` [Buildroot] [PATCH 11/17] perl-package-stash: " Christopher McCrory
2018-08-11 19:37   ` François Perrad
2018-08-11 21:31     ` Christopher McCrory
2018-08-13 21:31       ` Thomas Petazzoni
2018-08-11 18:27 ` [Buildroot] [PATCH 12/17] perl-template-toolkit: " Christopher McCrory
2018-08-12  8:04   ` François Perrad
2018-08-13 21:33     ` Thomas Petazzoni
2018-08-11 18:27 ` [Buildroot] [PATCH 13/17] perl-time-parsedate: " Christopher McCrory
2018-08-12 16:51   ` François Perrad
2018-08-13 21:46   ` Thomas Petazzoni
2018-08-11 18:27 ` [Buildroot] [PATCH 14/17] perl-x10: " Christopher McCrory
2018-08-12 16:52   ` François Perrad
2018-08-13 21:49   ` Thomas Petazzoni
2018-08-11 18:27 ` [Buildroot] [PATCH 15/17] perl-module-build: add target Christopher McCrory
2018-08-12  8:07   ` François Perrad
2018-08-13 21:34     ` Thomas Petazzoni
2018-08-11 18:27 ` [Buildroot] [PATCH 16/17] perl-class-load: new package Christopher McCrory
2018-08-12 16:57   ` François Perrad
2018-08-13 21:35     ` Thomas Petazzoni
2018-08-11 18:27 ` [Buildroot] [PATCH 17/17] perl-termreadkey: " Christopher McCrory
2018-08-12 16:55   ` François Perrad
2018-08-13 21:57   ` Thomas Petazzoni
2018-08-13 22:40     ` Arnout Vandecappelle
2018-08-14 15:53     ` Yann E. MORIN
2018-08-15 11:24       ` Christopher McCrory
2018-08-15 16:23         ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180812141147.5942e27f@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.