From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH] of: mdio: Support fixed links in of_phy_get_and_connect()
Date: Sun, 12 Aug 2018 19:24:14 +0200
Message-ID: <20180812172414.GC5354@lunn.ch>
References: <20180711174511.15308-1-linus.walleij@linaro.org>
 <20180711200452.GD21430@lunn.ch>
 <CACRpkdb_moz2076y2Wcu88BqEOuKkKvj4seZt+-1v0+LYbaW8w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        netdev <netdev@vger.kernel.org>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
To: Linus Walleij <linus.walleij@linaro.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:33664 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727815AbeHLUC7 (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sun, 12 Aug 2018 16:02:59 -0400
Content-Disposition: inline
In-Reply-To: <CACRpkdb_moz2076y2Wcu88BqEOuKkKvj4seZt+-1v0+LYbaW8w@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

> It's confusing, I guess these PHY's don't come and go
> very much so the plug/play part isn't really exercised.

Very true. We sometimes need to handle -EPROBE_DEFER, which is not too
different from hot-plugging PHYs. Also, SFP modules are hot-pluggable,
and can contain a copper PHY. However, SFP modules don't have a
traditional MIDO bus. MDIO is tunnelled over i2c. So when a copper SFP
module is hotplugged, the MDIO bus is hot plugged as well.

If you do decided to make any changes here, please ask Russell King to
test, otherwise you might break this use case.

      Andrew