From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Mon, 13 Aug 2018 10:48:45 +0200 (CEST) Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:41704 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S23992759AbeHMIslaOSbz (ORCPT ); Mon, 13 Aug 2018 10:48:41 +0200 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w7D8hlRD076134 for ; Mon, 13 Aug 2018 04:48:40 -0400 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0b-001b2d01.pphosted.com with ESMTP id 2ku60k22fv-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 13 Aug 2018 04:48:39 -0400 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 13 Aug 2018 09:48:38 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 13 Aug 2018 09:48:33 +0100 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w7D8mW1645809726 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 13 Aug 2018 08:48:32 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B56294C040; Mon, 13 Aug 2018 11:48:38 +0100 (BST) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CE24F4C04A; Mon, 13 Aug 2018 11:48:35 +0100 (BST) Received: from linux.vnet.ibm.com (unknown [9.40.192.68]) by d06av22.portsmouth.uk.ibm.com (Postfix) with SMTP; Mon, 13 Aug 2018 11:48:35 +0100 (BST) Date: Mon, 13 Aug 2018 01:48:28 -0700 From: Srikar Dronamraju To: Ravi Bangoria Cc: oleg@redhat.com, rostedt@goodmis.org, mhiramat@kernel.org, liu.song.a23@gmail.com, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, jolsa@redhat.com, namhyung@kernel.org, linux-kernel@vger.kernel.org, ananth@linux.vnet.ibm.com, alexis.berlemont@gmail.com, naveen.n.rao@linux.vnet.ibm.com, linux-arm-kernel@lists.infradead.org, linux-mips@linux-mips.org, linux@armlinux.org.uk, ralf@linux-mips.org, paul.burton@mips.com Subject: Re: [PATCH v8 5/6] trace_uprobe/sdt: Prevent multiple reference counter for same uprobe Reply-To: Srikar Dronamraju References: <20180809041856.1547-1-ravi.bangoria@linux.ibm.com> <20180809041856.1547-6-ravi.bangoria@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20180809041856.1547-6-ravi.bangoria@linux.ibm.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-GCONF: 00 x-cbid: 18081308-0028-0000-0000-000002E9F4F2 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18081308-0029-0000-0000-000023A30F2D Message-Id: <20180813084828.GA44470@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-08-13_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=953 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1808130097 Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 65555 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: srikar@linux.vnet.ibm.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips * Ravi Bangoria [2018-08-09 09:48:55]: > We assume to have only one reference counter for one uprobe. > Don't allow user to add multiple trace_uprobe entries having > same inode+offset but different reference counter. > > Ex, > # echo "p:sdt_tick/loop2 /home/ravi/tick:0x6e4(0x10036)" > uprobe_events > # echo "p:sdt_tick/loop2_1 /home/ravi/tick:0x6e4(0xfffff)" >> uprobe_events > bash: echo: write error: Invalid argument > > # dmesg > trace_kprobe: Reference counter offset mismatch. > > There is one exception though: > When user is trying to replace the old entry with the new > one, we allow this if the new entry does not conflict with > any other existing entries. > > Signed-off-by: Ravi Bangoria > --- Looks good to me. Acked-by: Srikar Dronamraju From mboxrd@z Thu Jan 1 00:00:00 1970 From: srikar@linux.vnet.ibm.com (Srikar Dronamraju) Date: Mon, 13 Aug 2018 01:48:28 -0700 Subject: [PATCH v8 5/6] trace_uprobe/sdt: Prevent multiple reference counter for same uprobe In-Reply-To: <20180809041856.1547-6-ravi.bangoria@linux.ibm.com> References: <20180809041856.1547-1-ravi.bangoria@linux.ibm.com> <20180809041856.1547-6-ravi.bangoria@linux.ibm.com> Message-ID: <20180813084828.GA44470@linux.vnet.ibm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Ravi Bangoria [2018-08-09 09:48:55]: > We assume to have only one reference counter for one uprobe. > Don't allow user to add multiple trace_uprobe entries having > same inode+offset but different reference counter. > > Ex, > # echo "p:sdt_tick/loop2 /home/ravi/tick:0x6e4(0x10036)" > uprobe_events > # echo "p:sdt_tick/loop2_1 /home/ravi/tick:0x6e4(0xfffff)" >> uprobe_events > bash: echo: write error: Invalid argument > > # dmesg > trace_kprobe: Reference counter offset mismatch. > > There is one exception though: > When user is trying to replace the old entry with the new > one, we allow this if the new entry does not conflict with > any other existing entries. > > Signed-off-by: Ravi Bangoria > --- Looks good to me. Acked-by: Srikar Dronamraju