Re: [EXTERNAL] [PATCH] recipes-ti: devtools: add GCC Linaro toolchain 2017.11 v7.2.1

[Denys Dmytriyenko <denys@ti.com>]

On Sun, Aug 12, 2018 at 09:02:12AM -0400, Nelson, Sam wrote:
> 
> 
> > -----Original Message-----
> > From: Dmytriyenko, Denys
> > Sent: Saturday, August 11, 2018 12:14 AM
> > To: Nelson, Sam
> > Cc: Zhang, Hao; meta-ti@yoctoproject.org
> > Subject: Re: [meta-ti] [EXTERNAL] [PATCH] recipes-ti: devtools: add GCC
> > Linaro toolchain 2017.11 v7.2.1
> > 
> > On Sat, Aug 11, 2018 at 02:47:10AM +0000, Nelson, Sam wrote:
> > >
> > >
> > > > -----Original Message-----
> > > > From: meta-ti-bounces@yoctoproject.org [mailto:meta-ti-
> > > > bounces@yoctoproject.org] On Behalf Of Zhang, Hao
> > > > Sent: Friday, August 10, 2018 10:24 AM
> > > > To: meta-ti@yoctoproject.org
> > > > Subject: [EXTERNAL] [meta-ti] [PATCH] recipes-ti: devtools: add GCC
> > Linaro
> > > > toolchain 2017.11 v7.2.1
> > > >
> > > > From: Hao Zhang <hzhang@ti.com>
> > > >
> > > > Signed-off-by: Hao Zhang <hzhang@ti.com>
> > > > ---
> > > >  recipes-ti/devtools/gcc-linaro-aarch64-native.bb | 24
> > > > ++++++++++++++++++++++++
> > > >  recipes-ti/devtools/gcc-linaro-native.bb         | 24
> > > > ++++++++++++++++++++++++
> > > >  recipes-ti/devtools/gcc-linaro.inc               | 12 ++++++++++++
> > > >  recipes-ti/includes/ti-paths.inc                 |  2 ++
> > > >  4 files changed, 62 insertions(+)
> > > >  create mode 100644 recipes-ti/devtools/gcc-linaro-aarch64-native.bb
> > > >  create mode 100644 recipes-ti/devtools/gcc-linaro-native.bb
> > > >  create mode 100644 recipes-ti/devtools/gcc-linaro.inc
> > > >
> > > > diff --git a/recipes-ti/devtools/gcc-linaro-aarch64-native.bb b/recipes-
> > > > ti/devtools/gcc-linaro-aarch64-native.bb
> > > > new file mode 100644
> > > > index 0000000..6c0482d
> > > > --- /dev/null
> > > > +++ b/recipes-ti/devtools/gcc-linaro-aarch64-native.bb
> > > > @@ -0,0 +1,24 @@
> > > > +include recipes-ti/devtools/gcc-linaro.inc
> > > > +
> > > > +PACKAGE_DIR = "gcc-linaro-${PV}-${GCC_ARM_YEAR}-x86_64_aarch64-
> > elf"
> > > > +S = "${WORKDIR}/${PACKAGE_DIR}"
> > > > +
> > > > +LIC_CHKSUM = "bc7fad4bba98e7a4cd5ab3042506493c"
> > > > +
> > > > +inherit native
> > > > +require recipes-ti/includes/ti-paths.inc
> > > > +
> > > > +SRC_URI =
> > "https://releases.linaro.org/components/toolchain/binaries/7.2-
> > > > ${GCC_ARM_YEAR}/aarch64-elf/gcc-linaro-${PV}-${GCC_ARM_YEAR}-
> > > > x86_64_aarch64-elf.tar.xz;name=gcc-linaro-aarch64"
> > > > +
> > > > +SRC_URI[gcc-linaro-aarch64.md5sum] =
> > > > "4972f8943820bdd2f577f498de78964b"
> > > > +SRC_URI[gcc-linaro-aarch64.sha256sum] =
> > > >
> > "30fb7d876bcb982c502057c593d9c1f11b35d5158a26d986718e2b998388c4
> > > > c8"
> > > > +
> > > > +do_install() {
> > > > +    install -d ${D}${GCC_LINARO_AARCH64_TOOLCHAIN_RECIPE}
> > > > +    cp -r ${S}/. ${D}${GCC_LINARO_AARCH64_TOOLCHAIN_RECIPE}
> > > > +}
> > > > +
> > > > +FILES_${PN} = "${GCC_LINARO_AARCH64_TOOLCHAIN_RECIPE}/*"
> > > > +
> > > > +INSANE_SKIP_${PN} = "already-stripped"
> > > > +
> > > > diff --git a/recipes-ti/devtools/gcc-linaro-native.bb b/recipes-
> > ti/devtools/gcc-
> > > > linaro-native.bb
> > > > new file mode 100644
> > > > index 0000000..767c0c0
> > > > --- /dev/null
> > > > +++ b/recipes-ti/devtools/gcc-linaro-native.bb
> > > > @@ -0,0 +1,24 @@
> > > > +include recipes-ti/devtools/gcc-linaro.inc
> > > > +
> > > > +PACKAGE_DIR = "gcc-linaro-${PV}-${GCC_ARM_YEAR}-x86_64_arm-eabi"
> > > > +S = "${WORKDIR}/${PACKAGE_DIR}"
> > > > +
> > > > +LIC_CHKSUM = "bc7fad4bba98e7a4cd5ab3042506493c"
> > > > +
> > > > +inherit native
> > > > +require recipes-ti/includes/ti-paths.inc
> > > > +
> > > > +SRC_URI =
> > "https://releases.linaro.org/components/toolchain/binaries/7.2-
> > > > ${GCC_ARM_YEAR}/arm-eabi/gcc-linaro-${PV}-${GCC_ARM_YEAR}-
> > > > x86_64_arm-eabi.tar.xz;name=gcc-linaro"
> > > > +
> > > > +SRC_URI[gcc-linaro.md5sum] = "9a4a39cfc78c84375b1160aa93587aed"
> > > > +SRC_URI[gcc-linaro.sha256sum] =
> > > >
> > "45fc4f90af2e2e9c3197a275f6005ef5639f7a1889fa3eb24c3125ccd70fcd3d"
> > > > +
> > > > +do_install() {
> > > > +    install -d ${D}${GCC_LINARO_TOOLCHAIN_RECIPE}
> > > > +    cp -r ${S}/. ${D}${GCC_LINARO_TOOLCHAIN_RECIPE}
> > > > +}
> > > > +
> > > > +FILES_${PN} = "${GCC_LINARO_TOOLCHAIN_RECIPE}/*"
> > > > +
> > > > +INSANE_SKIP_${PN} = "already-stripped"
> > > > +
> > > > diff --git a/recipes-ti/devtools/gcc-linaro.inc b/recipes-ti/devtools/gcc-
> > > > linaro.inc
> > > > new file mode 100644
> > > > index 0000000..6575fc5
> > > > --- /dev/null
> > > > +++ b/recipes-ti/devtools/gcc-linaro.inc
> > > > @@ -0,0 +1,12 @@
> > > > +DESCRIPTION = "Linaro GCC for ARM"
> > > > +HOMEPAGE = "https://launchpad.net/gcc-arm-embedded"
> > > > +SECTION = "devel"
> > > > +LICENSE = "GPL-3.0-with-GCC-exception & GPLv3"
> > > > +LIC_FILES_CHKSUM = "file://share/doc/gcc/GNU-Free-Documentation-
> > > > License.html;md5=${LIC_CHKSUM}"
> > > > +
> > > > +PV = "7.2.1"
> > > > +PR = "r0"
> > > > +
> > > > +GCC_ARM_YEAR = "2017.11"
> > > > +
> > > > +
> > > > diff --git a/recipes-ti/includes/ti-paths.inc b/recipes-ti/includes/ti-
> > paths.inc
> > > > index 4f99d5e..ef2feae 100644
> > > > --- a/recipes-ti/includes/ti-paths.inc
> > > > +++ b/recipes-ti/includes/ti-paths.inc
> > > > @@ -56,6 +56,8 @@ export CG_XML_INSTALL_DIR_RECIPE     =
> > > > "${installdir}/ti-cg-xml-tree"
> > > >  export OMP_INSTALL_DIR_RECIPE        = "${installdir}/ti-omp-tree"
> > > >  export MPM_INSTALL_DIR_RECIPE        = "${installdir}/ti-mpm-tree"
> > > >  export TI_CGT6X_7_INSTALL_DIR_RECIPE   = "${installdir}/cgt6x-7"
> > > > +export GCC_LINARO_TOOLCHAIN_RECIPE          = "${installdir}/gcc-linaro"
> > > > +export GCC_LINARO_AARCH64_TOOLCHAIN_RECIPE  = "${installdir}/gcc-
> > linaro-aarch64"
> > 
> > NAK
> > 
> 
> > > Also need to add the following for completeness:
> > > export GCC_LINARO_TOOLCHAIN        =
> > "${STAGING_DIR_NATIVE}${GCC_LINARO_TOOLCHAIN_RECIPE}"
> > > export GCC_LINARO_AARCH64_TOOLCHAIN        =
> > "${STAGING_DIR_NATIVE}${GCC_LINARO_AARCH64_TOOLCHAIN_RECIPE}"
> > 
> > NAK
> > 
> > "GCC Linaro" name is confusing in this context.
> > 
> 
> Given the compiler referred here is GCC Linaro. I am not sure whether we can avoid using GCC Linaro it.
> Any alternate suggestions? Is GCC_ARM_LINARO_AARCH64_TOOLCHAIN_DIR acceptable?

My point is that we've been using Linaro GCC toolchain successfully to compile 
everything in our Linux SDKs for years - this addition has nothing to do with 
that and hence, confusing.

What you are adding here is "bare-metal" toolchain for RTOS, so please name it 
respectively, so it won't be confusing to Linux users. Thanks.


> > > >  # This is where the tools will end up in sysroot
> > > >  export BIOS_INSTALL_DIR       =
> > > > "${STAGING_DIR_TARGET}${BIOS_INSTALL_DIR_RECIPE}"
> > > > --
> > > > 2.7.4
> > > >
> > > > --
> > > > _______________________________________________
> > > > meta-ti mailing list
> > > > meta-ti@yoctoproject.org
> > > > https://lists.yoctoproject.org/listinfo/meta-ti
> > > --
> > > _______________________________________________
> > > meta-ti mailing list
> > > meta-ti@yoctoproject.org
> > > https://lists.yoctoproject.org/listinfo/meta-ti