From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Kim Phillips <kim.phillips@arm.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Dongjiu Geng <gengdongjiu@huawei.com>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tools: arm-spe: Fix uninitialized record error variable
Date: Mon, 13 Aug 2018 15:55:11 -0300 [thread overview]
Message-ID: <20180813185511.GA2146@redhat.com> (raw)
In-Reply-To: <20180810174512.52900813e57cbccf18ce99a2@arm.com>
Em Fri, Aug 10, 2018 at 05:45:12PM -0500, Kim Phillips escreveu:
> The auxtrace init variable 'err' was not being initialized, leading
> perf to abort early in an SPE record command when there was no explicit
> error, rather only based whatever memory contents were on the stack.
> Initialize it explicitly on getting an SPE successfully, the same way
> cs-etm does.
>
> Signed-off-by: Kim Phillips <kim.phillips@arm.com>
> ---
> Hi Arnaldo, please apply to perf/urgent / stable series if at all
> possible. Thank you.
In such cases the best thing is to have a "Fixes: ..." so that this gets
automatically picked by the stabe trees, I'll try to find out what was
the patch that introduced this problem.
- Arnaldo
next prev parent reply other threads:[~2018-08-13 18:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-10 22:45 [PATCH] perf tools: arm-spe: Fix uninitialized record error variable Kim Phillips
2018-08-13 18:55 ` Arnaldo Carvalho de Melo [this message]
2018-08-13 18:59 ` Arnaldo Carvalho de Melo
2018-08-18 11:57 ` [tip:perf/urgent] perf arm spe: " tip-bot for Kim Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180813185511.GA2146@redhat.com \
--to=acme@redhat.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=gengdongjiu@huawei.com \
--cc=jolsa@redhat.com \
--cc=kim.phillips@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.